⚡ Enable esModuleInterop compiler option and upgrade to TypeScript 4.6 (#3106)

* ⚡ Enable `esModuleInterop` for /core

* ⚡ Adjust imports in /core

* ⚡ Enable `esModuleInterop` for /cli

* ⚡ Adjust imports in /cli

* ⚡ Enable `esModuleInterop` for /nodes-base

* ⚡ Adjust imports in /nodes-base

* ⚡ Make imports consistent

* ⬆️ Upgrade TypeScript to 4.6 (#3109)

* ⬆️ Upgrade TypeScript to 4.6

* 📦 Update package-lock.json

* 🔧 Avoid erroring on untyped errors

* 📘 Fix type error

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

packages/cli/test/integration/auth.endpoints.test.ts

@@ -0,0 +1,149 @@
+import { hashSync, genSaltSync } from 'bcryptjs';
+import express from 'express';
+import validator from 'validator';
+import { v4 as uuid } from 'uuid';
+
+import * as config from '../../config';
+import * as utils from './shared/utils';
+import { LOGGED_OUT_RESPONSE_BODY } from './shared/constants';
+import { Db } from '../../src';
+import { Role } from '../../src/databases/entities/Role';
+import { randomEmail, randomValidPassword, randomName } from './shared/random';
+import { getGlobalOwnerRole } from './shared/testDb';
+import * as testDb from './shared/testDb';
+
+jest.mock('../../src/telemetry');
+
+let globalOwnerRole: Role;
+
+let app: express.Application;
+let testDbName = '';
+
+beforeAll(async () => {
+	app = utils.initTestServer({ endpointGroups: ['auth'], applyAuth: true });
+	const initResult = await testDb.init();
+	testDbName = initResult.testDbName;
+
+	await testDb.truncate(['User'], testDbName);
+
+	globalOwnerRole = await getGlobalOwnerRole();
+	utils.initTestLogger();
+	utils.initTestTelemetry();
+});
+
+beforeEach(async () => {
+	await testDb.createUser({
+		id: uuid(),
+		email: TEST_USER.email,
+		firstName: TEST_USER.firstName,
+		lastName: TEST_USER.lastName,
+		password: TEST_USER.password,
+		globalRole: globalOwnerRole,
+	});
+
+	config.set('userManagement.isInstanceOwnerSetUp', true);
+
+	await Db.collections.Settings!.update(
+		{ key: 'userManagement.isInstanceOwnerSetUp' },
+		{ value: JSON.stringify(true) },
+	);
+});
+
+afterEach(async () => {
+	await testDb.truncate(['User'], testDbName);
+});
+
+afterAll(async () => {
+	await testDb.terminate(testDbName);
+});
+
+test('POST /login should log user in', async () => {
+	const authlessAgent = utils.createAgent(app);
+
+	const response = await authlessAgent.post('/login').send({
+		email: TEST_USER.email,
+		password: TEST_USER.password,
+	});
+
+	expect(response.statusCode).toBe(200);
+
+	const {
+		id,
+		email,
+		firstName,
+		lastName,
+		password,
+		personalizationAnswers,
+		globalRole,
+		resetPasswordToken,
+	} = response.body.data;
+
+	expect(validator.isUUID(id)).toBe(true);
+	expect(email).toBe(TEST_USER.email);
+	expect(firstName).toBe(TEST_USER.firstName);
+	expect(lastName).toBe(TEST_USER.lastName);
+	expect(password).toBeUndefined();
+	expect(personalizationAnswers).toBeNull();
+	expect(password).toBeUndefined();
+	expect(resetPasswordToken).toBeUndefined();
+	expect(globalRole).toBeDefined();
+	expect(globalRole.name).toBe('owner');
+	expect(globalRole.scope).toBe('global');
+
+	const authToken = utils.getAuthToken(response);
+	expect(authToken).toBeDefined();
+});
+
+test('GET /login should receive logged in user', async () => {
+	const owner = await Db.collections.User!.findOneOrFail();
+	const authOwnerAgent = utils.createAgent(app, { auth: true, user: owner });
+
+	const response = await authOwnerAgent.get('/login');
+
+	expect(response.statusCode).toBe(200);
+
+	const {
+		id,
+		email,
+		firstName,
+		lastName,
+		password,
+		personalizationAnswers,
+		globalRole,
+		resetPasswordToken,
+	} = response.body.data;
+
+	expect(validator.isUUID(id)).toBe(true);
+	expect(email).toBe(TEST_USER.email);
+	expect(firstName).toBe(TEST_USER.firstName);
+	expect(lastName).toBe(TEST_USER.lastName);
+	expect(password).toBeUndefined();
+	expect(personalizationAnswers).toBeNull();
+	expect(password).toBeUndefined();
+	expect(resetPasswordToken).toBeUndefined();
+	expect(globalRole).toBeDefined();
+	expect(globalRole.name).toBe('owner');
+	expect(globalRole.scope).toBe('global');
+
+	expect(response.headers['set-cookie']).toBeUndefined();
+});
+
+test('POST /logout should log user out', async () => {
+	const owner = await Db.collections.User!.findOneOrFail();
+	const authOwnerAgent = utils.createAgent(app, { auth: true, user: owner });
+
+	const response = await authOwnerAgent.post('/logout');
+
+	expect(response.statusCode).toBe(200);
+	expect(response.body).toEqual(LOGGED_OUT_RESPONSE_BODY);
+
+	const authToken = utils.getAuthToken(response);
+	expect(authToken).toBeUndefined();
+});
+
+const TEST_USER = {
+	email: randomEmail(),
+	password: randomValidPassword(),
+	firstName: randomName(),
+	lastName: randomName(),
+};

packages/cli/test/integration/auth.mw.test.ts

@@ -1,6 +1,6 @@
-import express = require('express');
+import express from 'express';
 
-import * as request from 'supertest';
+import request from 'supertest';
 import {
 	REST_PATH_SEGMENT,
 	ROUTES_REQUIRING_AUTHORIZATION,

packages/cli/test/integration/credentials.api.test.ts

@@ -1,4 +1,4 @@
-import express = require('express');
+import express from 'express';
 import { UserSettings } from 'n8n-core';
 import { Db } from '../../src';
 import { randomName, randomString } from './shared/random';

packages/cli/test/integration/me.api.test.ts

@@ -1,8 +1,8 @@
-import express = require('express');
+import express from 'express';
 import validator from 'validator';
 import { IsNull } from 'typeorm';
 
-import config = require('../../config');
+import config from '../../config';
 import * as utils from './shared/utils';
 import { SUCCESS_RESPONSE_BODY } from './shared/constants';
 import { Db } from '../../src';

packages/cli/test/integration/owner.api.test.ts

@@ -1,10 +1,10 @@
-import express = require('express');
+import express from 'express';
 import validator from 'validator';
 
 import * as utils from './shared/utils';
 import * as testDb from './shared/testDb';
 import { Db } from '../../src';
-import config = require('../../config');
+import config from '../../config';
 import {
 	randomEmail,
 	randomName,

packages/cli/test/integration/passwordReset.api.test.ts

@@ -1,9 +1,9 @@
-import express = require('express');
+import express from 'express';
 import { v4 as uuid } from 'uuid';
 
 import * as utils from './shared/utils';
 import { Db } from '../../src';
-import config = require('../../config');
+import config from '../../config';
 import { compare } from 'bcryptjs';
 import {
 	randomEmail,

packages/cli/test/integration/shared/constants.ts

@@ -1,4 +1,4 @@
-import config = require('../../../config');
+import config from '../../../config';
 
 export const REST_PATH_SEGMENT = config.getEnv('endpoints.rest') as Readonly<string>;
 

packages/cli/test/integration/shared/testDb.ts

@@ -1,7 +1,7 @@
 import { createConnection, getConnection, ConnectionOptions, Connection } from 'typeorm';
 import { Credentials, UserSettings } from 'n8n-core';
 
-import config = require('../../../config');
+import config from '../../../config';
 import { BOOTSTRAP_MYSQL_CONNECTION_NAME, BOOTSTRAP_POSTGRES_CONNECTION_NAME } from './constants';
 import { DatabaseType, Db, ICredentialsDb, IDatabaseCollections } from '../../../src';
 import { randomEmail, randomName, randomString, randomValidPassword } from './random';

packages/cli/test/integration/shared/utils.ts

@@ -1,16 +1,16 @@
 import { randomBytes } from 'crypto';
 import { existsSync } from 'fs';
-import express = require('express');
-import * as superagent from 'superagent';
-import * as request from 'supertest';
+import express from 'express';
+import superagent from 'superagent';
+import request from 'supertest';
 import { URL } from 'url';
-import bodyParser = require('body-parser');
-import * as util from 'util';
+import bodyParser from 'body-parser';
+import util from 'util';
 import { createTestAccount } from 'nodemailer';
 import { INodeTypes, LoggerProxy } from 'n8n-workflow';
 import { UserSettings } from 'n8n-core';
 
-import config = require('../../../config');
+import config from '../../../config';
 import { AUTHLESS_ENDPOINTS, REST_PATH_SEGMENT } from './constants';
 import { AUTH_COOKIE_NAME } from '../../../src/constants';
 import { addRoutes as authMiddleware } from '../../../src/UserManagement/routes';

packages/cli/test/integration/users.api.test.ts

@@ -1,9 +1,9 @@
-import express = require('express');
+import express from 'express';
 import validator from 'validator';
 import { v4 as uuid } from 'uuid';
 
 import { Db } from '../../src';
-import config = require('../../config');
+import config from '../../config';
 import { SUCCESS_RESPONSE_BODY } from './shared/constants';
 import {
 	randomEmail,

packages/cli/test/setup.ts

@@ -1,7 +1,7 @@
 import { exec as callbackExec } from 'child_process';
 import { promisify } from 'util';
 
-import config = require('../config');
+import config from '../config';
 import { BOOTSTRAP_MYSQL_CONNECTION_NAME } from './integration/shared/constants';
 
 const exec = promisify(callbackExec);

packages/cli/test/teardown.ts

@@ -1,5 +1,5 @@
 import { createConnection } from 'typeorm';
-import config = require('../config');
+import config from '../config';
 import { exec } from 'child_process';
 import { getBootstrapMySqlOptions, getBootstrapPostgresOptions } from './integration/shared/testDb';
 import { BOOTSTRAP_MYSQL_CONNECTION_NAME } from './integration/shared/constants';