From 03be725cef3ea533ec032a9554df5da15f725b78 Mon Sep 17 00:00:00 2001 From: Jimw383 <47244243+Jimw383@users.noreply.github.com> Date: Mon, 24 Apr 2023 12:36:50 +0200 Subject: [PATCH] SSO/SAML : add Base URL to redirects in acsHandler (#5923) add Base URL to redirects in acsHandler I modified the redirections to include the base URL of the instance so that the redirects remain correct even if the instance is accessed from a subdirectory. Co-authored-by: Michael Auerswald --- packages/cli/src/sso/saml/routes/saml.controller.ee.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/sso/saml/routes/saml.controller.ee.ts b/packages/cli/src/sso/saml/routes/saml.controller.ee.ts index 232020b59..c6b04cae4 100644 --- a/packages/cli/src/sso/saml/routes/saml.controller.ee.ts +++ b/packages/cli/src/sso/saml/routes/saml.controller.ee.ts @@ -1,4 +1,5 @@ import express from 'express'; +import { getInstanceBaseUrl } from '@/UserManagement/UserManagementHelper'; import { Authorized, Get, Post, RestController } from '@/decorators'; import { SamlUrls } from '../constants'; import { @@ -125,9 +126,9 @@ export class SamlController { if (isSamlLicensedAndEnabled()) { await issueCookie(res, loginResult.authenticatedUser); if (loginResult.onboardingRequired) { - return res.redirect(SamlUrls.samlOnboarding); + return res.redirect(getInstanceBaseUrl() + SamlUrls.samlOnboarding); } else { - return res.redirect(SamlUrls.defaultRedirect); + return res.redirect(getInstanceBaseUrl() + SamlUrls.defaultRedirect); } } else { return res.status(202).send(loginResult.attributes);