refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174)

*  Initial setup

* 👕 Update `.eslintignore`

* 👕 Autofix node-param-default-missing (#3173)

* 🔥 Remove duplicate key

* 👕 Add exceptions

* 📦 Update package-lock.json

* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)

* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)

* 👕 Apply `node-class-description-outputs-wrong` (#3178)

* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)

* 👕 Apply `node-param-default-wrong-for-collection` (#3180)

* 👕 Apply node-param-default-wrong-for-boolean (#3181)

* Autofixed default missing

* Autofixed booleans, worked well

*  Fix params

*  Undo exempted autofixes

* 📦 Update package-lock.json

* 👕 Apply node-class-description-missing-subtitle (#3182)

*  Fix missing comma

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)

* 👕 Add exception for `node-class-description-missing-subtitle`

* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)

* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)

* Missing coma

* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)

* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)

* 👕 Apply `node-param-description-empty-string` (#3189)

* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)

* Rule looks good

* Add whitespace rule in eslint config

* :zao: fix

* 👕 Apply `node-param-description-identical-to-display-name` (#3193)

* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)

*  Revert ":zao: fix"

This reverts commit ef8a76f3dfedffd1bdccf3178af8a8d90cf5a55c.

* 👕 Apply `node-param-description-missing-for-simplify`  (#3196)

* 👕 Apply `node-param-description-missing-final-period` (#3194)

* Rule working as intended

* Add rule to eslint

* 👕 Apply node-param-description-missing-for-return-all (#3197)

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2022-04-22 18:29:51 +02:00
committed by GitHub
parent aeb5a1234a
commit 0448feec56
408 changed files with 2591 additions and 2026 deletions

View File

@@ -204,7 +204,6 @@ export const activityFields: INodeProperties[] = [
],
},
},
description: 'activity ID',
},
{
displayName: 'RAW Data',
@@ -325,7 +324,6 @@ export const activityFields: INodeProperties[] = [
],
},
},
description: 'activity ID',
},
{
displayName: 'RAW Data',
@@ -393,7 +391,6 @@ export const activityFields: INodeProperties[] = [
name: 'jsonParameters',
type: 'boolean',
default: false,
description: '',
displayOptions: {
show: {
operation: [
@@ -427,7 +424,7 @@ export const activityFields: INodeProperties[] = [
name: 'fields',
type: 'string',
default: '',
description: 'Comma separated list of fields to return.',
description: 'Comma-separated list of fields to return.',
},
{
displayName: 'Sort By',
@@ -451,7 +448,6 @@ export const activityFields: INodeProperties[] = [
},
],
default: 'desc',
description: 'Sort order',
},
],
},

View File

@@ -243,7 +243,6 @@ export const companyFields: INodeProperties[] = [
],
},
},
description: 'company ID',
},
{
displayName: 'RAW Data',
@@ -418,7 +417,6 @@ export const companyFields: INodeProperties[] = [
],
},
},
description: 'company ID',
},
{
displayName: 'RAW Data',
@@ -486,7 +484,6 @@ export const companyFields: INodeProperties[] = [
name: 'jsonParameters',
type: 'boolean',
default: false,
description: '',
displayOptions: {
show: {
operation: [
@@ -520,7 +517,7 @@ export const companyFields: INodeProperties[] = [
name: 'fields',
type: 'string',
default: '',
description: 'Comma separated list of fields to return.',
description: 'Comma-separated list of fields to return.',
},
{
displayName: 'Sort By',
@@ -544,7 +541,6 @@ export const companyFields: INodeProperties[] = [
},
],
default: 'desc',
description: 'Sort order',
},
],
},

View File

@@ -357,7 +357,6 @@ export const dealFields: INodeProperties[] = [
],
},
},
description: 'deal ID',
},
{
displayName: 'RAW Data',
@@ -589,7 +588,6 @@ export const dealFields: INodeProperties[] = [
],
},
},
description: 'deal ID',
},
{
displayName: 'RAW Data',
@@ -657,7 +655,6 @@ export const dealFields: INodeProperties[] = [
name: 'jsonParameters',
type: 'boolean',
default: false,
description: '',
displayOptions: {
show: {
operation: [
@@ -691,7 +688,7 @@ export const dealFields: INodeProperties[] = [
name: 'fields',
type: 'string',
default: '',
description: 'Comma separated list of fields to return.',
description: 'Comma-separated list of fields to return.',
},
{
displayName: 'Sort By',
@@ -715,7 +712,6 @@ export const dealFields: INodeProperties[] = [
},
],
default: 'desc',
description: 'Sort order',
},
],
},

View File

@@ -150,7 +150,7 @@ export class Salesmate implements INodeType {
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
const items = this.getInputData();
const returnData: IDataObject[] = [];
const length = items.length as unknown as number;
const length = items.length;
const qs: IDataObject = {};
let responseData;
const resource = this.getNodeParameter('resource', 0) as string;