refactor: On workflow deletion, cascade delete all entities associated with it (#5102)

2023-01-10 09:23:44 +01:00
parent 7df0728999
commit 0e955760a1
9 changed files with 247 additions and 41 deletions
--- a/packages/cli/src/databases/migrations/mysqldb/1673268682475-DeleteExecutionsWithWorkflows.ts
+++ b/packages/cli/src/databases/migrations/mysqldb/1673268682475-DeleteExecutionsWithWorkflows.ts
@@ -0,0 +1,44 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+import { logMigrationEnd, logMigrationStart } from '@db/utils/migrationHelpers';
+import config from '@/config';
+
+export class DeleteExecutionsWithWorkflows1673268682475 implements MigrationInterface {
+	name = 'DeleteExecutionsWithWorkflows1673268682475';
+	public async up(queryRunner: QueryRunner): Promise<void> {
+		logMigrationStart(this.name);
+		const tablePrefix = config.getEnv('database.tablePrefix');
+
+		await queryRunner.query(`ALTER TABLE \`${tablePrefix}execution_entity\` MODIFY workflowId INT`);
+
+		const workflowIds: Array<{ id: number }> = await queryRunner.query(`
+			SELECT id FROM \`${tablePrefix}execution_entity\`
+		`);
+
+		await queryRunner.query(
+			`DELETE FROM \`${tablePrefix}execution_entity\`
+			 WHERE workflowId IS NOT NULL
+			 ${workflowIds.length ? `AND workflowId NOT IN (${workflowIds.map(({ id }) => id).join()})` : ''}`,
+		);
+
+		await queryRunner.query(
+			`ALTER TABLE \`${tablePrefix}execution_entity\`
+			 ADD CONSTRAINT \`FK_${tablePrefix}execution_entity_workflowId\`
+			 FOREIGN KEY (\`workflowId\`) REFERENCES \`${tablePrefix}workflow_entity\`(\`id\`)
+			 ON DELETE CASCADE`,
+		);
+
+		logMigrationEnd(this.name);
+	}
+
+	public async down(queryRunner: QueryRunner): Promise<void> {
+		const tablePrefix = config.getEnv('database.tablePrefix');
+		await queryRunner.query(
+			`ALTER TABLE \`${tablePrefix}execution_entity\`
+			 DROP FOREIGN KEY \`FK_${tablePrefix}execution_entity_workflowId\``,
+		);
+
+		await queryRunner.query(
+			`ALTER TABLE \`${tablePrefix}execution_entity\` MODIFY workflowId varchar(255);`,
+		);
+	}
+}
--- a/packages/cli/src/databases/migrations/mysqldb/index.ts
+++ b/packages/cli/src/databases/migrations/mysqldb/index.ts
@@ -28,6 +28,7 @@ import { AddWorkflowVersionIdColumn1669739707125 } from './1669739707125-AddWork
 import { AddTriggerCountColumn1669823906994 } from './1669823906994-AddTriggerCountColumn';
 import { RemoveWorkflowDataLoadedFlag1671726148420 } from './1671726148420-RemoveWorkflowDataLoadedFlag';
 import { MessageEventBusDestinations1671535397530 } from './1671535397530-MessageEventBusDestinations';
+import { DeleteExecutionsWithWorkflows1673268682475 } from './1673268682475-DeleteExecutionsWithWorkflows';

 export const mysqlMigrations = [
 	InitialMigration1588157391238,
@@ -60,4 +61,5 @@ export const mysqlMigrations = [
 	AddTriggerCountColumn1669823906994,
 	RemoveWorkflowDataLoadedFlag1671726148420,
 	MessageEventBusDestinations1671535397530,
+	DeleteExecutionsWithWorkflows1673268682475,
 ];
--- a/packages/cli/src/databases/migrations/postgresdb/1673268682475-DeleteExecutionsWithWorkflows.ts
+++ b/packages/cli/src/databases/migrations/postgresdb/1673268682475-DeleteExecutionsWithWorkflows.ts
@@ -0,0 +1,52 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+import { logMigrationEnd, logMigrationStart } from '@db/utils/migrationHelpers';
+import config from '@/config';
+
+export class DeleteExecutionsWithWorkflows1673268682475 implements MigrationInterface {
+	name = 'DeleteExecutionsWithWorkflows1673268682475';
+	public async up(queryRunner: QueryRunner): Promise<void> {
+		logMigrationStart(this.name);
+		const tablePrefix = config.getEnv('database.tablePrefix');
+
+		await queryRunner.query(
+			`ALTER TABLE ${tablePrefix}execution_entity
+			 ALTER COLUMN "workflowId" TYPE INTEGER USING "workflowId"::integer`,
+		);
+
+		const workflowIds: Array<{ id: number }> = await queryRunner.query(`
+			SELECT id FROM ${tablePrefix}workflow_entity
+		`);
+
+		await queryRunner.query(
+			`DELETE FROM ${tablePrefix}execution_entity
+			 WHERE "workflowId" IS NOT NULL
+			 ${
+					workflowIds.length
+						? `AND "workflowId" NOT IN (${workflowIds.map(({ id }) => id).join()})`
+						: ''
+				}`,
+		);
+
+		await queryRunner.query(
+			`ALTER TABLE ${tablePrefix}execution_entity
+			 ADD CONSTRAINT "FK_${tablePrefix}execution_entity_workflowId"
+			 FOREIGN KEY ("workflowId") REFERENCES ${tablePrefix}workflow_entity ("id")
+			 ON DELETE CASCADE`,
+		);
+
+		logMigrationEnd(this.name);
+	}
+
+	public async down(queryRunner: QueryRunner): Promise<void> {
+		const tablePrefix = config.getEnv('database.tablePrefix');
+		await queryRunner.query(
+			`ALTER TABLE ${tablePrefix}execution_entity
+			 DROP CONSTRAINT "FK_${tablePrefix}execution_entity_workflowId"`,
+		);
+
+		await queryRunner.query(
+			`ALTER TABLE ${tablePrefix}execution_entity
+			 ALTER COLUMN "workflowId" TYPE TEXT`,
+		);
+	}
+}
--- a/packages/cli/src/databases/migrations/postgresdb/index.ts
+++ b/packages/cli/src/databases/migrations/postgresdb/index.ts
@@ -26,6 +26,7 @@ import { AddWorkflowVersionIdColumn1669739707126 } from './1669739707126-AddWork
 import { AddTriggerCountColumn1669823906995 } from './1669823906995-AddTriggerCountColumn';
 import { RemoveWorkflowDataLoadedFlag1671726148421 } from './1671726148421-RemoveWorkflowDataLoadedFlag';
 import { MessageEventBusDestinations1671535397530 } from './1671535397530-MessageEventBusDestinations';
+import { DeleteExecutionsWithWorkflows1673268682475 } from './1673268682475-DeleteExecutionsWithWorkflows';

 export const postgresMigrations = [
 	InitialMigration1587669153312,
@@ -56,4 +57,5 @@ export const postgresMigrations = [
 	AddTriggerCountColumn1669823906995,
 	RemoveWorkflowDataLoadedFlag1671726148421,
 	MessageEventBusDestinations1671535397530,
+	DeleteExecutionsWithWorkflows1673268682475,
 ];
--- a/packages/cli/src/databases/migrations/sqlite/1673268682475-DeleteExecutionsWithWorkflows.ts
+++ b/packages/cli/src/databases/migrations/sqlite/1673268682475-DeleteExecutionsWithWorkflows.ts
@@ -0,0 +1,107 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+import { logMigrationEnd, logMigrationStart } from '@db/utils/migrationHelpers';
+import config from '@/config';
+
+export class DeleteExecutionsWithWorkflows1673268682475 implements MigrationInterface {
+	name = 'DeleteExecutionsWithWorkflows1673268682475';
+	public async up(queryRunner: QueryRunner): Promise<void> {
+		logMigrationStart(this.name);
+		const tablePrefix = config.getEnv('database.tablePrefix');
+
+		const workflowIds: Array<{ id: number }> = await queryRunner.query(`
+			SELECT id FROM "${tablePrefix}workflow_entity"
+		`);
+
+		await queryRunner.query(
+			`DELETE FROM "${tablePrefix}execution_entity"
+			 WHERE "workflowId" IS NOT NULL
+			 ${
+					workflowIds.length
+						? `AND "workflowId" NOT IN (${workflowIds.map(({ id }) => id).join()})`
+						: ''
+				}`,
+		);
+
+		await queryRunner.query('PRAGMA foreign_keys=OFF');
+
+		await queryRunner.query(`DROP TABLE IF EXISTS "${tablePrefix}temporary_execution_entity"`);
+		await queryRunner.query(
+			`CREATE TABLE "${tablePrefix}temporary_execution_entity" (
+				"id" integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+				"workflowId" int,
+				"finished" boolean NOT NULL,
+				"mode" varchar NOT NULL,
+				"retryOf" varchar,
+				"retrySuccessId" varchar,
+				"startedAt" datetime NOT NULL,
+				"stoppedAt" datetime,
+				"waitTill" datetime,
+				"workflowData" text NOT NULL,
+				"data" text NOT NULL,
+				FOREIGN KEY("workflowId") REFERENCES "${tablePrefix}workflow_entity" ("id") ON DELETE CASCADE
+			)`,
+		);
+
+		const columns =
+			'"id", "workflowId", "finished", "mode", "retryOf", "retrySuccessId", "startedAt", "stoppedAt", "waitTill", "workflowData", "data"';
+		await queryRunner.query(
+			`INSERT INTO "${tablePrefix}temporary_execution_entity"(${columns}) SELECT ${columns} FROM "${tablePrefix}execution_entity"`,
+		);
+		await queryRunner.query(`DROP TABLE "${tablePrefix}execution_entity"`);
+		await queryRunner.query(
+			`ALTER TABLE "${tablePrefix}temporary_execution_entity" RENAME TO "${tablePrefix}execution_entity"`,
+		);
+		await queryRunner.query(
+			`CREATE INDEX "IDX_${tablePrefix}cefb067df2402f6aed0638a6c1" ON "${tablePrefix}execution_entity" ("stoppedAt")`,
+		);
+		await queryRunner.query(
+			`CREATE INDEX "IDX_${tablePrefix}ca4a71b47f28ac6ea88293a8e2" ON "${tablePrefix}execution_entity" ("waitTill")`,
+		);
+		await queryRunner.query(`VACUUM;`);
+
+		await queryRunner.query('PRAGMA foreign_keys=ON');
+
+		logMigrationEnd(this.name);
+	}
+
+	public async down(queryRunner: QueryRunner): Promise<void> {
+		const tablePrefix = config.getEnv('database.tablePrefix');
+		await queryRunner.query('PRAGMA foreign_keys=OFF');
+
+		await queryRunner.query(`DROP TABLE IF EXISTS "${tablePrefix}temporary_execution_entity"`);
+		await queryRunner.query(
+			`CREATE TABLE "${tablePrefix}temporary_execution_entity" (
+				"id" integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+				"workflowId" varchar,
+				"finished" boolean NOT NULL,
+				"mode" varchar NOT NULL,
+				"retryOf" varchar,
+				"retrySuccessId" varchar,
+				"startedAt" datetime NOT NULL,
+				"stoppedAt" datetime,
+				"waitTill" datetime,
+				"workflowData" text NOT NULL,
+				"data" text NOT NULL
+			)`,
+		);
+
+		const columns =
+			'"id", "workflowId", "finished", "mode", "retryOf", "retrySuccessId", "startedAt", "stoppedAt", "waitTill", "workflowData", "data"';
+		await queryRunner.query(
+			`INSERT INTO "${tablePrefix}temporary_execution_entity"(${columns}) SELECT ${columns} FROM "${tablePrefix}execution_entity"`,
+		);
+		await queryRunner.query(`DROP TABLE "${tablePrefix}execution_entity"`);
+		await queryRunner.query(
+			`ALTER TABLE "${tablePrefix}temporary_execution_entity" RENAME TO "${tablePrefix}execution_entity"`,
+		);
+		await queryRunner.query(
+			`CREATE INDEX "IDX_${tablePrefix}cefb067df2402f6aed0638a6c1" ON "${tablePrefix}execution_entity" ("stoppedAt")`,
+		);
+		await queryRunner.query(
+			`CREATE INDEX "IDX_${tablePrefix}ca4a71b47f28ac6ea88293a8e2" ON "${tablePrefix}execution_entity" ("waitTill")`,
+		);
+		await queryRunner.query(`VACUUM;`);
+
+		await queryRunner.query('PRAGMA foreign_keys=ON');
+	}
+}
--- a/packages/cli/src/databases/migrations/sqlite/index.ts
+++ b/packages/cli/src/databases/migrations/sqlite/index.ts
@@ -25,6 +25,7 @@ import { AddWorkflowVersionIdColumn1669739707124 } from './1669739707124-AddWork
 import { AddTriggerCountColumn1669823906993 } from './1669823906993-AddTriggerCountColumn';
 import { RemoveWorkflowDataLoadedFlag1671726148419 } from './1671726148419-RemoveWorkflowDataLoadedFlag';
 import { MessageEventBusDestinations1671535397530 } from './1671535397530-MessageEventBusDestinations';
+import { DeleteExecutionsWithWorkflows1673268682475 } from './1673268682475-DeleteExecutionsWithWorkflows';

 const sqliteMigrations = [
 	InitialMigration1588102412422,
@@ -54,6 +55,7 @@ const sqliteMigrations = [
 	WorkflowStatistics1664196174000,
 	RemoveWorkflowDataLoadedFlag1671726148419,
 	MessageEventBusDestinations1671535397530,
+	DeleteExecutionsWithWorkflows1673268682475,
 ];

 export { sqliteMigrations };