mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Add IRequestOptions type to helpers.request for more type safety (no-changelog) (#8563)

Browse Source 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Elias Meire
2024-02-14 16:29:09 +01:00
committed by GitHub
parent 24859cfef5
commit 100d9bc087
330 changed files with 1682 additions and 1492 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/nodes-base/nodes/Keap/GenericFunctions.ts
View File

@@ -1,10 +1,10 @@
import type { OptionsWithUri } from 'request';
import type {
IDataObject,
IExecuteFunctions,
IHookFunctions,
IHttpRequestMethods,
ILoadOptionsFunctions,
IRequestOptions,
IWebhookFunctions,
JsonObject,
} from 'n8n-workflow';
@@ -14,7 +14,7 @@ import { snakeCase } from 'change-case';
export async function keapApiRequest(
this: IWebhookFunctions | IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
method: string,
method: IHttpRequestMethods,
resource: string,
body: any = {},
@@ -23,7 +23,7 @@ export async function keapApiRequest(
headers: IDataObject = {},
option: IDataObject = {},
): Promise<any> {
let options: OptionsWithUri = {
let options: IRequestOptions = {
headers: {
'Content-Type': 'application/json',
},
@@ -51,7 +51,7 @@ export async function keapApiRequest(
export async function keapApiRequestAllItems(
this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
propertyName: string,
method: string,
method: IHttpRequestMethods,
endpoint: string,
body: any = {},

4
packages/nodes-base/nodes/Keap/Keap.node.ts
View File

@@ -604,7 +604,7 @@ export class Keap implements INodeType {
//https://developer.infusionsoft.com/docs/rest/#!/E-Commerce/getOrderUsingGET
if (operation === 'get') {
const orderId = parseInt(this.getNodeParameter('orderId', i) as string, 10);
responseData = await keapApiRequest.call(this, 'get', `/orders/${orderId}`);
responseData = await keapApiRequest.call(this, 'GET', `/orders/${orderId}`);
}
//https://developer.infusionsoft.com/docs/rest/#!/E-Commerce/listOrdersUsingGET
if (operation === 'getAll') {
@@ -649,7 +649,7 @@ export class Keap implements INodeType {
//https://developer.infusionsoft.com/docs/rest/#!/Product/retrieveProductUsingGET
if (operation === 'get') {
const productId = this.getNodeParameter('productId', i) as string;
responseData = await keapApiRequest.call(this, 'get', `/products/${productId}`);
responseData = await keapApiRequest.call(this, 'GET', `/products/${productId}`);
}
//https://developer.infusionsoft.com/docs/rest/#!/Product/listProductsUsingGET
if (operation === 'getAll') {