mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Redirect users without feature flag from template cred setup (no-changelog) (#8302)

Browse Source
This commit is contained in:
Tomi Turtiainen
2024-01-12 12:10:39 +02:00
committed by GitHub
parent c2748802a2
commit 135553bd6b
10 changed files with 63 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/editor-ui/src/stores/posthog.store.ts
View File

@@ -35,7 +35,7 @@ export const usePostHog = defineStore('posthog', () => {
};
const getVariant = (experiment: keyof FeatureFlags): FeatureFlags[keyof FeatureFlags] => {
return featureFlags.value?.[experiment];
return overrides.value[experiment] ?? featureFlags.value?.[experiment];
};
const isVariantEnabled = (experiment: string, variant: string) => {
@@ -46,7 +46,7 @@ export const usePostHog = defineStore('posthog', () => {
* Checks if the given feature flag is enabled. Should only be used for boolean flags
*/
const isFeatureEnabled = (experiment: keyof FeatureFlags) => {
return featureFlags.value?.[experiment] === true;
return getVariant(experiment) === true;
};
if (!window.featureFlags) {
@@ -55,7 +55,10 @@ export const usePostHog = defineStore('posthog', () => {
if (cachedOverrides) {
try {
console.log('Overriding feature flags', cachedOverrides);
overrides.value = JSON.parse(cachedOverrides);
const parsedOverrides = JSON.parse(cachedOverrides);
if (typeof parsedOverrides === 'object') {
overrides.value = JSON.parse(cachedOverrides);
}
} catch (e) {
console.log('Could not override experiment', e);
}
@@ -65,10 +68,6 @@ export const usePostHog = defineStore('posthog', () => {
// since features are evaluated serverside, regular posthog mechanism to override clientside does not work
override: (name: string, value: string | boolean) => {
overrides.value[name] = value;
featureFlags.value = {
...featureFlags.value,
[name]: value,
};
try {
useStorage(LOCAL_STORAGE_EXPERIMENT_OVERRIDES).value = JSON.stringify(overrides.value);
} catch (e) {}
@@ -93,13 +92,6 @@ export const usePostHog = defineStore('posthog', () => {
window.posthog?.identify?.(id, traits);
};
const addExperimentOverrides = () => {
featureFlags.value = {
...featureFlags.value,
...overrides.value,
};
};
const trackExperiment = (featFlags: FeatureFlags, name: string) => {
const variant = featFlags[name];
if (!variant || trackedDemoExp.value[name] === variant) {
@@ -160,13 +152,11 @@ export const usePostHog = defineStore('posthog', () => {
};
// does not need to be debounced really, but tracking does not fire without delay on page load
addExperimentOverrides();
trackExperimentsDebounced(featureFlags.value);
} else {
// depend on client side evaluation if serverside evaluation fails
window.posthog?.onFeatureFlags?.((keys: string[], map: FeatureFlags) => {
featureFlags.value = map;
addExperimentOverrides();
// must be debounced because it is called multiple times by posthog
trackExperimentsDebounced(featureFlags.value);