From 1bdeb6684a68f985a71ddeb11eea75dce19dde78 Mon Sep 17 00:00:00 2001
From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Date: Mon, 13 Mar 2023 13:10:11 +0100
Subject: [PATCH] ci: Add e2e checklist (#5678)

* chore: Add e2e checklist

* chore: add eol dots
---
 CHECKLIST.yml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/CHECKLIST.yml b/CHECKLIST.yml
index 77d30837d..7da0dcb08 100644
--- a/CHECKLIST.yml
+++ b/CHECKLIST.yml
@@ -37,4 +37,12 @@ paths:
   # design-system
   "packages/design-system/**/*.vue":
     - Used design system tokens (colors, spacings...) where possible.
-    - Updated Storybook with new component or updated functionality.
\ No newline at end of file
+    - Updated Storybook with new component or updated functionality.
+
+  # e2e
+  "cypress/e2e/**":
+    - Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
+    - Spoofed endpoints that are not critical for the test (to avoid flakiness).
+    - Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
+    - Avoided adding waits on time (use request intercepts instead).
+    - Ensured each spec does not depend on any another spec to pass.
\ No newline at end of file