From 1cb1de8c87a355872f12f2111bba749efeda8d09 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?=
 <netroy@users.noreply.github.com>
Date: Tue, 19 Mar 2024 11:04:22 +0100
Subject: [PATCH] fix(editor): Fix a link routing regression in N8nRoute, and
 add tests (no-changelog) (#8911)

---
 .../src/components/N8nRoute/Route.vue         | 13 ++------
 .../N8nRoute/__tests__/Route.spec.ts          | 32 +++++++++++++++++++
 .../__snapshots__/Route.spec.ts.snap          |  7 ++++
 3 files changed, 41 insertions(+), 11 deletions(-)
 create mode 100644 packages/design-system/src/components/N8nRoute/__tests__/Route.spec.ts
 create mode 100644 packages/design-system/src/components/N8nRoute/__tests__/__snapshots__/Route.spec.ts.snap

diff --git a/packages/design-system/src/components/N8nRoute/Route.vue b/packages/design-system/src/components/N8nRoute/Route.vue
index 89f9f924b..397cff994 100644
--- a/packages/design-system/src/components/N8nRoute/Route.vue
+++ b/packages/design-system/src/components/N8nRoute/Route.vue
@@ -17,7 +17,7 @@ interface RouteProps {
 }
 
 defineOptions({ name: 'N8nRoute' });
-const props = withDefaults(defineProps<RouteProps>(), {});
+const props = defineProps<RouteProps>();
 
 const useRouterLink = computed(() => {
 	if (props.newWindow) {
@@ -32,14 +32,5 @@ const useRouterLink = computed(() => {
 	return props.to !== undefined;
 });
 
-const openNewWindow = computed(() => {
-	if (props.newWindow !== undefined) {
-		return props.newWindow;
-	}
-
-	if (typeof props.to === 'string') {
-		return !props.to.startsWith('/');
-	}
-	return true;
-});
+const openNewWindow = computed(() => !useRouterLink.value);
 </script>
diff --git a/packages/design-system/src/components/N8nRoute/__tests__/Route.spec.ts b/packages/design-system/src/components/N8nRoute/__tests__/Route.spec.ts
new file mode 100644
index 000000000..fb5c16b1e
--- /dev/null
+++ b/packages/design-system/src/components/N8nRoute/__tests__/Route.spec.ts
@@ -0,0 +1,32 @@
+import { render } from '@testing-library/vue';
+import N8nRoute from '../Route.vue';
+
+describe('N8nRoute', () => {
+	it('should render internal router links', () => {
+		const wrapper = render(N8nRoute, {
+			props: {
+				to: '/test',
+			},
+		});
+		expect(wrapper.html()).toMatchSnapshot();
+	});
+
+	it('should render internal links with newWindow=true', () => {
+		const wrapper = render(N8nRoute, {
+			props: {
+				to: '/test',
+				newWindow: true,
+			},
+		});
+		expect(wrapper.html()).toMatchSnapshot();
+	});
+
+	it('should render external links', () => {
+		const wrapper = render(N8nRoute, {
+			props: {
+				to: 'https://example.com/',
+			},
+		});
+		expect(wrapper.html()).toMatchSnapshot();
+	});
+});
diff --git a/packages/design-system/src/components/N8nRoute/__tests__/__snapshots__/Route.spec.ts.snap b/packages/design-system/src/components/N8nRoute/__tests__/__snapshots__/Route.spec.ts.snap
new file mode 100644
index 000000000..c9e658ff2
--- /dev/null
+++ b/packages/design-system/src/components/N8nRoute/__tests__/__snapshots__/Route.spec.ts.snap
@@ -0,0 +1,7 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`N8nRoute > should render external links 1`] = `"<a href="https://example.com/" target="_blank"></a>"`;
+
+exports[`N8nRoute > should render internal links with newWindow=true 1`] = `"<a href="/test" target="_blank"></a>"`;
+
+exports[`N8nRoute > should render internal router links 1`] = `"<router-link to="/test"></router-link>"`;