From 1cce8eaf16a4394b4241572641427011287a7dc2 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Mon, 12 Dec 2022 14:46:10 +0200
Subject: [PATCH] fix(editor): Fix credential sharing issues handler when no
 matching id or name (#4879)

* fix: fix credential sharing issues handler when no matching id or name

* feat: Show erroring credential name as placeholder when available

* feat: Add (unavailable) descriptor for unavailable credentials
---
 .../src/components/NodeCredentials.vue          | 17 +++++++++++++++--
 packages/editor-ui/src/mixins/nodeHelpers.ts    |  3 ++-
 .../editor-ui/src/plugins/i18n/locales/en.json  |  1 +
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeCredentials.vue b/packages/editor-ui/src/components/NodeCredentials.vue
index 5b00478fc..abc495bc2 100644
--- a/packages/editor-ui/src/components/NodeCredentials.vue
+++ b/packages/editor-ui/src/components/NodeCredentials.vue
@@ -17,7 +17,7 @@
 			>
 				<div v-if="readonly || isReadOnly">
 					<n8n-input
-						:value="selected && selected[credentialTypeDescription.name] && selected[credentialTypeDescription.name].name"
+						:value="getSelectedName(credentialTypeDescription.name)"
 						disabled
 						size="small"
 					/>
@@ -26,7 +26,12 @@
 					v-else
 					:class="issues.length ? $style.hasIssues : $style.input"
 				>
-					<n8n-select :value="getSelectedId(credentialTypeDescription.name)" @change="(value) => onCredentialSelected(credentialTypeDescription.name, value)" :placeholder="$locale.baseText('nodeCredentials.selectCredential')" size="small">
+					<n8n-select
+						:value="getSelectedId(credentialTypeDescription.name)"
+						@change="(value) => onCredentialSelected(credentialTypeDescription.name, value)"
+						:placeholder="getSelectPlaceholder(credentialTypeDescription.name, issues)"
+						size="small"
+					>
 						<n8n-option
 							v-for="(item) in getCredentialOptions(credentialTypeDescription.name)"
 							:key="item.id"
@@ -180,6 +185,14 @@ export default mixins(
 			}
 			return undefined;
 		},
+		getSelectedName(type: string) {
+			return this.selected?.[type]?.name;
+		},
+		getSelectPlaceholder(type: string, issues: string[]) {
+			return issues.length && this.getSelectedName(type)
+				? this.$locale.baseText('nodeCredentials.selectedCredentialUnavailable', { interpolate: { name: this.getSelectedName(type) } })
+				: this.$locale.baseText('nodeCredentials.selectCredential');
+		},
 		credentialInputWrapperStyle (credentialType: string) {
 			let deductWidth = 0;
 			const styles = {
diff --git a/packages/editor-ui/src/mixins/nodeHelpers.ts b/packages/editor-ui/src/mixins/nodeHelpers.ts
index 229db6953..be4df23c0 100644
--- a/packages/editor-ui/src/mixins/nodeHelpers.ts
+++ b/packages/editor-ui/src/mixins/nodeHelpers.ts
@@ -343,7 +343,8 @@ export const nodeHelpers = mixins(
 						}
 
 						if (nameMatches.length === 0) {
-							if (!this.settingsStore.isEnterpriseFeatureEnabled(EnterpriseEditionFeature.WorkflowSharing)) {
+							const isCredentialUsedInWorkflow = this.workflowsStore.usedCredentials?.[selectedCredentials.id as string];
+							if (!isCredentialUsedInWorkflow) {
 								foundIssues[credentialTypeDescription.name] = [this.$locale.baseText('nodeIssues.credentials.doNotExist', { interpolate: { name: selectedCredentials.name, type: credentialDisplayName } }), this.$locale.baseText('nodeIssues.credentials.doNotExist.hint')];
 							}
 						}
diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
index 2365026dd..2a5a5a918 100644
--- a/packages/editor-ui/src/plugins/i18n/locales/en.json
+++ b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -724,6 +724,7 @@
 	"nodeCredentials.credentialFor": "Credential for {credentialType}",
 	"nodeCredentials.issues": "Issues",
 	"nodeCredentials.selectCredential": "Select Credential",
+	"nodeCredentials.selectedCredentialUnavailable": "{name} (unavailable)",
 	"nodeCredentials.showMessage.message": "Nodes that used credential \"{oldCredentialName}\" have been updated to use \"{newCredentialName}\"",
 	"nodeCredentials.showMessage.title": "Node credential updated",
 	"nodeCredentials.updateCredential": "Update Credential",