mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(editor): Make inputs in the filter component regular inputs by default (#8980)

Browse Source
This commit is contained in:
Elias Meire
2024-03-27 09:52:58 +01:00
committed by GitHub
parent ddc0f57116
commit 295b650fb8
3 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/editor-ui/src/components/FilterConditions/FilterConditions.vue
View File

@@ -43,7 +43,7 @@ const ndvStore = useNDVStore();
const { debounce } = useDebounce();
function createCondition(): FilterConditionValue {
return { id: uuid(), leftValue: '=', rightValue: '=', operator: DEFAULT_OPERATOR_VALUE };
return { id: uuid(), leftValue: '', rightValue: '', operator: DEFAULT_OPERATOR_VALUE };
}
const allowedCombinators = computed<FilterTypeCombinator[]>(

7
packages/editor-ui/src/components/FilterConditions/__tests__/FilterConditions.test.ts
View File

@@ -43,14 +43,7 @@ describe('FilterConditions.vue', () => {
expect(getByTestId('filter-conditions')).toBeInTheDocument();
expect(await findAllByTestId('filter-condition')).toHaveLength(1);
expect(getByTestId('filter-condition-left')).toBeInTheDocument();
expect(
within(getByTestId('filter-condition-left')).getByTestId('inline-expression-editor-input'),
).toBeInTheDocument();
expect(getByTestId('filter-operator-select')).toBeInTheDocument();
expect(getByTestId('filter-condition-right')).toBeInTheDocument();
expect(
within(getByTestId('filter-condition-right')).getByTestId('inline-expression-editor-input'),
).toBeInTheDocument();
// Only visible when multiple conditions
expect(queryByTestId('filter-combinator-select')).not.toBeInTheDocument();