mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Add item information to more node errors (#3681)

Browse Source 
* ⚡ Add `itemIndex` to node-thrown errors

* ⚡ Add some missing item indexes
This commit is contained in:
Iván Ovejero
2022-07-12 17:51:01 +02:00
committed by GitHub
parent a847190f33
commit 2a8043cd27
117 changed files with 376 additions and 370 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/nodes-base/nodes/Google/Calendar/GoogleCalendar.node.ts
View File

@@ -330,7 +330,7 @@ export class GoogleCalendar implements INodeType {
additionalFields.repeatUntil
) {
throw new NodeOperationError(this.getNode(),
`You can set either 'Repeat How Many Times' or 'Repeat Until' but not both`,
`You can set either 'Repeat How Many Times' or 'Repeat Until' but not both`, { itemIndex: i }
);
}
if (additionalFields.repeatFrecuency) {
@@ -577,7 +577,7 @@ export class GoogleCalendar implements INodeType {
} else {
if (updateFields.repeatHowManyTimes && updateFields.repeatUntil) {
throw new NodeOperationError(this.getNode(),
`You can set either 'Repeat How Many Times' or 'Repeat Until' but not both`,
`You can set either 'Repeat How Many Times' or 'Repeat Until' but not both`, { itemIndex: i }
);
}
if (updateFields.repeatFrecuency) {

10
packages/nodes-base/nodes/Google/Chat/GoogleChat.node.ts
View File

@@ -401,7 +401,7 @@ export class GoogleChat implements INodeType {
if (validateJSON(messageJson as string) !== undefined) {
message = JSON.parse(messageJson as string) as IMessage;
} else {
throw new NodeOperationError(this.getNode(), 'Message (JSON) must be a valid json');
throw new NodeOperationError(this.getNode(), 'Message (JSON) must be a valid json', { itemIndex: i });
}
}
@@ -410,7 +410,7 @@ export class GoogleChat implements INodeType {
if (messageUi.text && messageUi.text !== '') {
message.text = messageUi.text;
} else {
throw new NodeOperationError(this.getNode(), 'Message Text must be provided.');
throw new NodeOperationError(this.getNode(), 'Message Text must be provided.', { itemIndex: i });
}
// // TODO: get cards from the UI
// if (messageUi?.cards?.metadataValues && messageUi?.cards?.metadataValues.length !== 0) {
@@ -485,7 +485,7 @@ export class GoogleChat implements INodeType {
if (validateJSON(updateFieldsJson as string) !== undefined) {
message = JSON.parse(updateFieldsJson as string) as IMessage;
} else {
throw new NodeOperationError(this.getNode(), 'Update Fields (JSON) must be a valid json');
throw new NodeOperationError(this.getNode(), 'Update Fields (JSON) must be a valid json', { itemIndex: i });
}
}
@@ -570,7 +570,7 @@ export class GoogleChat implements INodeType {
if (validateJSON(messageJson as string) !== undefined) {
message = JSON.parse(messageJson as string) as IMessage;
} else {
throw new NodeOperationError(this.getNode(), 'Message (JSON) must be a valid json');
throw new NodeOperationError(this.getNode(), 'Message (JSON) must be a valid json', { itemIndex: i });
}
}
@@ -579,7 +579,7 @@ export class GoogleChat implements INodeType {
if (messageUi.text && messageUi.text !== '') {
message.text = messageUi.text;
} else {
throw new NodeOperationError(this.getNode(), 'Message Text must be provided.');
throw new NodeOperationError(this.getNode(), 'Message Text must be provided.', { itemIndex: i });
}
}

4
packages/nodes-base/nodes/Google/Drive/GoogleDrive.node.ts
View File

@@ -2403,13 +2403,13 @@ export class GoogleDrive implements INodeType {
const item = items[i];
if (item.binary === undefined) {
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!');
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!', { itemIndex: i });
}
const propertyNameUpload = this.getNodeParameter('binaryPropertyName', i) as string;
if (item.binary[propertyNameUpload] === undefined) {
throw new NodeOperationError(this.getNode(), `No binary data property "${propertyNameUpload}" does not exists on item!`);
throw new NodeOperationError(this.getNode(), `No binary data property "${propertyNameUpload}" does not exists on item!`, { itemIndex: i });
}
if (item.binary[propertyNameUpload].mimeType) {

4
packages/nodes-base/nodes/Google/GSuiteAdmin/GSuiteAdmin.node.ts
View File

@@ -329,7 +329,7 @@ export class GSuiteAdmin implements INodeType {
}
if (qs.projection === 'custom' && qs.customFieldMask === undefined) {
throw new NodeOperationError(this.getNode(), 'When projection is set to custom, the custom schemas field must be defined');
throw new NodeOperationError(this.getNode(), 'When projection is set to custom, the custom schemas field must be defined', { itemIndex: i });
}
responseData = await googleApiRequest.call(
@@ -362,7 +362,7 @@ export class GSuiteAdmin implements INodeType {
}
if (qs.projection === 'custom' && qs.customFieldMask === undefined) {
throw new NodeOperationError(this.getNode(), 'When projection is set to custom, the custom schemas field must be defined');
throw new NodeOperationError(this.getNode(), 'When projection is set to custom, the custom schemas field must be defined', { itemIndex: i });
}
if (returnAll) {

2
packages/nodes-base/nodes/Google/Perspective/GooglePerspective.node.ts
View File

@@ -241,7 +241,7 @@ export class GooglePerspective implements INodeType {
if (!attributes.length) {
throw new NodeOperationError(
this.getNode(),
'Please enter at least one attribute to analyze.',
'Please enter at least one attribute to analyze.', { itemIndex: i }
);
}

10
packages/nodes-base/nodes/Google/YouTube/YouTube.node.ts
View File

@@ -413,11 +413,11 @@ export class YouTube implements INodeType {
const item = items[i];
if (item.binary === undefined) {
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!');
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!', { itemIndex: i });
}
if (item.binary[binaryProperty] === undefined) {
throw new NodeOperationError(this.getNode(), `No binary data property "${binaryProperty}" does not exists on item!`);
throw new NodeOperationError(this.getNode(), `No binary data property "${binaryProperty}" does not exists on item!`, { itemIndex: i });
}
if (item.binary[binaryProperty].mimeType) {
@@ -826,7 +826,7 @@ export class YouTube implements INodeType {
}
if (qs.relatedToVideoId && qs.forDeveloper !== undefined) {
throw new NodeOperationError(this.getNode(), `When using the parameter 'related to video' the parameter 'for developer' cannot be set`);
throw new NodeOperationError(this.getNode(), `When using the parameter 'related to video' the parameter 'for developer' cannot be set`, { itemIndex: i });
}
if (returnAll) {
@@ -900,11 +900,11 @@ export class YouTube implements INodeType {
const item = items[i];
if (item.binary === undefined) {
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!');
throw new NodeOperationError(this.getNode(), 'No binary data exists on item!', { itemIndex: i });
}
if (item.binary[binaryProperty] === undefined) {
throw new NodeOperationError(this.getNode(), `No binary data property "${binaryProperty}" does not exists on item!`);
throw new NodeOperationError(this.getNode(), `No binary data property "${binaryProperty}" does not exists on item!`, { itemIndex: i });
}
if (item.binary[binaryProperty].mimeType) {