From 320e646380395af00b8b73445af045f9b6315dc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 9 Jan 2023 11:44:52 +0100 Subject: [PATCH] fix(editor): Omit `pairedItem` from proxy completions (#5098) * :zap: Omit `pairedItem` from proxy completions * :test_tube: Fix tests --- .../plugins/codemirror/completions/__tests__/proxyMocks.ts | 5 ++--- .../src/plugins/codemirror/completions/proxy.completions.ts | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/editor-ui/src/plugins/codemirror/completions/__tests__/proxyMocks.ts b/packages/editor-ui/src/plugins/codemirror/completions/__tests__/proxyMocks.ts index af44ce4ba..8748203a8 100644 --- a/packages/editor-ui/src/plugins/codemirror/completions/__tests__/proxyMocks.ts +++ b/packages/editor-ui/src/plugins/codemirror/completions/__tests__/proxyMocks.ts @@ -21,7 +21,7 @@ export const nodeSelectorProxy = new Proxy( {}, { ownKeys() { - return ['all', 'context', 'first', 'item', 'last', 'params', 'pairedItem', 'itemMatching']; + return ['all', 'context', 'first', 'item', 'last', 'params', 'itemMatching']; }, get(_, property) { if (property === 'all') return []; @@ -30,7 +30,6 @@ export const nodeSelectorProxy = new Proxy( if (property === 'item') return {}; if (property === 'last') return {}; if (property === 'params') return {}; - if (property === 'pairedItem') return {}; if (property === 'itemMatching') return {}; return undefined; @@ -39,7 +38,7 @@ export const nodeSelectorProxy = new Proxy( ); export const itemProxy = new Proxy( - { json: {}, pairedItem: {} }, + { json: {} }, { get(_, property) { if (property === 'json') return {}; diff --git a/packages/editor-ui/src/plugins/codemirror/completions/proxy.completions.ts b/packages/editor-ui/src/plugins/codemirror/completions/proxy.completions.ts index e5e9050c5..c59befc0f 100644 --- a/packages/editor-ui/src/plugins/codemirror/completions/proxy.completions.ts +++ b/packages/editor-ui/src/plugins/codemirror/completions/proxy.completions.ts @@ -56,7 +56,7 @@ export function proxyCompletions(context: CompletionContext): CompletionResult | } function generateOptions(toResolve: string, proxy: IDataObject, word: Word): Completion[] { - const SKIP_SET = new Set(['__ob__']); + const SKIP_SET = new Set(['__ob__', 'pairedItem']); if (word.text.includes('json[')) { return Object.keys(proxy.json as object)