fix: Enable crash journal only in production mode (no-changelog) (#4948)

* consolidate various `NODE_ENV` checks in the `cli` package

* enable crash journal only in production

packages/cli/src/databases/utils/migrationHelpers.ts

@@ -4,6 +4,7 @@ import { UserSettings } from 'n8n-core';
 import type { QueryRunner } from 'typeorm/query-runner/QueryRunner';
 import config from '@/config';
 import { getLogger } from '@/Logger';
+import { inTest } from '@/constants';
 
 const PERSONALIZATION_SURVEY_FILENAME = 'personalizationSurvey.json';
 
@@ -37,10 +38,7 @@ export function loadSurveyFromDisk(): string | null {
 
 let logFinishTimeout: NodeJS.Timeout;
 
-export function logMigrationStart(
-	migrationName: string,
-	disableLogging = process.env.NODE_ENV === 'test',
-): void {
+export function logMigrationStart(migrationName: string, disableLogging = inTest): void {
 	if (disableLogging) return;
 
 	if (!logFinishTimeout) {
@@ -52,10 +50,7 @@ export function logMigrationStart(
 	clearTimeout(logFinishTimeout);
 }
 
-export function logMigrationEnd(
-	migrationName: string,
-	disableLogging = process.env.NODE_ENV === 'test',
-): void {
+export function logMigrationEnd(migrationName: string, disableLogging = inTest): void {
 	if (disableLogging) return;
 
 	getLogger().debug(`Finished migration ${migrationName}`);