From 3bc06ee5c07fa474e4ce825e699f8095f9e11f10 Mon Sep 17 00:00:00 2001
From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Date: Fri, 4 Mar 2022 19:39:52 +0300
Subject: [PATCH] :bug: Fix credentials list load issue (#2931)

* always fetch credentials

* only fetch credentials once
---
 packages/editor-ui/src/Interface.ts           | 1 +
 packages/editor-ui/src/modules/credentials.ts | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
index d6b33d009..f65103cf3 100644
--- a/packages/editor-ui/src/Interface.ts
+++ b/packages/editor-ui/src/Interface.ts
@@ -764,6 +764,7 @@ export interface ICredentialMap {
 export interface ICredentialsState {
 	credentialTypes: ICredentialTypeMap;
 	credentials: ICredentialMap;
+	fetchedAllCredentials: boolean;
 }
 
 export interface ITagsState {
diff --git a/packages/editor-ui/src/modules/credentials.ts b/packages/editor-ui/src/modules/credentials.ts
index c890e8a61..1fb014370 100644
--- a/packages/editor-ui/src/modules/credentials.ts
+++ b/packages/editor-ui/src/modules/credentials.ts
@@ -35,6 +35,7 @@ const module: Module<ICredentialsState, IRootState> = {
 	state: {
 		credentialTypes: {},
 		credentials: {},
+		fetchedAllCredentials: false,
 	},
 	mutations: {
 		setCredentialTypes: (state: ICredentialsState, credentialTypes: ICredentialType[]) => {
@@ -52,6 +53,7 @@ const module: Module<ICredentialsState, IRootState> = {
 
 				return accu;
 			}, {});
+			state.fetchedAllCredentials = true;
 		},
 		upsertCredential(state: ICredentialsState, credential: ICredentialsResponse) {
 			if (credential.id) {
@@ -130,7 +132,7 @@ const module: Module<ICredentialsState, IRootState> = {
 			context.commit('setCredentialTypes', credentialTypes);
 		},
 		fetchAllCredentials: async (context: ActionContext<ICredentialsState, IRootState>) => {
-			if (context.getters.allCredentials.length > 0) {
+			if (context.state.fetchedAllCredentials) {
 				return;
 			}
 			const credentials = await getAllCredentials(context.rootGetters.getRestApiContext);