From 3cb693d5d4b8aaf800df70e62c1b2ca2ff208c4d Mon Sep 17 00:00:00 2001 From: Ahsan Virani Date: Thu, 23 Jun 2022 16:05:20 +0200 Subject: [PATCH] fix(core): Fix logger error when logging circular json (#3583) * Fix logger error when logging circular json * add type --- packages/cli/src/Logger.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/Logger.ts b/packages/cli/src/Logger.ts index c5a9cb165..7a5379d3f 100644 --- a/packages/cli/src/Logger.ts +++ b/packages/cli/src/Logger.ts @@ -1,5 +1,6 @@ /* eslint-disable @typescript-eslint/no-shadow */ /* eslint-disable @typescript-eslint/no-unsafe-assignment */ +import { inspect } from 'util'; import winston from 'winston'; import { IDataObject, ILogger, LogTypes } from 'n8n-workflow'; @@ -36,12 +37,12 @@ class Logger implements ILogger { winston.format.printf(({ level, message, timestamp, metadata }) => { // eslint-disable-next-line @typescript-eslint/restrict-template-expressions return `${timestamp} | ${level.padEnd(18)} | ${message}${ - Object.keys(metadata).length ? ` ${JSON.stringify(metadata)}` : '' + Object.keys(metadata).length ? ` ${JSON.stringify(inspect(metadata))}` : '' }`; }), ); } else { - format = winston.format.printf(({ message }) => message); + format = winston.format.printf(({ message }: { message: string }) => message); } this.logger.add(