ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076)

## Summary
We accidentally made some functions `async` in
https://github.com/n8n-io/n8n/pull/7846
This PR reverts that change. 

## Review / Merge checklist
- [x] PR title and summary are descriptive.

packages/cli/src/credentials/credentials.controller.ee.ts

@@ -50,7 +50,7 @@ EECredentialsController.get(
 
 		const userSharing = credential.shared?.find((shared) => shared.user.id === req.user.id);
 
-		if (!userSharing && !(await req.user.hasGlobalScope('credential:read'))) {
+		if (!userSharing && !req.user.hasGlobalScope('credential:read')) {
 			throw new UnauthorizedError('Forbidden.');
 		}
 
@@ -130,7 +130,7 @@ EECredentialsController.put(
 		if (!ownsCredential || !credential) {
 			credential = undefined;
 			// Allow owners/admins to share
-			if (await req.user.hasGlobalScope('credential:share')) {
+			if (req.user.hasGlobalScope('credential:share')) {
 				const sharedRes = await EECredentials.getSharing(req.user, credentialId, {
 					allowGlobalScope: true,
 					globalScope: 'credential:share',

packages/cli/src/credentials/credentials.controller.ts

@@ -163,7 +163,7 @@ credentialsController.patch(
 			);
 		}
 
-		if (sharing.role.name !== 'owner' && !(await req.user.hasGlobalScope('credential:update'))) {
+		if (sharing.role.name !== 'owner' && !req.user.hasGlobalScope('credential:update')) {
 			Container.get(Logger).info(
 				'Attempt to update credential blocked due to lack of permissions',
 				{
@@ -232,7 +232,7 @@ credentialsController.delete(
 			);
 		}
 
-		if (sharing.role.name !== 'owner' && !(await req.user.hasGlobalScope('credential:delete'))) {
+		if (sharing.role.name !== 'owner' && !req.user.hasGlobalScope('credential:delete')) {
 			Container.get(Logger).info(
 				'Attempt to delete credential blocked due to lack of permissions',
 				{

packages/cli/src/credentials/credentials.service.ee.ts

@@ -40,7 +40,7 @@ export class EECredentialsService extends CredentialsService {
 		// Omit user from where if the requesting user has relevant
 		// global credential permissions. This allows the user to
 		// access credentials they don't own.
-		if (!options.allowGlobalScope || !(await user.hasGlobalScope(options.globalScope))) {
+		if (!options.allowGlobalScope || !user.hasGlobalScope(options.globalScope)) {
 			where.userId = user.id;
 		}
 

packages/cli/src/credentials/credentials.service.ts

@@ -88,7 +88,7 @@ export class CredentialsService {
 	) {
 		const findManyOptions = this.toFindManyOptions(options.listQueryOptions);
 
-		const returnAll = (await user.hasGlobalScope('credential:list')) && !options.onlyOwn;
+		const returnAll = user.hasGlobalScope('credential:list') && !options.onlyOwn;
 		const isDefaultSelect = !options.listQueryOptions?.select;
 
 		if (returnAll) {
@@ -150,7 +150,7 @@ export class CredentialsService {
 		// Omit user from where if the requesting user has relevant
 		// global credential permissions. This allows the user to
 		// access credentials they don't own.
-		if (!options.allowGlobalScope || !(await user.hasGlobalScope(options.globalScope))) {
+		if (!options.allowGlobalScope || !user.hasGlobalScope(options.globalScope)) {
 			Object.assign(where, {
 				userId: user.id,
 				role: { name: 'owner' },