Improve workflow activation (#2692)

* feat: activator disabled based on thiggers

* feat: tooltip over inactive switch

* feat: message for trigger types

* feat: deactivate on save if trigger is removed

* chore: refactor executions modal

* feat: calculate service name if possible

* feat: alert on activation

* chore: fix linting

* feat: always enable activator when active

* fix: adjust the alert

* feat: take disabled state into account

* feat: automatically save on activation

* feat: rely on nodes name and edit messages

* feat: isolate state for each activator instance

* feat: create activation modal component

* feat: activationModal checkbox and trigger message

* feat: add activation messages to node config

* chore: style activation modal

* chore: style fixes

* feat: refactor disabled state

* chore: refactor modal

* chore: refactor modal

* chore: tidy the node config

* chore: refactor and styling tweaks

* chore: minor fixes

* fix: check webhooks from ui nodes

* chore: remove saving prompt

* chore: explicit current workflow evaluation

* feat: add settings link to activation modal

* fix: immediately load executions on render

* feat: exclude error trigger from trigger nodes

* chore: add i18n keys

* fix: check localstorage more strictly

* fix: handle refresh in execution list

* remove unnessary event

* remove comment

* fix closing executions modal bugs

* update closing

* update translation key

* fix translation keys

* fix modal closing

* fix closing

* fix drawer closing

* close all modals when opening executions

* update key

* close all modals when opening workflow or new page

* delete unnessary comment

* clean up import

* clean up unnessary initial data

* clean up activator impl

* rewrite

* fix open modal bug

* simply remove error

* refactor activation logic

* fix i18n and such

* remove changes

* revert saving changes

* Revert "revert saving changes"

25c29d10553ebcc11939ff29938e8a5ac6b3ffae

* add translation

* fix new workflows saving

* clean up modal impl

* clean up impl

* refactor common code out

* remove active changes from saving

* refactor differently

* revert unnessary change

* set dirty false

* fix i18n bug

* avoid opening two modals

* fix tooltips

* add comment

* address other comments

* address comments

Co-authored-by: saintsebastian <tilitidam@gmail.com>
This commit is contained in:
Mutasem Aldmour
2022-01-21 18:00:00 +01:00
committed by GitHub
parent a9cef48048
commit 49bf786e5b
25 changed files with 372 additions and 174 deletions

View File

@@ -472,7 +472,7 @@
},
"clickOnTheQuestionMarkIcon": "Click the '?' icon to open this node on n8n.io",
"continueOnFail": {
"description": "If active, the workflow continues even if this node's <br />execution fails. When this occurs, the node passes along input data from<br />previous nodes - so your workflow should account for unexpected output data.",
"description": "If active, the workflow continues even if this node's execution fails. When this occurs, the node passes along input data from previous nodes - so your workflow should account for unexpected output data.",
"displayName": "Continue On Fail"
},
"executeOnce": {
@@ -891,12 +891,6 @@
},
"workflowActivator": {
"activateWorkflow": "Activate workflow",
"confirmMessage": {
"cancelButtonText": "",
"confirmButtonText": "Yes, activate and save!",
"headline": "Activate and save?",
"message": "When you activate the workflow all currently unsaved changes of the workflow will be saved."
},
"deactivateWorkflow": "Deactivate workflow",
"showError": {
"message": "There was a problem and the workflow could not be {newStateName}",
@@ -920,7 +914,8 @@
"title": "Problem activating workflow"
}
},
"theWorkflowIsSetToBeActiveBut": "The workflow is set to be active but could not be started.<br />Click to display error message."
"theWorkflowIsSetToBeActiveBut": "The workflow is set to be active but could not be started.<br />Click to display error message.",
"thisWorkflowHasNoTriggerNodes": "This workflow has no trigger nodes that require activation"
},
"workflowDetails": {
"active": "Active",
@@ -1040,5 +1035,19 @@
"timeoutAfter": "Timeout After",
"timeoutWorkflow": "Timeout Workflow",
"timezone": "Timezone"
},
"activationModal": {
"workflowActivated": "Workflow activated",
"theseExecutionsWillNotShowUp": "These executions will not show up immediately in the editor,",
"butYouCanSeeThem": "but you can see them in the",
"executionList": "execution list",
"ifYouChooseTo": "if you choose to",
"saveExecutions": "save executions.",
"dontShowAgain": "Don't show again",
"yourTriggersWillNowFire": "Your triggers will now fire production executions automatically.",
"yourTriggerWillNowFire": "Your trigger will now fire production executions automatically.",
"yourWorkflowWillNowRegularlyCheck": "Your workflow will now regularly check {serviceName} for events and trigger executions for them.",
"yourWorkflowWillNowListenForEvents": "Your workflow will now listen for events from {serviceName} and trigger executions.",
"gotIt": "Got it"
}
}