fix: Fix issues with nodes missing in nodes panel (#5599)

* fix: Fix issues with nodes missing in nodes panel

* fix: fix logic for deteriming app category

* chore: add comment

* chore: remove sort
This commit is contained in:
Mutasem Aldmour
2023-03-02 18:27:56 +03:00
committed by GitHub
parent 4f5013ff53
commit 5040fea93e
3 changed files with 33 additions and 29 deletions

View File

@@ -262,9 +262,9 @@ function transformCreateElements(
});
return sorted.map((nodeType) => {
// N8n node is a special case since it's the only core node that is both trigger and regular
// if we have more cases like this we should add more robust logic
const isN8nNode = nodeType.name.includes(N8N_NODE_TYPE);
const hasTriggerActions = nodeType.actions?.find((action) => action.name.includes('trigger'));
const hasRgeularActions = nodeType.actions?.find((action) => !action.name.includes('trigger'));
return {
type,
category: nodeType.codex?.categories,
@@ -273,8 +273,8 @@ function transformCreateElements(
nodeType,
subcategory: state.activeNodeActions?.displayName ?? '',
},
includedByTrigger: isN8nNode || nodeType.group.includes('trigger'),
includedByRegular: isN8nNode || !nodeType.group.includes('trigger'),
includedByTrigger: hasTriggerActions || nodeType.group.includes('trigger'),
includedByRegular: hasRgeularActions || !nodeType.group.includes('trigger'),
} as INodeCreateElement;
});
}

View File

@@ -105,7 +105,10 @@ const displayName = computed<any>(() => {
return instance?.proxy.$locale.headerText({
key: `headers.${shortNodeType}.displayName`,
fallback: props.allowActions ? displayName.replace('Trigger', '') : displayName,
fallback:
props.allowActions && props.nodeType.actions?.length
? displayName.replace('Trigger', '')
: displayName,
});
});