From 51afcd8ad5843aec9f4f19a0e50a8bc912ef07e2 Mon Sep 17 00:00:00 2001 From: Ricardo Espinoza Date: Wed, 30 Dec 2020 02:01:27 -0500 Subject: [PATCH] :bug: Fix pagination issue on Hubspot Node (#1281) --- packages/nodes-base/nodes/Hubspot/GenericFunctions.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/nodes-base/nodes/Hubspot/GenericFunctions.ts b/packages/nodes-base/nodes/Hubspot/GenericFunctions.ts index b47956d24..53953d985 100644 --- a/packages/nodes-base/nodes/Hubspot/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Hubspot/GenericFunctions.ts @@ -89,9 +89,10 @@ export async function hubspotApiRequestAllItems(this: IHookFunctions | IExecuteF do { responseData = await hubspotApiRequest.call(this, method, endpoint, body, query); query.offset = responseData.offset; - query['vid-offset'] = responseData['vid-offset']; + query.vidOffset = responseData['vid-offset']; returnData.push.apply(returnData, responseData[propertyName]); - if (query.limit && query.limit <= returnData.length) { + //ticket:getAll endpoint does not support setting a limit, so return once the limit is reached + if (query.limit && query.limit <= returnData.length && endpoint.includes('/tickets/paged')) { return returnData; } } while ( @@ -102,7 +103,6 @@ export async function hubspotApiRequestAllItems(this: IHookFunctions | IExecuteF return returnData; } - export function validateJSON(json: string | undefined): any { // tslint:disable-line:no-any let result; try {