From 536c834313b73bf36f9c9cc291dca4e4b4b860be Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Wed, 9 Nov 2022 16:09:58 +0100 Subject: [PATCH] fix(editor): Fix duplicate bug when new workflow is open (#4559) fix(editor): fix duplicate bug when new worklfow --- .../src/components/DuplicateWorkflowDialog.vue | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue b/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue index 9c1ef33c5..3c97c755d 100644 --- a/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue +++ b/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue @@ -41,7 +41,7 @@ import Vue from "vue"; import mixins from "vue-typed-mixins"; -import { MAX_WORKFLOW_NAME_LENGTH } from "@/constants"; +import { MAX_WORKFLOW_NAME_LENGTH, PLACEHOLDER_EMPTY_WORKFLOW_ID } from "@/constants"; import { workflowHelpers } from "@/components/mixins/workflowHelpers"; import { showMessage } from "@/components/mixins/showMessage"; import TagsDropdown from "@/components/TagsDropdown.vue"; @@ -50,6 +50,7 @@ import {restApi} from "@/components/mixins/restApi"; import { mapStores } from "pinia"; import { useSettingsStore } from "@/stores/settings"; import { useWorkflowsStore } from "@/stores/workflows"; +import { IWorkflowDataUpdate } from "@/Interface"; export default mixins(showMessage, workflowHelpers, restApi).extend({ components: { TagsDropdown, Modal }, @@ -121,10 +122,15 @@ export default mixins(showMessage, workflowHelpers, restApi).extend({ this.isSaving = true; - const { createdAt, updatedAt, ...workflow } = await this.restApi().getWorkflow(this.data.id); + let workflowToUpdate: IWorkflowDataUpdate | undefined; + if (currentWorkflowId !== PLACEHOLDER_EMPTY_WORKFLOW_ID) { + const { createdAt, updatedAt, ...workflow } = await this.restApi().getWorkflow(this.data.id); + workflowToUpdate = workflow; + } + const saved = await this.saveAsNewWorkflow({ name, - data: workflow, + data: workflowToUpdate, tags: this.currentTagIds, resetWebhookUrls: true, openInNewWindow: true,