🎨 Set up linting and formatting (#2120)

* ⬆️ Upgrade TS to 4.3.5

* 👕 Add ESLint configs

* 🎨 Add Prettier config

* 📦 Add deps and commands

* ⚡ Adjust global .editorconfig to new ruleset

* 🔥 Remove unneeded local .editorconfig

* 📦 Update deps in editor-ui

* 🔨 Limit Prettier to only TS files

* ⚡ Add recommended VSCode extensions

* 👕 Fix build

* 🔥 Remove Vue setting from global config

* ⚡ Disable prefer-default-export per feedback

* ✏️ Add forgotten divider

* 👕 Disable no-plusplus

* 👕 Disable class-methods-use-this

* ✏️ Alphabetize overrides

* 👕 Add one-var consecutive override

* ⏪ Revert one-var consecutive override

This reverts commit b9252cf935659ba6d76727ad484a1d3c00008fcc.

* 🎨 👕 Lint and format workflow package (#2121)

* 🎨 Format /workflow package

* 👕 Lint /workflow package

* 🎨 Re-format /workflow package

* 👕 Re-lint /workflow package

* ✏️ Fix typo

* ⚡ Consolidate if-checks

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format node-dev package (#2122)

* 🎨 Format /node-dev package

* ⚡ Exclude templates from ESLint config

This keeps the templates consistent with the codebase while preventing lint exceptions from being made part of the templates.

* 👕 Lint /node-dev package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🎨 👕 Lint and format core package (#2123)

* 🎨 Format /core package

* 👕 Lint /core package

* 🎨 Re-format /core package

* 👕 Re-lint /core package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format cli package (#2124)

* 🎨 Format /cli package

* 👕 Exclude migrations from linting

* 👕 Lint /cli package

* 🎨 Re-format /cli package

* 👕 Re-lint /cli package

* 👕 Fix build

* 🔥 Remove prefer-default-export exceptions

* ⚡ Update exceptions in ActiveExecutions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 👕 fix lint issues

* 🔧 use package specific linter, remove tslint command

* 🔨 resolve build issue, sync dependencies

* 🔧 change lint command

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

packages/cli/src/databases/entities/CredentialsEntity.ts

@@ -1,15 +1,6 @@
-import {
-	ICredentialNodeAccess,
-} from 'n8n-workflow';
-
-import {
-	getTimestampSyntax,
-	resolveDataType
-} from '../utils';
-
-import {
-	ICredentialsDb,
-} from '../..';
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
+/* eslint-disable import/no-cycle */
+import { ICredentialNodeAccess } from 'n8n-workflow';
 
 import {
 	BeforeUpdate,
@@ -20,10 +11,12 @@ import {
 	PrimaryGeneratedColumn,
 	UpdateDateColumn,
 } from 'typeorm';
+import { getTimestampSyntax, resolveDataType } from '../utils';
+
+import { ICredentialsDb } from '../..';
 
 @Entity()
 export class CredentialsEntity implements ICredentialsDb {
-
 	@PrimaryGeneratedColumn()
 	id: number;
 
@@ -47,7 +40,11 @@ export class CredentialsEntity implements ICredentialsDb {
 	@CreateDateColumn({ precision: 3, default: () => getTimestampSyntax() })
 	createdAt: Date;
 
-	@UpdateDateColumn({ precision: 3, default: () => getTimestampSyntax(), onUpdate: getTimestampSyntax() })
+	@UpdateDateColumn({
+		precision: 3,
+		default: () => getTimestampSyntax(),
+		onUpdate: getTimestampSyntax(),
+	})
 	updatedAt: Date;
 
 	@BeforeUpdate()

packages/cli/src/databases/entities/ExecutionEntity.ts

@@ -1,27 +1,13 @@
-import {
-	WorkflowExecuteMode,
-} from 'n8n-workflow';
+/* eslint-disable import/no-cycle */
+import { WorkflowExecuteMode } from 'n8n-workflow';
 
-import {
-	IExecutionFlattedDb,
-	IWorkflowDb,
-} from '../../';
+import { Column, ColumnOptions, Entity, Index, PrimaryGeneratedColumn } from 'typeorm';
+import { IExecutionFlattedDb, IWorkflowDb } from '../..';
 
-import {
-	resolveDataType
-} from '../utils';
-
-import {
-	Column,
-	ColumnOptions,
-	Entity,
-	Index,
-	PrimaryGeneratedColumn,
-} from 'typeorm';
+import { resolveDataType } from '../utils';
 
 @Entity()
 export class ExecutionEntity implements IExecutionFlattedDb {
-
 	@PrimaryGeneratedColumn()
 	id: number;
 

packages/cli/src/databases/entities/TagEntity.ts

@@ -1,4 +1,15 @@
-import { BeforeUpdate, Column, CreateDateColumn, Entity, Index, ManyToMany, PrimaryGeneratedColumn, UpdateDateColumn } from 'typeorm';
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
+/* eslint-disable import/no-cycle */
+import {
+	BeforeUpdate,
+	Column,
+	CreateDateColumn,
+	Entity,
+	Index,
+	ManyToMany,
+	PrimaryGeneratedColumn,
+	UpdateDateColumn,
+} from 'typeorm';
 import { IsDate, IsOptional, IsString, Length } from 'class-validator';
 
 import { ITagDb } from '../../Interfaces';
@@ -7,7 +18,6 @@ import { getTimestampSyntax } from '../utils';
 
 @Entity()
 export class TagEntity implements ITagDb {
-
 	@PrimaryGeneratedColumn()
 	id: number;
 
@@ -22,12 +32,16 @@ export class TagEntity implements ITagDb {
 	@IsDate()
 	createdAt: Date;
 
-	@UpdateDateColumn({ precision: 3, default: () => getTimestampSyntax(), onUpdate: getTimestampSyntax() })
+	@UpdateDateColumn({
+		precision: 3,
+		default: () => getTimestampSyntax(),
+		onUpdate: getTimestampSyntax(),
+	})
 	@IsOptional() // ignored by validation because set at DB level
 	@IsDate()
 	updatedAt: Date;
 
-	@ManyToMany(() => WorkflowEntity, workflow => workflow.tags)
+	@ManyToMany(() => WorkflowEntity, (workflow) => workflow.tags)
 	workflows: WorkflowEntity[];
 
 	@BeforeUpdate()

packages/cli/src/databases/entities/WebhookEntity.ts

@@ -1,18 +1,11 @@
-import {
-	Column,
-	Entity,
-	Index,
-	PrimaryColumn,
-} from 'typeorm';
+import { Column, Entity, Index, PrimaryColumn } from 'typeorm';
 
-import {
-	IWebhookDb,
- } from '../../Interfaces';
+// eslint-disable-next-line import/no-cycle
+import { IWebhookDb } from '../../Interfaces';
 
 @Entity()
 @Index(['webhookId', 'method', 'pathLength'])
 export class WebhookEntity implements IWebhookDb {
-
 	@Column()
 	workflowId: number;
 

packages/cli/src/databases/entities/WorkflowEntity.ts

@@ -1,13 +1,8 @@
-import {
-	Length,
-} from 'class-validator';
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
+/* eslint-disable import/no-cycle */
+import { Length } from 'class-validator';
 
-import {
-	IConnections,
-	IDataObject,
-	INode,
-	IWorkflowSettings,
-} from 'n8n-workflow';
+import { IConnections, IDataObject, INode, IWorkflowSettings } from 'n8n-workflow';
 
 import {
 	BeforeUpdate,
@@ -22,22 +17,14 @@ import {
 	UpdateDateColumn,
 } from 'typeorm';
 
-import {
-	IWorkflowDb,
-} from '../../';
+import { IWorkflowDb } from '../..';
 
-import {
-	getTimestampSyntax,
-	resolveDataType
-} from '../utils';
+import { getTimestampSyntax, resolveDataType } from '../utils';
 
-import {
-	TagEntity,
-} from './TagEntity';
+import { TagEntity } from './TagEntity';
 
 @Entity()
 export class WorkflowEntity implements IWorkflowDb {
-
 	@PrimaryGeneratedColumn()
 	id: number;
 
@@ -58,7 +45,11 @@ export class WorkflowEntity implements IWorkflowDb {
 	@CreateDateColumn({ precision: 3, default: () => getTimestampSyntax() })
 	createdAt: Date;
 
-	@UpdateDateColumn({ precision: 3, default: () => getTimestampSyntax(), onUpdate: getTimestampSyntax() })
+	@UpdateDateColumn({
+		precision: 3,
+		default: () => getTimestampSyntax(),
+		onUpdate: getTimestampSyntax(),
+	})
 	updatedAt: Date;
 
 	@Column({
@@ -73,16 +64,16 @@ export class WorkflowEntity implements IWorkflowDb {
 	})
 	staticData?: IDataObject;
 
-	@ManyToMany(() => TagEntity, tag => tag.workflows)
+	@ManyToMany(() => TagEntity, (tag) => tag.workflows)
 	@JoinTable({
-		name: "workflows_tags", // table name for the junction table of this relation
+		name: 'workflows_tags', // table name for the junction table of this relation
 		joinColumn: {
-				name: "workflowId",
-				referencedColumnName: "id",
+			name: 'workflowId',
+			referencedColumnName: 'id',
 		},
 		inverseJoinColumn: {
-				name: "tagId",
-				referencedColumnName: "id",
+			name: 'tagId',
+			referencedColumnName: 'id',
 		},
 	})
 	tags: TagEntity[];

packages/cli/src/databases/entities/index.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/naming-convention */
+/* eslint-disable import/no-cycle */
 import { CredentialsEntity } from './CredentialsEntity';
 import { ExecutionEntity } from './ExecutionEntity';
 import { WorkflowEntity } from './WorkflowEntity';

packages/cli/src/databases/utils.ts

@@ -1,7 +1,6 @@
-import {
-	DatabaseType,
-} from '../index';
-import { getConfigValueSync } from '../../src/GenericHelpers';
+/* eslint-disable import/no-cycle */
+import { DatabaseType } from '../index';
+import { getConfigValueSync } from '../GenericHelpers';
 
 /**
  * Resolves the data type for the used database type
@@ -10,6 +9,7 @@ import { getConfigValueSync } from '../../src/GenericHelpers';
  * @param {string} dataType
  * @returns {string}
  */
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function resolveDataType(dataType: string) {
 	const dbType = getConfigValueSync('database.type') as DatabaseType;
 
@@ -27,16 +27,16 @@ export function resolveDataType(dataType: string) {
 	return typeMap[dbType][dataType] ?? dataType;
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function getTimestampSyntax() {
 	const dbType = getConfigValueSync('database.type') as DatabaseType;
 
 	const map: { [key in DatabaseType]: string } = {
 		sqlite: "STRFTIME('%Y-%m-%d %H:%M:%f', 'NOW')",
-		postgresdb: "CURRENT_TIMESTAMP(3)",
-		mysqldb: "CURRENT_TIMESTAMP(3)",
-		mariadb: "CURRENT_TIMESTAMP(3)",
+		postgresdb: 'CURRENT_TIMESTAMP(3)',
+		mysqldb: 'CURRENT_TIMESTAMP(3)',
+		mariadb: 'CURRENT_TIMESTAMP(3)',
 	};
 
 	return map[dbType];
 }
-