diff --git a/packages/cli/src/commands/BaseCommand.ts b/packages/cli/src/commands/BaseCommand.ts index 6f2d03c48..1949bc6f6 100644 --- a/packages/cli/src/commands/BaseCommand.ts +++ b/packages/cli/src/commands/BaseCommand.ts @@ -42,9 +42,8 @@ export abstract class BaseCommand extends Command { /** * How long to wait for graceful shutdown before force killing the process. - * Subclasses can override this value. */ - protected gracefulShutdownTimeoutInS: number = 30; + protected gracefulShutdownTimeoutInS: number = config.getEnv('generic.gracefulShutdownTimeout'); async init(): Promise { await initErrorHandling(); diff --git a/packages/cli/src/commands/worker.ts b/packages/cli/src/commands/worker.ts index d868e5c32..31a862dfd 100644 --- a/packages/cli/src/commands/worker.ts +++ b/packages/cli/src/commands/worker.ts @@ -264,7 +264,13 @@ export class Worker extends BaseCommand { } async init() { - this.gracefulShutdownTimeoutInS = config.getEnv('queue.bull.gracefulShutdownTimeout'); + const configuredShutdownTimeout = config.getEnv('queue.bull.gracefulShutdownTimeout'); + if (configuredShutdownTimeout) { + this.gracefulShutdownTimeoutInS = configuredShutdownTimeout; + this.logger.warn( + 'QUEUE_WORKER_TIMEOUT has been deprecated. Rename it to N8N_GRACEFUL_SHUTDOWN_TIMEOUT.', + ); + } await this.initCrashJournal(); this.logger.debug('Starting n8n worker...'); diff --git a/packages/cli/src/config/schema.ts b/packages/cli/src/config/schema.ts index af82b2484..3673c3f86 100644 --- a/packages/cli/src/config/schema.ts +++ b/packages/cli/src/config/schema.ts @@ -439,7 +439,7 @@ export const schema = { env: 'QUEUE_RECOVERY_INTERVAL', }, gracefulShutdownTimeout: { - doc: 'How long should n8n wait for running executions before exiting worker process (seconds)', + doc: '[DEPRECATED] (Use N8N_GRACEFUL_SHUTDOWN_TIMEOUT instead) How long should n8n wait for running executions before exiting worker process (seconds)', format: Number, default: 30, env: 'QUEUE_WORKER_TIMEOUT', @@ -497,6 +497,13 @@ export const schema = { default: 'dev', env: 'N8N_RELEASE_TYPE', }, + + gracefulShutdownTimeout: { + doc: 'How long should n8n process wait for components to shut down before exiting the process (seconds)', + format: Number, + default: 30, + env: 'N8N_GRACEFUL_SHUTDOWN_TIMEOUT', + }, }, // How n8n can be reached (Editor & REST-API)