mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Replace Vue.delete with native alternative (no-changelog) (#6444)

Browse Source 
* feat: replace Vue.delete with native alternative (no-changelog)

* fix: fix linting issues
This commit is contained in:
Alex Grozav
2023-06-15 18:27:35 +03:00
committed by GitHub
parent 1dbca44025
commit 618b1aba30
6 changed files with 48 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/editor-ui/src/stores/communityNodes.store.ts
View File

@@ -86,7 +86,8 @@ export const useCommunityNodesStore = defineStore(STORES.COMMUNITY_NODES, {
);
},
removePackageByName(name: string): void {
Vue.delete(this.installedPackages, name);
const { [name]: removedPackage, ...remainingPackages } = this.installedPackages;
this.installedPackages = remainingPackages;
},
updatePackageObject(newPackage: PublicInstalledPackage) {
this.installedPackages[newPackage.packageName] = newPackage;

3
packages/editor-ui/src/stores/credentials.store.ts
View File

@@ -317,7 +317,8 @@ export const useCredentialsStore = defineStore(STORES.CREDENTIALS, {
const rootStore = useRootStore();
const deleted = await deleteCredential(rootStore.getRestApiContext, id);
if (deleted) {
Vue.delete(this.credentials, id);
const { [id]: deletedCredential, ...rest } = this.credentials;
this.credentials = rest;
}
},
async oAuth2Authorize(data: ICredentialsResponse): Promise<string> {

3
packages/editor-ui/src/stores/tags.store.ts
View File

@@ -58,7 +58,8 @@ export const useTagsStore = defineStore(STORES.TAGS, {
});
},
deleteTag(id: string): void {
Vue.delete(this.tags, id);
const { [id]: deleted, ...rest } = this.tags;
this.tags = rest;
},
async fetchAll(params?: { force?: boolean; withUsageCount?: boolean }): Promise<ITag[]> {

40
packages/editor-ui/src/stores/workflows.store.ts
View File

@@ -854,19 +854,18 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
uiStore.lastSelectedNode = nameData.new;
}
this.nodeMetadata = { ...this.nodeMetadata, [nameData.new]: this.nodeMetadata[nameData.old] };
Vue.delete(this.nodeMetadata, nameData.old);
const { [nameData.old]: removed, ...rest } = this.nodeMetadata;
this.nodeMetadata = { ...rest, [nameData.new]: this.nodeMetadata[nameData.old] };
if (this.workflow.pinData && this.workflow.pinData.hasOwnProperty(nameData.old)) {
const { [nameData.old]: renamed, ...restPinData } = this.workflow.pinData;
this.workflow = {
...this.workflow,
pinData: {
...this.workflow.pinData,
[nameData.new]: this.workflow.pinData[nameData.old],
...restPinData,
[nameData.new]: renamed,
},
};
Vue.delete(this.workflow.pinData!, nameData.old);
}
this.workflowExecutionPairedItemMappings = getPairedItemsMapping(this.workflowExecutionData);
@@ -911,8 +910,10 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
return true;
}
// @ts-ignore
Vue.delete(node.issues, nodeIssueData.type);
const { [nodeIssueData.type]: removedNodeIssue, ...remainingNodeIssues } = node.issues;
this.updateNodeAtIndex(nodeIndex, {
issues: remainingNodeIssues,
});
} else {
if (node.issues === undefined) {
this.updateNodeAtIndex(nodeIndex, {
@@ -945,10 +946,15 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
},
removeNode(node: INodeUi): void {
Vue.delete(this.nodeMetadata, node.name);
const { [node.name]: removedNodeMetadata, ...remainingNodeMetadata } = this.nodeMetadata;
this.nodeMetadata = remainingNodeMetadata;
if (this.workflow.pinData && this.workflow.pinData.hasOwnProperty(node.name)) {
Vue.delete(this.workflow.pinData, node.name);
const { [node.name]: removedPinData, ...remainingPinData } = this.workflow.pinData;
this.workflow = {
...this.workflow,
pinData: remainingPinData,
};
}
for (let i = 0; i < this.workflow.nodes.length; i++) {
@@ -1094,7 +1100,19 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
if (this.workflowExecutionData === null || !this.workflowExecutionData.data) {
return;
}
Vue.delete(this.workflowExecutionData.data.resultData.runData, nodeName);
const { [nodeName]: removedRunData, ...remainingRunData } =
this.workflowExecutionData.data.resultData.runData;
this.workflowExecutionData = {
...this.workflowExecutionData,
data: {
...this.workflowExecutionData.data,
resultData: {
...this.workflowExecutionData.data.resultData,
runData: remainingRunData,
},
},
};
},
pinDataByNodeName(nodeName: string): INodeExecutionData[] | undefined {