refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -229,11 +229,10 @@ export class AwsElb implements INodeType {
const params = ['Version=2015-12-01'];
params.push(
('Certificates.member.1.CertificateArn=' +
this.getNodeParameter('certificateId', i)) as string,
'Certificates.member.1.CertificateArn=' + this.getNodeParameter('certificateId', i),
);
params.push(('ListenerArn=' + this.getNodeParameter('listenerId', i)) as string);
params.push('ListenerArn=' + this.getNodeParameter('listenerId', i));
responseData = await awsApiRequestSOAP.call(
this,
@@ -286,11 +285,10 @@ export class AwsElb implements INodeType {
const params = ['Version=2015-12-01'];
params.push(
('Certificates.member.1.CertificateArn=' +
this.getNodeParameter('certificateId', i)) as string,
'Certificates.member.1.CertificateArn=' + this.getNodeParameter('certificateId', i),
);
params.push(('ListenerArn=' + this.getNodeParameter('listenerId', i)) as string);
params.push('ListenerArn=' + this.getNodeParameter('listenerId', i));
responseData = await awsApiRequestSOAP.call(
this,
@@ -328,15 +326,15 @@ export class AwsElb implements INodeType {
params.push(`Type=${type}`);
for (let i = 1; i <= subnets.length; i++) {
params.push(`Subnets.member.${i}=${subnets[i - 1]}`);
for (let index = 1; index <= subnets.length; index++) {
params.push(`Subnets.member.${index}=${subnets[index - 1]}`);
}
if (additionalFields.securityGroups) {
const securityGroups = additionalFields.securityGroups as string[];
for (let i = 1; i <= securityGroups.length; i++) {
params.push(`SecurityGroups.member.${i}=${securityGroups[i - 1]}`);
for (let index = 1; index <= securityGroups.length; index++) {
params.push(`SecurityGroups.member.${index}=${securityGroups[index - 1]}`);
}
}
@@ -344,10 +342,10 @@ export class AwsElb implements INodeType {
const tags = (additionalFields.tagsUi as IDataObject).tagValues as IDataObject[];
if (tags) {
for (let i = 1; i <= tags.length; i++) {
params.push(`Tags.member.${i}.Key=${tags[i - 1].key}`);
for (let index = 1; index <= tags.length; index++) {
params.push(`Tags.member.${index}.Key=${tags[index - 1].key}`);
params.push(`Tags.member.${i}.Value=${tags[i - 1].value}`);
params.push(`Tags.member.${index}.Value=${tags[index - 1].value}`);
}
}
}
@@ -367,9 +365,7 @@ export class AwsElb implements INodeType {
if (operation === 'delete') {
const params = ['Version=2015-12-01'];
params.push(
('LoadBalancerArn=' + this.getNodeParameter('loadBalancerId', i)) as string,
);
params.push('LoadBalancerArn=' + this.getNodeParameter('loadBalancerId', i));
responseData = await awsApiRequestSOAP.call(
this,
@@ -393,8 +389,8 @@ export class AwsElb implements INodeType {
if (filters.names) {
const names = (filters.names as string).split(',');
for (let i = 1; i <= names.length; i++) {
params.push(`Names.member.${i}=${names[i - 1]}`);
for (let index = 1; index <= names.length; index++) {
params.push(`Names.member.${index}=${names[index - 1]}`);
}
}
@@ -425,9 +421,7 @@ export class AwsElb implements INodeType {
if (operation === 'get') {
const params = ['Version=2015-12-01'];
params.push(
('LoadBalancerArns.member.1=' + this.getNodeParameter('loadBalancerId', i)) as string,
);
params.push('LoadBalancerArns.member.1=' + this.getNodeParameter('loadBalancerId', i));
responseData = await awsApiRequestSOAP.call(
this,