From 62ce962ec94578e16ba3e670caee93d4c8970bbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 18 Dec 2023 16:10:45 +0100 Subject: [PATCH] refactor(editor): Add telemetry for workflow history (no-changelog) (#8072) https://linear.app/n8n/issue/PAY-1142 --- packages/editor-ui/src/views/WorkflowHistory.vue | 2 ++ .../editor-ui/src/views/__tests__/WorkflowHistory.test.ts | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/packages/editor-ui/src/views/WorkflowHistory.vue b/packages/editor-ui/src/views/WorkflowHistory.vue index 1e947d679..a2ea3bcd0 100644 --- a/packages/editor-ui/src/views/WorkflowHistory.vue +++ b/packages/editor-ui/src/views/WorkflowHistory.vue @@ -18,6 +18,7 @@ import { useWorkflowHistoryStore } from '@/stores/workflowHistory.store'; import { useUIStore } from '@/stores/ui.store'; import { useWorkflowsStore } from '@/stores/workflows.store'; import { telemetry } from '@/plugins/telemetry'; +import { useRootStore } from '@/stores/n8nRoot.store'; type WorkflowHistoryActionRecord = { [K in Uppercase]: Lowercase; @@ -76,6 +77,7 @@ const evaluatedPruneTime = computed(() => Math.floor(workflowHistoryStore.evalua const sendTelemetry = (event: string) => { telemetry.track(event, { + instance_id: useRootStore().instanceId, workflow_id: route.params.workflowId, }); }; diff --git a/packages/editor-ui/src/views/__tests__/WorkflowHistory.test.ts b/packages/editor-ui/src/views/__tests__/WorkflowHistory.test.ts index 23a0ce13e..ad39e22bc 100644 --- a/packages/editor-ui/src/views/__tests__/WorkflowHistory.test.ts +++ b/packages/editor-ui/src/views/__tests__/WorkflowHistory.test.ts @@ -107,6 +107,7 @@ describe('WorkflowHistory', () => { params: { workflowId, versionId: versionData.versionId }, }); expect(telemetry.track).toHaveBeenCalledWith('User opened workflow history', { + instance_id: '', workflow_id: workflowId, }); }); @@ -124,6 +125,7 @@ describe('WorkflowHistory', () => { await waitFor(() => { expect(router.replace).not.toHaveBeenCalled(); expect(telemetry.track).toHaveBeenCalledWith('User selected version', { + instance_id: '', workflow_id: workflowId, }); }); @@ -142,6 +144,7 @@ describe('WorkflowHistory', () => { params: { workflowId, versionId }, }); expect(telemetry.track).toHaveBeenCalledWith('User selected version', { + instance_id: '', workflow_id: workflowId, }); }); @@ -159,6 +162,7 @@ describe('WorkflowHistory', () => { params: { workflowId, versionId }, }); expect(telemetry.track).toHaveBeenCalledWith('User opened version in new tab', { + instance_id: '', workflow_id: workflowId, }); }); @@ -180,6 +184,7 @@ describe('WorkflowHistory', () => { params: { workflowId, versionId }, }); expect(telemetry.track).toHaveBeenCalledWith('User opened version in new tab', { + instance_id: '', workflow_id: workflowId, }); }); @@ -202,6 +207,7 @@ describe('WorkflowHistory', () => { params: { name: newWorkflowId }, }); expect(telemetry.track).toHaveBeenCalledWith('User cloned version', { + instance_id: '', workflow_id: workflowId, }); }); @@ -217,6 +223,7 @@ describe('WorkflowHistory', () => { await waitFor(() => { expect(telemetry.track).toHaveBeenCalledWith('User downloaded version', { + instance_id: '', workflow_id: workflowId, }); });