mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(core): Unify failed and error execution status (no-changelog) (#8943)

Browse Source
This commit is contained in:
Iván Ovejero
2024-03-25 17:52:07 +01:00
committed by GitHub
parent 1fb0dd4f1c
commit 69807a5efb
20 changed files with 36 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/editor-ui/src/components/ExecutionsList.vue
View File

@@ -799,7 +799,7 @@ export default defineComponent({
} else if (execution.finished) {
status = 'success';
} else if (execution.stoppedAt !== null) {
status = 'failed';
status = 'error';
} else {
status = 'unknown';
}
@@ -825,7 +825,7 @@ export default defineComponent({
text = this.i18n.baseText('executionsList.running');
} else if (status === 'success') {
text = this.i18n.baseText('executionsList.succeeded');
} else if (status === 'failed') {
} else if (status === 'error') {
text = this.i18n.baseText('executionsList.error');
} else {
text = this.i18n.baseText('executionsList.unknown');
@@ -841,7 +841,7 @@ export default defineComponent({
path = 'executionsList.statusWaiting';
} else if (status === 'canceled') {
path = 'executionsList.statusCanceled';
} else if (['crashed', 'failed', 'success'].includes(status)) {
} else if (['crashed', 'error', 'success'].includes(status)) {
if (!entry.stoppedAt) {
path = 'executionsList.statusTextWithoutTime';
} else {
@@ -1032,7 +1032,7 @@ export default defineComponent({
font-weight: var(--font-weight-bold);
.crashed &,
.failed & {
.error & {
color: var(--color-danger);
}
@@ -1143,7 +1143,7 @@ export default defineComponent({
}
&.crashed td:first-child::before,
&.failed td:first-child::before {
&.error td:first-child::before {
background: var(--execution-card-border-error);
}

2
packages/editor-ui/src/components/ExecutionsView/__tests__/ExecutionPreview.test.ts
View File

@@ -56,7 +56,7 @@ const executionDataFactory = (): ExecutionSummary => ({
stoppedAt: faker.date.past(),
workflowId: faker.number.int().toString(),
workflowName: faker.string.sample(),
status: faker.helpers.arrayElement(['failed', 'success']),
status: faker.helpers.arrayElement(['error', 'success']),
nodeExecutionStatus: {},
retryOf: generateUndefinedNullOrString(),
retrySuccessId: generateUndefinedNullOrString(),

5
packages/editor-ui/src/components/Node.vue
View File

@@ -285,10 +285,7 @@ export default defineComponent({
return this.workflowsStore.getWorkflowResultDataByNodeName(this.data?.name || '') || [];
},
hasIssues(): boolean {
if (
this.nodeExecutionStatus &&
['crashed', 'error', 'failed'].includes(this.nodeExecutionStatus)
)
if (this.nodeExecutionStatus && ['crashed', 'error'].includes(this.nodeExecutionStatus))
return true;
if (this.pinnedData.hasData.value) return false;
if (this.data?.issues !== undefined && Object.keys(this.data.issues).length) {

2
packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts
View File

@@ -56,7 +56,7 @@ const executionDataFactory = (): ExecutionSummary => ({
stoppedAt: faker.date.past(),
workflowId: faker.number.int().toString(),
workflowName: faker.string.sample(),
status: faker.helpers.arrayElement(['failed', 'success']),
status: faker.helpers.arrayElement(['error', 'success']),
nodeExecutionStatus: {},
retryOf: generateUndefinedNullOrString(),
retrySuccessId: generateUndefinedNullOrString(),