refactor: Setup typescript project references across workflow, core, and cli (#4519)

* refactor: use consistent folder structure across workflow, core, and cli

* setup typescript project references across workflow, core, and cli

packages/cli/src/workflows/workflows.controller.ee.ts

@@ -1,15 +1,18 @@
 import express from 'express';
-import { Db, InternalHooksManager, ResponseHelper, WorkflowHelpers } from '..';
-import config from '../../config';
-import { WorkflowEntity } from '../databases/entities/WorkflowEntity';
-import { validateEntity } from '../GenericHelpers';
-import type { WorkflowRequest } from '../requests';
-import { isSharingEnabled, rightDiff } from '../UserManagement/UserManagementHelper';
+import * as Db from '@/Db';
+import { InternalHooksManager } from '@/InternalHooksManager';
+import * as ResponseHelper from '@/ResponseHelper';
+import * as WorkflowHelpers from '@/WorkflowHelpers';
+import config from '@/config';
+import { WorkflowEntity } from '@db/entities/WorkflowEntity';
+import { validateEntity } from '@/GenericHelpers';
+import type { WorkflowRequest } from '@/requests';
+import { isSharingEnabled, rightDiff } from '@/UserManagement/UserManagementHelper';
 import { EEWorkflowsService as EEWorkflows } from './workflows.services.ee';
 import { externalHooks } from '../Server';
-import { SharedWorkflow } from '../databases/entities/SharedWorkflow';
+import { SharedWorkflow } from '@db/entities/SharedWorkflow';
 import { LoggerProxy } from 'n8n-workflow';
-import * as TagHelpers from '../TagHelpers';
+import * as TagHelpers from '@/TagHelpers';
 import { EECredentialsService as EECredentials } from '../credentials/credentials.service.ee';
 import { WorkflowsService } from './workflows.services';
 

packages/cli/src/workflows/workflows.controller.ts

@@ -1,40 +1,38 @@
 /* eslint-disable no-param-reassign */
-/* eslint-disable import/no-cycle */
 
 import express from 'express';
 import { INode, IPinData, LoggerProxy, Workflow } from 'n8n-workflow';
 
 import axios from 'axios';
+import * as ActiveWorkflowRunner from '@/ActiveWorkflowRunner';
+import * as Db from '@/Db';
+import * as GenericHelpers from '@/GenericHelpers';
+import * as ResponseHelper from '@/ResponseHelper';
+import * as WorkflowHelpers from '@/WorkflowHelpers';
+import { whereClause } from '@/CredentialsHelper';
+import { NodeTypes } from '@/NodeTypes';
+import * as WorkflowExecuteAdditionalData from '@/WorkflowExecuteAdditionalData';
+import * as TestWebhooks from '@/TestWebhooks';
+import { WorkflowRunner } from '@/WorkflowRunner';
 import {
-	ActiveWorkflowRunner,
-	Db,
-	GenericHelpers,
-	NodeTypes,
-	ResponseHelper,
-	whereClause,
-	WorkflowHelpers,
-	WorkflowExecuteAdditionalData,
 	IWorkflowResponse,
 	IExecutionPushResponse,
 	IWorkflowExecutionDataProcess,
-	TestWebhooks,
-	WorkflowRunner,
 	IWorkflowDb,
-} from '..';
-import config from '../../config';
-import * as TagHelpers from '../TagHelpers';
-import { SharedWorkflow } from '../databases/entities/SharedWorkflow';
-import { WorkflowEntity } from '../databases/entities/WorkflowEntity';
-import { validateEntity } from '../GenericHelpers';
-import { InternalHooksManager } from '../InternalHooksManager';
-import { externalHooks } from '../Server';
-import { getLogger } from '../Logger';
-import type { WorkflowRequest } from '../requests';
-import { isBelowOnboardingThreshold } from '../WorkflowHelpers';
+} from '@/Interfaces';
+import config from '@/config';
+import * as TagHelpers from '@/TagHelpers';
+import { SharedWorkflow } from '@db/entities/SharedWorkflow';
+import { WorkflowEntity } from '@db/entities/WorkflowEntity';
+import { validateEntity } from '@/GenericHelpers';
+import { InternalHooksManager } from '@/InternalHooksManager';
+import { externalHooks } from '@/Server';
+import { getLogger } from '@/Logger';
+import type { WorkflowRequest } from '@/requests';
+import { isBelowOnboardingThreshold } from '@/WorkflowHelpers';
 import { EEWorkflowController } from './workflows.controller.ee';
 import { WorkflowsService } from './workflows.services';
 
-const activeWorkflowRunner = ActiveWorkflowRunner.getInstance();
 export const workflowsController = express.Router();
 
 /**
@@ -325,7 +323,7 @@ workflowsController.delete(
 
 		if (shared.workflow.active) {
 			// deactivate before deleting
-			await activeWorkflowRunner.remove(workflowId);
+			await ActiveWorkflowRunner.getInstance().remove(workflowId);
 		}
 
 		await Db.collections.Workflow.delete(workflowId);

packages/cli/src/workflows/workflows.services.ee.ts

@@ -1,13 +1,16 @@
 import { DeleteResult, EntityManager, In, Not } from 'typeorm';
-import { Db, ICredentialsDb, ResponseHelper, WorkflowHelpers } from '..';
-import { SharedWorkflow } from '../databases/entities/SharedWorkflow';
-import { User } from '../databases/entities/User';
-import { WorkflowEntity } from '../databases/entities/WorkflowEntity';
-import { RoleService } from '../role/role.service';
-import { UserService } from '../user/user.service';
+import * as Db from '@/Db';
+import * as ResponseHelper from '@/ResponseHelper';
+import * as WorkflowHelpers from '@/WorkflowHelpers';
+import { ICredentialsDb } from '@/Interfaces';
+import { SharedWorkflow } from '@db/entities/SharedWorkflow';
+import { User } from '@db/entities/User';
+import { WorkflowEntity } from '@db/entities/WorkflowEntity';
+import { RoleService } from '@/role/role.service';
+import { UserService } from '@/user/user.service';
 import { WorkflowsService } from './workflows.services';
 import type { WorkflowWithSharingsAndCredentials } from './workflows.types';
-import { EECredentialsService as EECredentials } from '../credentials/credentials.service.ee';
+import { EECredentialsService as EECredentials } from '@/credentials/credentials.service.ee';
 
 export class EEWorkflowsService extends WorkflowsService {
 	static async isOwned(

packages/cli/src/workflows/workflows.services.ts

@@ -1,22 +1,20 @@
 import { JsonObject, jsonParse, LoggerProxy } from 'n8n-workflow';
 import { FindManyOptions, FindOneOptions, In, ObjectLiteral } from 'typeorm';
-import {
-	ActiveWorkflowRunner,
-	Db,
-	InternalHooksManager,
-	ResponseHelper,
-	whereClause,
-	WorkflowHelpers,
-} from '..';
-import config from '../../config';
-import { SharedWorkflow } from '../databases/entities/SharedWorkflow';
-import { User } from '../databases/entities/User';
-import { WorkflowEntity } from '../databases/entities/WorkflowEntity';
-import { validateEntity } from '../GenericHelpers';
-import { externalHooks } from '../Server';
-import * as TagHelpers from '../TagHelpers';
-import { getSharedWorkflowIds } from '../WorkflowHelpers';
 import { validate as jsonSchemaValidate } from 'jsonschema';
+import * as ActiveWorkflowRunner from '@/ActiveWorkflowRunner';
+import * as Db from '@/Db';
+import { InternalHooksManager } from '@/InternalHooksManager';
+import * as ResponseHelper from '@/ResponseHelper';
+import * as WorkflowHelpers from '@/WorkflowHelpers';
+import { whereClause } from '@/CredentialsHelper';
+import config from '@/config';
+import { SharedWorkflow } from '@db/entities/SharedWorkflow';
+import { User } from '@db/entities/User';
+import { WorkflowEntity } from '@db/entities/WorkflowEntity';
+import { validateEntity } from '@/GenericHelpers';
+import { externalHooks } from '@/Server';
+import * as TagHelpers from '@/TagHelpers';
+import { getSharedWorkflowIds } from '@/WorkflowHelpers';
 
 export interface IGetWorkflowsQueryFilter {
 	id?: number | string;

packages/cli/src/workflows/workflows.types.ts

@@ -1,6 +1,6 @@
 import type { IUser } from 'n8n-workflow';
-import { SharedWorkflow } from '../databases/entities/SharedWorkflow';
-import { WorkflowEntity } from '../databases/entities/WorkflowEntity';
+import { SharedWorkflow } from '@db/entities/SharedWorkflow';
+import { WorkflowEntity } from '@db/entities/WorkflowEntity';
 
 export interface WorkflowWithSharingsAndCredentials extends Omit<WorkflowEntity, 'shared'> {
 	ownedBy?: IUser | null;