From 6d8ea4bff5d474b3e72cc13b4c318f3d4844cb44 Mon Sep 17 00:00:00 2001 From: Kaito Udagawa Date: Sat, 3 Jul 2021 19:46:30 +0900 Subject: [PATCH] :bug: Fix Google Sheet to handle 0 correctly (#1937) * :bug: Fix Google Sheet to handle 0 correctly `if (condition) { statement }` will not be executed if the `condition` is `0` (number) so that appending 0 to Google Sheets results in an empty cell. Checking if the value is `null` or `undefined` is enough to guarantee that `toString` is callable. * :bug: Add semicolon --- packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts b/packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts index aca82ddea..28d35d5af 100644 --- a/packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts +++ b/packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts @@ -486,8 +486,9 @@ export class GoogleSheet { inputData.forEach((item) => { rowData = []; keyColumnOrder.forEach((key) => { - if (item.hasOwnProperty(key) && item[key]) { - rowData.push(item[key]!.toString()); + const data = item[key]; + if (item.hasOwnProperty(key) && data !== null && typeof data !== 'undefined') { + rowData.push(data.toString()); } else { rowData.push(''); }