From 700cc39cbc7da3c70513ff586dc97319456308ae Mon Sep 17 00:00:00 2001 From: Michael Kret <88898367+michael-radency@users.noreply.github.com> Date: Wed, 3 May 2023 12:45:44 +0300 Subject: [PATCH] fix(core): Better errors for common status codes fix --- packages/workflow/src/NodeErrors.ts | 11 ++++++++--- packages/workflow/test/NodeErrors.test.ts | 1 - 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/workflow/src/NodeErrors.ts b/packages/workflow/src/NodeErrors.ts index b67286132..4c8e014e4 100644 --- a/packages/workflow/src/NodeErrors.ts +++ b/packages/workflow/src/NodeErrors.ts @@ -316,12 +316,17 @@ export class NodeApiError extends NodeError { (error?.reason as IDataObject)?.description) as string; } - if (!httpCode && !message && error.status === 'rejected') { + if ( + !httpCode && + !message && + this.message && + this.message.toUpperCase().includes('ECONNREFUSED') + ) { httpCode = 'ECONNREFUSED'; const originalMessage = this.message; - if (!description && originalMessage) { - this.description = `${originalMessage} ${this.description ?? ''}`; + if (!description) { + this.description = `${originalMessage}; ${this.description ?? ''}`; } } diff --git a/packages/workflow/test/NodeErrors.test.ts b/packages/workflow/test/NodeErrors.test.ts index 05556f474..9dd102462 100644 --- a/packages/workflow/test/NodeErrors.test.ts +++ b/packages/workflow/test/NodeErrors.test.ts @@ -61,7 +61,6 @@ describe('NodeErrors tests', () => { it('should return default message for ECONNREFUSED', () => { const nodeApiError = new NodeApiError(node, { - status: 'rejected', message: 'ECONNREFUSED', });