diff --git a/packages/design-system/src/components/N8nDatatable/Datatable.vue b/packages/design-system/src/components/N8nDatatable/Datatable.vue index 90afe2a04..526e49640 100644 --- a/packages/design-system/src/components/N8nDatatable/Datatable.vue +++ b/packages/design-system/src/components/N8nDatatable/Datatable.vue @@ -74,7 +74,7 @@ interface DatatableProps { rows: DatatableRow[]; currentPage?: number; pagination?: boolean; - rowsPerPage?: number | '*'; + rowsPerPage?: number; } defineOptions({ name: 'N8nDatatable' }); @@ -92,10 +92,6 @@ const rowsPerPageOptions = ref([10, 25, 50, 100]); const $style = useCssModule(); const totalPages = computed(() => { - if (props.rowsPerPage === '*') { - return 1; - } - return Math.ceil(props.rows.length / props.rowsPerPage); }); @@ -104,10 +100,6 @@ const totalRows = computed(() => { }); const visibleRows = computed(() => { - if (props.rowsPerPage === '*') { - return props.rows; - } - const start = (props.currentPage - 1) * props.rowsPerPage; const end = start + props.rowsPerPage; @@ -123,10 +115,10 @@ function onUpdateCurrentPage(value: number) { $emit('update:currentPage', value); } -function onRowsPerPageChange(value: number | '*') { +function onRowsPerPageChange(value: number) { $emit('update:rowsPerPage', value); - const maxPage = value === '*' ? 1 : Math.ceil(totalRows.value / value); + const maxPage = Math.ceil(totalRows.value / value); if (maxPage < props.currentPage) { onUpdateCurrentPage(maxPage); } diff --git a/packages/design-system/src/components/N8nDatatable/__tests__/Datatable.spec.ts b/packages/design-system/src/components/N8nDatatable/__tests__/Datatable.spec.ts index 53a738944..f2f7619ab 100644 --- a/packages/design-system/src/components/N8nDatatable/__tests__/Datatable.spec.ts +++ b/packages/design-system/src/components/N8nDatatable/__tests__/Datatable.spec.ts @@ -3,13 +3,13 @@ import N8nDatatable from '../Datatable.vue'; import { rows, columns } from './data'; const stubs = [ - // Ideally we'd like to stub N8nSelect, but it doesn't work + 'n8n-option', + 'n8n-button', + // Ideally we'd like to stub N8nSelect & N8nPagination, but it doesn't work // after migrating to setup script: // https://github.com/vuejs/vue-test-utils/issues/2048 // 'n8n-select', - 'n8n-option', - 'n8n-button', - 'n8n-pagination', + // 'n8n-pagination', ]; describe('components', () => { diff --git a/packages/design-system/src/components/N8nDatatable/__tests__/__snapshots__/Datatable.spec.ts.snap b/packages/design-system/src/components/N8nDatatable/__tests__/__snapshots__/Datatable.spec.ts.snap index 0ebdd2e1e..0d5d029f1 100644 --- a/packages/design-system/src/components/N8nDatatable/__tests__/__snapshots__/Datatable.spec.ts.snap +++ b/packages/design-system/src/components/N8nDatatable/__tests__/__snapshots__/Datatable.spec.ts.snap @@ -95,7 +95,18 @@ exports[`components > N8nDatatable > should render correctly 1`] = `