From 844d257c258fca360c856b40c814872645fca438 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Tue, 13 Oct 2020 10:48:46 +0200 Subject: [PATCH] :zap: Fix and improvements on Sendy-Node --- .../nodes/Sendy/CampaignDescription.ts | 50 ++++++++++-------- packages/nodes-base/nodes/Sendy/Sendy.node.ts | 6 +-- .../nodes/Sendy/SubscriberDescription.ts | 2 +- packages/nodes-base/nodes/Sendy/sendy.png | Bin 7326 -> 1771 bytes 4 files changed, 33 insertions(+), 25 deletions(-) diff --git a/packages/nodes-base/nodes/Sendy/CampaignDescription.ts b/packages/nodes-base/nodes/Sendy/CampaignDescription.ts index e0402af8a..e3fb5ca0c 100644 --- a/packages/nodes-base/nodes/Sendy/CampaignDescription.ts +++ b/packages/nodes-base/nodes/Sendy/CampaignDescription.ts @@ -46,7 +46,7 @@ export const campaignFields = [ }, }, default: '', - description: `The 'From name' of your campaign`, + description: `The 'From name' of your campaign.`, }, { displayName: 'From Email', @@ -63,7 +63,7 @@ export const campaignFields = [ }, }, default: '', - description: `The 'From email' of your campaign`, + description: `The 'From email' of your campaign.`, }, { displayName: 'Reply To', @@ -80,7 +80,7 @@ export const campaignFields = [ }, }, default: '', - description: `The 'Reply to' of your campaign`, + description: `The 'Reply to' of your campaign.`, }, { displayName: 'Title', @@ -97,7 +97,7 @@ export const campaignFields = [ }, }, default: '', - description: `The 'Title' of your campaign`, + description: `The 'Title' of your campaign.`, }, { displayName: 'Subject', @@ -114,7 +114,7 @@ export const campaignFields = [ }, }, default: '', - description: `The 'Subject' of your campaign`, + description: `The 'Subject' of your campaign.`, }, { displayName: 'HTML Text', @@ -131,6 +131,7 @@ export const campaignFields = [ }, }, default: '', + description: `The 'HTML version' of your campaign.`, }, { displayName: 'Send Campaign', @@ -149,6 +150,26 @@ export const campaignFields = [ default: false, description: `Set to true if you want to send the campaign as well and not just create a draft. Default is false.`, }, + { + displayName: 'Brand ID', + name: 'brandId', + type: 'string', + displayOptions: { + show: { + operation: [ + 'create', + ], + resource: [ + 'campaign', + ], + sendCampaign: [ + false, + ], + }, + }, + required: true, + default: '', + }, { displayName: 'Additional Fields', name: 'additionalFields', @@ -166,19 +187,6 @@ export const campaignFields = [ }, }, options: [ - { - displayName: 'Brand ID', - name: 'brandId', - type: 'string', - displayOptions: { - show: { - '/sendCampaign': [ - false, - ], - }, - }, - default: '', - }, { displayName: 'Exclude List IDs', name: 'excludeListIds', @@ -198,21 +206,21 @@ export const campaignFields = [ name: 'listIds', type: 'string', default: '', - description: `List IDs should be single or comma-separated`, + description: `List IDs should be single or comma-separated.`, }, { displayName: 'Plain Text', name: 'plainText', type: 'string', default: '', - description: `The 'Plain text version' of your campaign` + description: `The 'Plain text version' of your campaign.` }, { displayName: 'Querystring', name: 'queryString', type: 'string', default: '', - description: `Google Analytics tags`, + description: `Google Analytics tags.`, }, { displayName: 'Segment IDs', diff --git a/packages/nodes-base/nodes/Sendy/Sendy.node.ts b/packages/nodes-base/nodes/Sendy/Sendy.node.ts index 87e0dd193..d234ffd9f 100644 --- a/packages/nodes-base/nodes/Sendy/Sendy.node.ts +++ b/packages/nodes-base/nodes/Sendy/Sendy.node.ts @@ -104,7 +104,7 @@ export class Sendy implements INodeType { reply_to: replyTo, title, subject, - send_campaign: sendCampaign, + send_campaign: sendCampaign ? 1 : 0, html_text: htmlText, }; @@ -137,11 +137,11 @@ export class Sendy implements INodeType { } if (additionalFields.trackOpens) { - body.track_opens = additionalFields.trackOpens as boolean; + body.track_opens = additionalFields.trackOpens as boolean ? 1 : 0; } if (additionalFields.trackClicks) { - body.track_clicks = additionalFields.trackClicks as boolean; + body.track_clicks = additionalFields.trackClicks as boolean ? 1 : 0; } responseData = await sendyApiRequest.call( diff --git a/packages/nodes-base/nodes/Sendy/SubscriberDescription.ts b/packages/nodes-base/nodes/Sendy/SubscriberDescription.ts index ce391ea96..48771dcad 100644 --- a/packages/nodes-base/nodes/Sendy/SubscriberDescription.ts +++ b/packages/nodes-base/nodes/Sendy/SubscriberDescription.ts @@ -111,7 +111,7 @@ export const subscriberFields = [ description: `User's 2 letter country code`, }, { - displayName: 'GDRP', + displayName: 'GDPR', name: 'gdpr', type: 'boolean', default: false, diff --git a/packages/nodes-base/nodes/Sendy/sendy.png b/packages/nodes-base/nodes/Sendy/sendy.png index f9c01b585c1d6ea13081c4dbc31fe71afcce27d0..d49af7b834b83690cc4113f25a5c30c85393bef6 100644 GIT binary patch literal 1771 zcmV;P)DWe!LYEf(9qD9mX_)1>8PlvqN1X&udn6h<-^0not>TC z-QB3DsGOXfzP`SnpP#q4x2>(Mr>Cd1w6wy)!l|jLy1Kf)zP`7&x2meD4-XFv3=9(! z6951J2nYxm7#IZw1^@s56%`d48X71lC^IuN92^`aB_%L0Fd!fx9v&XU!^4=En6k36 zDk>@>A|mGI=HlYw(9qEC?(X2=;M3F7EG#VC+}zmM*oTLQ>+9<-E-v`^_}<>$adB}@ zPEPgp_4D)djEszggoHIUHI9ysFMd(+S z%9@&*mzS4;fq{8>d2DQKR#sL$Jw5R7@aX91ySuxuudk`8sfme+YHDgvPfs~HIpyW$ z*4Ea|&CSNf#0NJT|Oy}iA-xVWLAp^J-)etv#-c6MiHXIooaMn*=?dCJuQ002aEQchC<{swr3 ze?=ef!lR#*wXy)zr<$z`(Jvt8i&eIW8Ob_3!WN>gnX--`m^T z&CJQUw6Cw4jb2X`Aj&UJliTpKvI)vv9*a?funRU5Dr1wsgZg8Tzc`gaD19jRa!)5$YN1BCWA_yXHEV`v?m^WNibLyK7cf?>7nqp zP>eOmrKdc1eIm|?M69`ky=b3G?9SkY7s) zw42&I5r5Z5iUj^Vx?PVCc2`kY{o)UJl4eJ@@-(3JG*VK7rXmd<4Yxhtp~r<|X$!@O zzHU&GChLnx>Gv8MXYrKZ69vqI-8c1kQO{T<6L?lwXS$)}hn@wV57K^5lp#!Qy)PE( z@rJWwlLRKeN9N{dML##v<73fDfytM#@pT4$%X^zl6l0ggRPpBFuXSha$c-^&72`V! za^OYj@c}U!qfhUen~Q(0xp|_+EY_H>H(hAR)%COyQH)GZmos}7_|((D3a5eFg2dp~ z-qX3y&m$A*&jiEl?C}Xb$R3^uW73h%EHvcqKvTv68Zc-r4TEK7W9HJvJb3Y$rlgI5 zMxe7-ytSWAC5eghUq)}nfWRvmWod56( zj8%OSVHmiUMk#T&HYX3j7oKx=vTE84Jex{UdBT`nF6PeNkqdps$1^rY7^M`8i!ow( zU0v08@{r;8EnaR68iSuYZ1AI?6g`lpTa0~)eQOQ#YVB=furKkrI@;FXA8oBjybmV# ztv1ZNV+*btgO7tE@tU~2Vv*sGDmb>faK-)``&TTyw|1l9fB*Z-z5+4}@6_@*`Sbt) N002ovPDHLkV1gRckX!%& literal 7326 zcmaiZ1zgkJ7xzX>DnpPSAOaGjh0%_#k`0hRBWHgGS62xBz|EiJ%J+?WJF2&4w!Uy$HF03ZW^@YfgsPzN&pHP!

=%OmdVcGPa?{fK zOO%V}Z@X|7LNGRN5Fr6U2nq%HFHTRi9^!8$|C7_xz}F1{(L;E;dU@C(aO52S1%yUA z{6BCme)*-sf3e~G{r}hdFQ4E{mc~(QX+hOoJkd5Tb_g{^S=@vG5@`<=6%>~cQGf}< zB*c`2gp`CN1Qiq|gd}0gViL+C!jhuWkbklM?Z)4*iU<#+H^N@o!xi<*-)=S@o`?(E zW!V2T{-4TR=<~~aP~^Y$fhh~!7E-*WjMGQ)zxDYS>)-nPjco5~=Y>MJpnqFxkF)d- zWC_9lh5QfJzmflR!#_;@6}Nwc)1Q9$x6t4275QK8Rs5UvA3`qz01Ed&;ta95h-O(K zX~@6k{y~phDk#hYVS{${FmQEsmi-@f;g?bW7sGEXX~;#|{3DJ2$kAW3xFnS&#c}?b z@Uo=iOuV={L5K6Tf&m6NnCTN|XgJj~)S^!Vyh?Lb`3jA}Hj(qQsGd2oD-^oap`6}! zfp+BVJzWn(?@t<6pV_=2{hBaMxXo;!NKED}k8pT>9C*L~)cmXYP8PlV*<4oU%;|Q^ z*PBBo{+~VGXYrlVjegr(J{XcYHV>>ZUg_g6Q#~1`W7##GJnx6K4XAq?lJsb1LF-&r zdK1IV1&p3yrw+P6@aK2$qXRr67n zEq)ZA=UPs|!6SDk42=eP;k{|JgxX)Xs@iB%hOBBGN49hBpCH$oeGiJ6-Mg+pVmI&U zzt0dVu)z-J0Sqp+s+~XZG-vXG*J8cq1CQea4+d}LeB1Ab(Dj1Gf21oS?&aw?szEl< zXGQqZ3xsft#vMpM=&VhAfbZp4W{E?7CzV{lBilEIIe}kisPyVH?J;HK_eLg))#C(G z81K>L>ZWs|4#QQ{W615<#`g6s%wI`=C#5J-OTIA?&miWcrsg(wFeE4Evd|vZde!7;3 zRKt9WA9y@_p{|%`&ChnfujkCyZdEpEU)B`~yV|HU|6mnw^@TrPG}@Nb7C~S$DrcQ#l5k7fH>RzL8HAxCn%B*@OF!u|Wbv;E55hpY|;J zTzJ~hjY2lk+OdiZ8kBA|xxA^VY0OT`vE^P2ZzZ?Oi+49Z2R-7VA*Nt3U=p@h{T>p* zTMn>n(SdX zadQA0zDcj5IFzKk8xZD#bqv+}WO4jzCC)^|Z@cDg<)r@2`ntM2&9WtB?yrlHth7VY z2Lmsb7@eyX+;_{8s z_K9?r2SzykPWnnueF&C1J8gf7|J6smJ2XD5g4XgicZagOS!DbOuJMqNQ(0jY>-s;h zAgus6ti)hGd^9e;A_X|JhWR7XX+!nN<(*=;(swd`WB#6 ztFmlBicGzhLlCr?EXK@ISX!q9&(~E)c+5LLl=<2#s&D_)wbl1VICwBay^cCw*w;^Y zqrT4r&3%^0ziO8LZj21?iwX530`215%%hDlF8|Ha5@Eu9&CZ)<$f8tJnkt6X&-%6T z5)x5A$$K@zQ*LH?k;H{f_D9v@;_1ipPd@W!H0*79LHm)JXABn!Rdzgc zH%A|3cKObCeb16U27r#}jklx#dE~@I?`;i@eSlKO?ZgJpbq9|P!Rfi%*_K4lUdUA3 zlJUw)9rHerCq@IA(93V~c%cPS;?`v1rEoKqt<2}`mvg5HEZyD^!bBBa6sy?-nDMU3 zN_}~4N7936JN+VME++UY z9x$4xn5nj7W@h%XZqk%D;v00UJXtFXDrV;YxlSZJM10Ws$hGb4E4lAb{ltpiG2O!& z|C-u4^q5v852h}v(sD#bUzAFxmOVa`D+y1BEafoz>5W0&4`brrjOt5-ExcLh585$7 zlUG000L`i|eP9XLee+Yt<|&U<9exCo{Fp(+K{L5$Bm8!H&5VwfRgPA+v}6;mUI+`t zxtr5F>UZnGo>P!bNk(RSthQ|F-=EkdCqfA%7jOs>XN@p3Ruew0M&YW}a`n}xHJ@@H zy<${P7>CQ99Ugr^z529g`nt|(K-_Wt2?}R|$L}mQ@)=(ia4yO$ zxQ3{_Y|vOTcPwz4&D5&R!ce(Br!V3Q4KTkESw$O^$BXd(f+bb0YWd0#WN+$G>!dZF z%im35>X8Ya6T&z1rsot}=`Q@d6boS~ukqzOXbT$;-Ns3$JrsY!XrAgtCIW=Ttazsg zaSJR{qy+AGucxATEQ~%311*LxeHu<&IZvsiGr=%|ZLyzEPRp?D{R{fX8 ztu+OM+a5cur!L-~>!x~)IlnpObtT%>k7-LGW(yHkfk%epMGDif{85Qe9sVk@6unue zAA0R0z_SbND;A}8`QSNRwAnC<+wzLrH3{W1wUd-GEjzDg`FtrVI(7_6+1wPRed)i` zLf2?4ofigjDfLX!d|In1HIu*EGK%Zxp6q<+;(quj8pNgSyf{t~o~c7nY^tPe zJr;exr`EXC+0Qlfrl+HMdYVQ0TI!F0ht6nl@0X^X);va(_HH}T()C|T-G^69mva$yr*`D6xILz&l? zDf*TV?-HY(mxvp4L5+DFml&wMcDZaA(bMW#czfKNDrwcdB3h+(i%A*+8)XxVZttzU ztV*(wxl}@`ogeX@d4@FfI2BuyeY@jjweFGEblhj_+*7=al{!0060s?&DdVlYs6oNLMJLw4!^D#MwxAHO z9K8%~P`RM+bveK@l zeJt#T*f_$2aijT;g(-X{xBA8(sMqDHUyrb!NJtvEJ&Zqmvo;zh-huXwFU7d#g@4q^ zh(%`S_9cUZ1>*u6IF7m7S4+Y!3$)xH6lggd-A*;KjDCy<(_0>lZ8i<8gN}8?&JfS_ z%BQW4MhHyC%4(NtIGhXRkRZwK()WIv`!3eD&!G)QRp`Hm}RKq79RMuk}K zCb^PMhverXu6D+-?G7@?fTiC?k+Ik9^qa4w5t!!Cy_{NR_(WvW|Kca8N%CMNTR_DqF=>{N^ z7+1SBrO6Q1*L+AyQ_BIqel`TbkJ$3+biHw#P=vy^mE+6&mBPbTQ|3S{8TZBZoTy-S zQ);4=qeUiFL?c>-^1~YdAC?Z(5_JMf36tH4-hZ8*eD$d1Kt25V$Q}(Kook>~(Up2> zA*y5>)aG>d2>3vNzda;vv2y?)5*Ko70igH319gTt?XJpd26Rj#DpX$63e^&w}5pOuuz|Qan|Wx?;F9Gl74z%mmY3Mng4AkzV^U zSZ!-m_%l)bLhRs+0#zAfdB*l<`BGt=As*)L>nWxEoGDTSM5fr+84O2(8q!+QYkj;` zaR_;SdhTdh+*$D6A=1T#lBF|}it2vtg!(JtK4XY$79YVV-__4JJT-3IYUb+WHmqO`&`DzJWCK+>V*Q5|h!Ie){@O*dDhF=E z8==A5mDfLPeGJ6ACS(@oE?TT?8WsJ{LdC^lMf;jMBc02TAHI%6O7XyZqnwOxQ4=zn zgAn4{!x`M}6hhpL-ew@a+r`=*ETFZk#5E-aN179(oSHW26zCq6)jTfY!prykzQBVp zFo_VVZ6&8ZCcjDWUSeUk7?$sE$|GjMfP*Gx)G(CI ziEjq%XI3U7ndY)MF)1f2>MTt2Qv`xe8L@y>-;CvRZJvW#O@Fa)K={i$-c3QbcUQXU zh*h8h@$#fONy1rc!_)z({gW{R$k?Q6&LRsw#+n+fP6^h64s6fZcdOk$|k=@_jDVXv=uF1DDjC#2FN{)*X>u zviceCs;^w(ZFhb-C{ET|ZmwS}z`+FD=E0rn+`Zd@#ENnW*SxSGc=F@Um^%zEEJ%Mu z*3QN~C}xSL*E%q)vUe@6dqLjSB8w61%)S>+RB!8v+{{sv$xw`2RF2XD0ejYTf z%&#LGsvL(|u{O>+-!>O<_rHf(kb9JOo{9H1#B=yC`ca@2nobA~e-G+zg*bwPQDsxNIBG~njQvei0?EWCCAxVxgCyP>;Rnp+`Luiv8>Uac zv6o_O_U(X79K(&x=$Jm^qK>f5MYvmsQ!uF63awYPd-%!wYY(HVn<~pwacB(#Ax$86#)kjg z_K$<1hg@AAImx1yrMsdH*Bl0De~yQfV_a)Tl!d|$KWi}A${Y-c)YzV{B*T}OK|tCa zBJg{gjK#wdG`YgYYsHrg>w5afv-hgD+HG+`%iGmwv>;eWdfPLJ;p+=BsrL&m+6g?( z0b?q`K$^P@B(@)4#z&s#?9*&5GTH4h*?T6Sao6##28u@a(RHtc4HQ}Zj5c1?VHQDr z4T&6`=frvp>5~=*-gkC>WeHaCD;H-=OlibrX+loxuCb-+NC;_y^nUL(?Qssxv+}oX zN%#qfm+4CsfStz}RRTM7NCds(`H%0we9JX`I`Nn_mF{tcCt45mEUd4v;B!w|JqX07 zppyHs%Pf3OBSb;>0g-NjcP--bfEr1MOf&~W$X*3w4T%q-1ooWYjgJg2uhQBCIFyYR$&jjMCNK0sbIX}tiaORHl@47cWPK;K??(z`g)bzkutXcN z2LbgN--8x;en2>zpN8^Lw*zD5tzMe;bQ%uL=xbBG2Jg%&lD#$Q3A(>1L}Tx`D0vn_ zj^{h5g%>^~KWmQ(4bcTG?_H9?0}>NrK-fBF^ z$c-w@7!zLc8FUP-t8<(ToYrR5^9_C*PtGIw9z4Ey5H@NSa;I3)`<3(3<@QFR;Oi-F z`EedA69T-h4C{4{gF|P}M~b{ABcasL{6B6vv72T!S}YxZO0+rydILm->N~13TqqyOK^`Lwalt{}{)zVRbS@Iv_q2e$ zgjjP}g;r;YNC8a>8TwQO5s#?w?7CqJbR}P`Fukt;9YN|C^Uz; ztfE89bhxgMjKTW3RZ94}Aje*7qQd7dsG2MrA-c5cLvSVN z2DdUS=VEaTneNSF$s#xDzuv%SDk)3G{LOZ)zeCZ zvfj((U0t=rd#0pttDOz}l6>9m2{JKPL#M~hYBz5?CCy?=*QGPh{qaY-GB;^8zwUuf z<$4;&y%)3_6Wp%8dT(j`(=jQi=bW$BbUcXZb=`tOY8(n8YhO5zCtEW>s?AmpDhm>z zH)%TKOF7PSB}hL6wejA9aqs669n#;Sil1kDW@FQ14+@P6d!$38p+8u3+-nJ5kHIr1^hr}f%NZ(m&Q&c&X&(a zSy#WEiS`H%2qpm@6FGe=1{BE;6J-ow%!e20ufc6adh;m&kJwtbAD9xFbF{^cIioY> zpOT=SOC4twA@GPCs2??9^J6z@CO)8{a*8U^uXwSP%K^&DwdxAZTnVHz<{rjfTs8zs zT()>pR&g8LK)@-BZ5l`+`&gYxyT*h-a0Eyqci+`|z8EYGBSzXCR`f@XzO-Z&gkNWSn5{CJ+zE&t(&g&KxDQXT(Dfo&dZ zE786r17L^POjnEBob5Mx_kq67`R`~fW^GPiHQ^cbz{dyCYk|qg>ah1lqt7IOZsn5{ z-$&EcyI8ZIzi7PXz*ie385DlYjYnB|Ac#x8I_i4Df?<&SW9Y29HFqq2jbG~vy~_gJ zt(xPl>+BRc7@M?BqIrZCFF{;*%_XVDFpzCcA?Q@$l%kE#&Ui7Uxuq3f5I)r7z6bz%IEi2vUnyD*}~H2 zGw~r7&P`WS{NJTgC9lU(OLQKE`7iL8mn-@%sqevk?6*ftRZ^F_+tjQ{m#g`j33qJ# zXkU{N_Vw?lsF^m*RaxxA1xM|5CSmXp>>83tSZ`Z>>U`85}e3=Dtad0tUMId{4trkpJOtnK6$GUG6a ziY2ey#2ryd>of?B&EhKfaK?LMFBUSp%GNLa0bIbl!HR$5stfGdn2sHJolj!QYd^`7 mJZevWvD`8rlbYF|c+r