feat(core): Node hints improvements (no-changelog) (#9387)

Co-authored-by: Giulio Andreini <andreini@netseven.it>

packages/nodes-base/nodes/Postgres/v2/actions/router.ts

@@ -1,5 +1,5 @@
 import type { IExecuteFunctions, INodeExecutionData } from 'n8n-workflow';
-import { NodeOperationError } from 'n8n-workflow';
+import { NodeExecutionOutput, NodeOperationError } from 'n8n-workflow';
 
 import { configurePostgres } from '../transport';
 import { configureQueryRunner } from '../helpers/utils';
@@ -17,7 +17,8 @@ export async function router(this: IExecuteFunctions): Promise<INodeExecutionDat
 
 	const credentials = (await this.getCredentials('postgres')) as PostgresNodeCredentials;
 	const options = this.getNodeParameter('options', 0, {}) as PostgresNodeOptions;
-	options.nodeVersion = this.getNode().typeVersion;
+	const node = this.getNode();
+	options.nodeVersion = node.typeVersion;
 	options.operation = operation;
 
 	const { db, pgp, sshClient } = await configurePostgres(credentials, options);
@@ -62,5 +63,17 @@ export async function router(this: IExecuteFunctions): Promise<INodeExecutionDat
 		if (!db.$pool.ending) await db.$pool.end();
 	}
 
+	if (operation === 'select' && items.length > 1 && !node.executeOnce) {
+		return new NodeExecutionOutput(
+			[returnData],
+			[
+				{
+					message: `This node ran ${items.length} times, once for each input item. To run for the first item only, enable 'execute once' in the node settings`,
+					location: 'outputPane',
+				},
+			],
+		);
+	}
+
 	return [returnData];
 }

packages/nodes-base/nodes/Transform/SplitOut/SplitOut.node.ts

@@ -1,14 +1,14 @@
 import get from 'lodash/get';
 import unset from 'lodash/unset';
-import {
-	type IBinaryData,
-	NodeOperationError,
-	deepCopy,
-	type IDataObject,
-	type IExecuteFunctions,
-	type INodeExecutionData,
-	type INodeType,
-	type INodeTypeDescription,
+import { NodeOperationError, deepCopy, NodeExecutionOutput } from 'n8n-workflow';
+import type {
+	IBinaryData,
+	IDataObject,
+	IExecuteFunctions,
+	INodeExecutionData,
+	INodeType,
+	INodeTypeDescription,
+	NodeExecutionHint,
 } from 'n8n-workflow';
 import { prepareFieldsArray } from '../utils/utils';
 
@@ -111,6 +111,7 @@ export class SplitOut implements INodeType {
 	async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
 		const returnData: INodeExecutionData[] = [];
 		const items = this.getInputData();
+		const notFoundedFields: { [key: string]: boolean[] } = {};
 
 		for (let i = 0; i < items.length; i++) {
 			const fieldsToSplitOut = (this.getNodeParameter('fieldToSplitOut', i) as string)
@@ -160,6 +161,14 @@ export class SplitOut implements INodeType {
 
 					if (entityToSplit === undefined) {
 						entityToSplit = [];
+						if (!notFoundedFields[fieldToSplitOut]) {
+							notFoundedFields[fieldToSplitOut] = [];
+						}
+						notFoundedFields[fieldToSplitOut].push(false);
+					} else {
+						if (notFoundedFields[fieldToSplitOut]) {
+							notFoundedFields[fieldToSplitOut].push(true);
+						}
 					}
 
 					if (typeof entityToSplit !== 'object' || entityToSplit === null) {
@@ -254,6 +263,21 @@ export class SplitOut implements INodeType {
 			}
 		}
 
+		if (Object.keys(notFoundedFields).length) {
+			const hints: NodeExecutionHint[] = [];
+
+			for (const [field, values] of Object.entries(notFoundedFields)) {
+				if (values.every((value) => !value)) {
+					hints.push({
+						message: `The field '${field}' wasn't found in any input item`,
+						location: 'outputPane',
+					});
+				}
+			}
+
+			if (hints.length) return new NodeExecutionOutput([returnData], hints);
+		}
+
 		return [returnData];
 	}
 }