refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)

*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
This commit is contained in:
Iván Ovejero
2022-06-20 16:54:01 +02:00
committed by GitHub
parent 3c3b18095a
commit 88dea330b9
552 changed files with 2188 additions and 1367 deletions

View File

@@ -109,6 +109,7 @@ export function getAccountFields(): INodeProperties[] {
displayName: 'Account Rating Name or ID',
name: 'accountratingcode',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getAccountRatingCodes',
},
@@ -132,6 +133,7 @@ export function getAccountFields(): INodeProperties[] {
displayName: 'Address Type Name or ID',
name: 'addresstypecode',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getAddressTypes',
},
@@ -227,6 +229,7 @@ export function getAccountFields(): INodeProperties[] {
displayName: 'Customer Size Name or ID',
name: 'customersizecode',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getCustomerSizeCodes',
},
@@ -236,6 +239,7 @@ export function getAccountFields(): INodeProperties[] {
displayName: 'Customer Type Name or ID',
name: 'customertypecode',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getCustomerTypeCodes',
},

View File

@@ -172,7 +172,7 @@ export const accountFields: INodeProperties[] = [
},
options: [
{
displayName: 'Return Fields',
displayName: 'Return Field Names or IDs',
name: 'returnFields',
type: 'multiOptions',
typeOptions: {
@@ -181,7 +181,7 @@ export const accountFields: INodeProperties[] = [
default: [],
},
{
displayName: 'Expand Fields',
displayName: 'Expand Field Names or IDs',
name: 'expandFields',
type: 'multiOptions',
typeOptions: {
@@ -260,14 +260,14 @@ export const accountFields: INodeProperties[] = [
},
options: [
{
displayName: 'Return Fields',
displayName: 'Return Field Names or IDs',
name: 'returnFields',
type: 'multiOptions',
typeOptions: {
loadOptionsMethod: 'getAccountFields',
},
default: [],
description: 'Fields the response will include',
description: 'Fields the response will include. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
],
},

View File

@@ -48,6 +48,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
},
@@ -67,6 +68,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Worksheet Name or ID',
name: 'worksheet',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getworksheets',
@@ -90,6 +92,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Table Name or ID',
name: 'table',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getTables',
@@ -145,6 +148,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
},
@@ -164,6 +168,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Worksheet Name or ID',
name: 'worksheet',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getworksheets',
@@ -187,6 +192,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Table Name or ID',
name: 'table',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getTables',
@@ -262,7 +268,7 @@ export const tableFields: INodeProperties[] = [
},
},
default: false,
description: 'If the data should be returned RAW instead of parsed into keys according to their header',
description: 'Whether the data should be returned RAW instead of parsed into keys according to their header',
},
{
displayName: 'Data Property',
@@ -320,6 +326,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
},
@@ -339,6 +346,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Worksheet Name or ID',
name: 'worksheet',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getworksheets',
@@ -362,6 +370,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Table Name or ID',
name: 'table',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getTables',
@@ -437,7 +446,7 @@ export const tableFields: INodeProperties[] = [
},
},
default: false,
description: 'If the data should be returned RAW instead of parsed into keys according to their header',
description: 'Whether the data should be returned RAW instead of parsed into keys according to their header',
},
{
displayName: 'Data Property',
@@ -495,6 +504,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
@@ -515,6 +525,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Worksheet Name or ID',
name: 'worksheet',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getworksheets',
@@ -538,6 +549,7 @@ export const tableFields: INodeProperties[] = [
displayName: 'Table Name or ID',
name: 'table',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getTables',
@@ -617,6 +629,7 @@ export const tableFields: INodeProperties[] = [
name: 'returnAllMatches',
type: 'boolean',
default: false,
// eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether
description: 'By default only the first result gets returned. If options gets set all found matches get returned.',
},
],

View File

@@ -38,6 +38,7 @@ export const workbookFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getWorkbooks',

View File

@@ -38,6 +38,7 @@ export const worksheetFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
},
@@ -127,6 +128,7 @@ export const worksheetFields: INodeProperties[] = [
displayName: 'Workbook Name or ID',
name: 'workbook',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getWorkbooks',
@@ -147,6 +149,7 @@ export const worksheetFields: INodeProperties[] = [
displayName: 'Worksheet Name or ID',
name: 'worksheet',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
required: true,
typeOptions: {
loadOptionsMethod: 'getworksheets',
@@ -199,7 +202,7 @@ export const worksheetFields: INodeProperties[] = [
},
},
default: false,
description: 'If the data should be returned RAW instead of parsed into keys according to their header',
description: 'Whether the data should be returned RAW instead of parsed into keys according to their header',
},
{
displayName: 'Data Property',

View File

@@ -449,7 +449,7 @@ export const fileFields: INodeProperties[] = [
],
},
},
description: 'If the data to upload should be taken from binary field',
description: 'Whether the data to upload should be taken from binary field',
},
{
displayName: 'File Content',

View File

@@ -171,7 +171,7 @@ export const draftFields: INodeProperties[] = [
default: 'html',
},
{
displayName: 'Categories',
displayName: 'Category Names or IDs',
name: 'categories',
type: 'multiOptions',
typeOptions: {
@@ -249,7 +249,7 @@ export const draftFields: INodeProperties[] = [
{
displayName: 'Read Receipt Requested',
name: 'isReadReceiptRequested',
description: 'Indicates whether a read receipt is requested for the message',
description: 'Whether a read receipt is requested for the message',
type: 'boolean',
default: false,
},

View File

@@ -100,7 +100,7 @@ export const draftMessageSharedFields: INodeProperties[] = [
default: 'html',
},
{
displayName: 'Categories',
displayName: 'Category Names or IDs',
name: 'categories',
type: 'multiOptions',
typeOptions: {
@@ -178,14 +178,14 @@ export const draftMessageSharedFields: INodeProperties[] = [
{
displayName: 'Is Read',
name: 'isRead',
description: 'Indicates whether the message has been read',
description: 'Whether the message has been read',
type: 'boolean',
default: false,
},
{
displayName: 'Read Receipt Requested',
name: 'isReadReceiptRequested',
description: 'Indicates whether a read receipt is requested for the message',
description: 'Whether a read receipt is requested for the message',
type: 'boolean',
default: false,
},

View File

@@ -158,7 +158,7 @@ export const folderFields: INodeProperties[] = [
{
displayName: 'Include Nested Folders',
name: 'includeNestedFolders',
description: 'Include child folders in the search',
description: 'Whether to include child folders in the search',
type: 'boolean',
default: false,
displayOptions: {
@@ -290,7 +290,7 @@ export const folderFields: INodeProperties[] = [
{
displayName: 'Include Nested Folders',
name: 'includeNestedFolders',
description: 'Include child folders in the search. Only for search folders.',
description: 'Whether to include child folders in the search. Only for search folders.',
type: 'boolean',
default: false,
},

View File

@@ -135,7 +135,7 @@ export const messageFields: INodeProperties[] = [
{
displayName: 'Send',
name: 'send',
description: 'Send the reply message directly. If not set, it will be saved as draft.',
description: 'Whether to send the reply message directly. If not set, it will be saved as draft.',
displayOptions: {
show: {
resource: [
@@ -296,7 +296,7 @@ export const messageFields: INodeProperties[] = [
{
displayName: 'Read Receipt Requested',
name: 'isReadReceiptRequested',
description: 'Indicates whether a read receipt is requested for the message',
description: 'Whether a read receipt is requested for the message',
type: 'boolean',
default: false,
},
@@ -490,7 +490,7 @@ export const messageFields: INodeProperties[] = [
default: 'html',
},
{
displayName: 'Categories',
displayName: 'Category Names or IDs',
name: 'categories',
type: 'multiOptions',
typeOptions: {
@@ -568,7 +568,7 @@ export const messageFields: INodeProperties[] = [
{
displayName: 'Read Receipt Requested',
name: 'isReadReceiptRequested',
description: 'Indicates whether a read receipt is requested for the message',
description: 'Whether a read receipt is requested for the message',
type: 'boolean',
default: false,
},
@@ -589,7 +589,7 @@ export const messageFields: INodeProperties[] = [
{
displayName: 'Save To Sent Items',
name: 'saveToSentItems',
description: 'Indicates whether to save the message in Sent Items',
description: 'Whether to save the message in Sent Items',
type: 'boolean',
default: true,
},

View File

@@ -56,6 +56,7 @@ export const channelFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -144,6 +145,7 @@ export const channelFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -163,6 +165,7 @@ export const channelFields: INodeProperties[] = [
displayName: 'Channel Name or ID',
name: 'channelId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChannels',
loadOptionsDependsOn: [
@@ -190,6 +193,7 @@ export const channelFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -209,6 +213,7 @@ export const channelFields: INodeProperties[] = [
displayName: 'Channel Name or ID',
name: 'channelId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChannels',
loadOptionsDependsOn: [
@@ -236,6 +241,7 @@ export const channelFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -301,6 +307,7 @@ export const channelFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -320,6 +327,7 @@ export const channelFields: INodeProperties[] = [
displayName: 'Channel Name or ID',
name: 'channelId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChannels',
loadOptionsDependsOn: [

View File

@@ -41,6 +41,7 @@ export const channelMessageFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -60,6 +61,7 @@ export const channelMessageFields: INodeProperties[] = [
displayName: 'Channel Name or ID',
name: 'channelId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChannels',
loadOptionsDependsOn: [
@@ -161,6 +163,7 @@ export const channelMessageFields: INodeProperties[] = [
name: 'teamId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTeams',
},
@@ -180,6 +183,7 @@ export const channelMessageFields: INodeProperties[] = [
displayName: 'Channel Name or ID',
name: 'channelId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChannels',
loadOptionsDependsOn: [

View File

@@ -46,6 +46,7 @@ export const chatMessageFields: INodeProperties[] = [
name: 'chatId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChats',
},
@@ -140,6 +141,7 @@ export const chatMessageFields: INodeProperties[] = [
name: 'chatId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getChats',
},

View File

@@ -89,6 +89,7 @@ export const taskFields: INodeProperties[] = [
name: 'groupId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getGroups',
loadOptionsDependsOn: [
@@ -211,7 +212,7 @@ export const taskFields: INodeProperties[] = [
description: 'Date and time at which the task is due. The Timestamp type represents date and time information using ISO 8601 format and is always in UTC time.',
},
{
displayName: 'Labels',
displayName: 'Label Names or IDs',
name: 'labels',
type: 'multiOptions',
typeOptions: {
@@ -221,7 +222,7 @@ export const taskFields: INodeProperties[] = [
],
},
default: [],
description: 'Labels to assign to the task',
description: 'Labels to assign to the task. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Percent Complete',
@@ -317,6 +318,7 @@ export const taskFields: INodeProperties[] = [
name: 'groupId',
required: true,
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getGroups',
loadOptionsDependsOn: [
@@ -339,6 +341,7 @@ export const taskFields: INodeProperties[] = [
displayName: 'Member Name or ID',
name: 'memberId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getMembers',
loadOptionsDependsOn: [
@@ -364,6 +367,7 @@ export const taskFields: INodeProperties[] = [
displayName: 'Plan Name or ID',
name: 'planId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getPlans',
loadOptionsDependsOn: [
@@ -502,6 +506,7 @@ export const taskFields: INodeProperties[] = [
displayName: 'Group Name or ID',
name: 'groupId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getGroups',
loadOptionsDependsOn: [
@@ -511,7 +516,7 @@ export const taskFields: INodeProperties[] = [
default: '',
},
{
displayName: 'Labels',
displayName: 'Label Names or IDs',
name: 'labels',
type: 'multiOptions',
typeOptions: {
@@ -521,7 +526,7 @@ export const taskFields: INodeProperties[] = [
],
},
default: [],
description: 'Labels to assign to the task',
description: 'Labels to assign to the task. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Percent Complete',

View File

@@ -49,6 +49,7 @@ export const linkedResourceFields: INodeProperties[] = [
displayName: 'Task List Name or ID',
name: 'taskListId',
type: 'options',
description: 'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
typeOptions: {
loadOptionsMethod: 'getTaskLists',
},