🐛 Fix recommendation logic (#2543)
* fix: expect multiple answers for survey * chore: refactor survey input methods * fix error; fix tracking Co-authored-by: Mutasem <mutdmour@gmail.com>
This commit is contained in:
@@ -6,7 +6,17 @@ export function getPersonalizedNodeTypes(answers: IPersonalizationSurveyAnswers)
|
||||
const companySize = answers[COMPANY_SIZE_KEY];
|
||||
const workArea = answers[WORK_AREA_KEY];
|
||||
|
||||
if (companySize === null && workArea === null && answers[CODING_SKILL_KEY] === null) {
|
||||
function isWorkAreaAnswer(name: string) {
|
||||
if (Array.isArray(workArea)) {
|
||||
return workArea.includes(name);
|
||||
} else {
|
||||
return workArea === name;
|
||||
}
|
||||
}
|
||||
|
||||
const workAreaIsEmpty = workArea === null || workArea.length === 0;
|
||||
|
||||
if (companySize === null && workAreaIsEmpty && answers[CODING_SKILL_KEY] === null) {
|
||||
return [];
|
||||
}
|
||||
|
||||
@@ -17,7 +27,7 @@ export function getPersonalizedNodeTypes(answers: IPersonalizationSurveyAnswers)
|
||||
}
|
||||
|
||||
let nodeTypes = [] as string[];
|
||||
if (workArea === IT_ENGINEERING_WORK_AREA) {
|
||||
if (isWorkAreaAnswer(IT_ENGINEERING_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat(WEBHOOK_NODE_TYPE);
|
||||
}
|
||||
else {
|
||||
@@ -39,16 +49,16 @@ export function getPersonalizedNodeTypes(answers: IPersonalizationSurveyAnswers)
|
||||
}
|
||||
|
||||
if (companySize === COMPANY_SIZE_500_999 || companySize === COMPANY_SIZE_1000_OR_MORE) {
|
||||
if (workArea === SALES_BUSINESSDEV_WORK_AREA) {
|
||||
if (isWorkAreaAnswer(SALES_BUSINESSDEV_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat(SALESFORCE_NODE_TYPE);
|
||||
}
|
||||
else if (workArea === SECURITY_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(SECURITY_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([ELASTIC_SECURITY_NODE_TYPE, HTTP_REQUEST_NODE_TYPE]);
|
||||
}
|
||||
else if (workArea === PRODUCT_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(PRODUCT_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([JIRA_TRIGGER_NODE_TYPE, SEGMENT_NODE_TYPE]);
|
||||
}
|
||||
else if (workArea === IT_ENGINEERING_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(IT_ENGINEERING_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([GITHUB_TRIGGER_NODE_TYPE, HTTP_REQUEST_NODE_TYPE]);
|
||||
}
|
||||
else {
|
||||
@@ -56,19 +66,19 @@ export function getPersonalizedNodeTypes(answers: IPersonalizationSurveyAnswers)
|
||||
}
|
||||
}
|
||||
else {
|
||||
if (workArea === SALES_BUSINESSDEV_WORK_AREA) {
|
||||
if (isWorkAreaAnswer(SALES_BUSINESSDEV_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat(CLEARBIT_NODE_TYPE);
|
||||
}
|
||||
else if (workArea === SECURITY_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(SECURITY_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([PAGERDUTY_NODE_TYPE, HTTP_REQUEST_NODE_TYPE]);
|
||||
}
|
||||
else if (workArea === PRODUCT_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(PRODUCT_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([JIRA_TRIGGER_NODE_TYPE, CALENDLY_TRIGGER_NODE_TYPE]);
|
||||
}
|
||||
else if (workArea === IT_ENGINEERING_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(IT_ENGINEERING_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([EXECUTE_COMMAND_NODE_TYPE, HTTP_REQUEST_NODE_TYPE]);
|
||||
}
|
||||
else if (workArea === FINANCE_WORK_AREA) {
|
||||
else if (isWorkAreaAnswer(FINANCE_WORK_AREA)) {
|
||||
nodeTypes = nodeTypes.concat([XERO_NODE_TYPE, QUICKBOOKS_NODE_TYPE, SPREADSHEET_FILE_NODE_TYPE]);
|
||||
}
|
||||
else {
|
||||
|
||||
Reference in New Issue
Block a user