From 99e3eb634bd34fa6791e09f112ce9e49407fed49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Thu, 29 Dec 2022 14:57:20 +0100 Subject: [PATCH] ci: Fix linting on builds (no-changelog) (#5062) add exceptions for the no-interpolation-in-regular-string rule --- packages/nodes-base/nodes/CrateDb/CrateDb.node.ts | 1 + packages/nodes-base/nodes/Jira/JiraTrigger.node.ts | 1 + packages/nodes-base/nodes/Postgres/Postgres.node.functions.ts | 2 ++ packages/nodes-base/nodes/QuestDb/QuestDb.node.ts | 1 + 4 files changed, 5 insertions(+) diff --git a/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts b/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts index 37c8a9b55..44ea83ce9 100644 --- a/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts +++ b/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts @@ -351,6 +351,7 @@ export class CrateDb implements INodeType { const where = ' WHERE ' + updateKeys + // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string .map((updateKey) => pgp.as.name(updateKey) + ' = ${' + updateKey + '}') .join(' AND '); // updateKeyValue = item.json[updateKey] as string | number; diff --git a/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts b/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts index 9d597df4d..6fb94cc3b 100644 --- a/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts +++ b/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts @@ -439,6 +439,7 @@ export class JiraTrigger implements INodeType { if (additionalFields.includeFields) { for (const field of additionalFields.includeFields as string[]) { + // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string parameters[field] = '${' + field + '}'; } } diff --git a/packages/nodes-base/nodes/Postgres/Postgres.node.functions.ts b/packages/nodes-base/nodes/Postgres/Postgres.node.functions.ts index 308defe5b..615d547e8 100644 --- a/packages/nodes-base/nodes/Postgres/Postgres.node.functions.ts +++ b/packages/nodes-base/nodes/Postgres/Postgres.node.functions.ts @@ -504,6 +504,7 @@ export async function pgUpdate( } else { const where = ' WHERE ' + + // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string updateKeys.map((entry) => pgp.as.name(entry.name) + ' = ${' + entry.prop + '}').join(' AND '); if (mode === 'transaction') { return db.tx(async (t) => { @@ -625,6 +626,7 @@ export async function pgUpdateV2( } else { const where = ' WHERE ' + + // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string updateKeys.map((entry) => pgp.as.name(entry.name) + ' = ${' + entry.prop + '}').join(' AND '); if (mode === 'transaction') { return db.tx(async (t) => { diff --git a/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts b/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts index a633f56e4..b041a2b16 100644 --- a/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts +++ b/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts @@ -243,6 +243,7 @@ export class QuestDb implements INodeType { const returnFields = this.getNodeParameter('returnFields', 0) as string; const table = this.getNodeParameter('table', 0) as string; + // eslint-disable-next-line n8n-local-rules/no-interpolation-in-regular-string const insertData = await db.any('SELECT ${columns:name} from ${table:name}', { columns: returnFields .split(',')