fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/cli/src/ExternalSecrets/ExternalSecrets.controller.ee.ts

@@ -13,7 +13,7 @@ export class ExternalSecretsController {
 	@Get('/providers')
 	@RequireGlobalScope('externalSecretsProvider:list')
 	async getProviders() {
-		return this.secretsService.getProviders();
+		return await this.secretsService.getProviders();
 	}
 
 	@Get('/providers/:provider')

packages/cli/src/ExternalSecrets/ExternalSecrets.service.ee.ts

@@ -134,7 +134,7 @@ export class ExternalSecretsService {
 		}
 		const { settings } = providerAndSettings;
 		const newData = this.unredact(data, settings.settings);
-		return Container.get(ExternalSecretsManager).testProviderSettings(providerName, newData);
+		return await Container.get(ExternalSecretsManager).testProviderSettings(providerName, newData);
 	}
 
 	async updateProvider(providerName: string) {
@@ -143,6 +143,6 @@ export class ExternalSecretsService {
 		if (!providerAndSettings) {
 			throw new ExternalSecretsProviderNotFoundError(providerName);
 		}
-		return Container.get(ExternalSecretsManager).updateProvider(providerName);
+		return await Container.get(ExternalSecretsManager).updateProvider(providerName);
 	}
 }

packages/cli/src/ExternalSecrets/ExternalSecretsManager.ee.ts

@@ -48,10 +48,13 @@ export class ExternalSecretsManager {
 					this.initialized = true;
 					resolve();
 					this.initializingPromise = undefined;
-					this.updateInterval = setInterval(async () => this.updateSecrets(), updateIntervalTime());
+					this.updateInterval = setInterval(
+						async () => await this.updateSecrets(),
+						updateIntervalTime(),
+					);
 				});
 			}
-			return this.initializingPromise;
+			return await this.initializingPromise;
 		}
 	}
 
@@ -107,8 +110,8 @@ export class ExternalSecretsManager {
 		}
 		const providers: Array<SecretsProvider | null> = (
 			await Promise.allSettled(
-				Object.entries(settings).map(async ([name, providerSettings]) =>
-					this.initProvider(name, providerSettings),
+				Object.entries(settings).map(
+					async ([name, providerSettings]) => await this.initProvider(name, providerSettings),
 				),
 			)
 		).map((i) => (i.status === 'rejected' ? null : i.value));

packages/cli/src/ExternalSecrets/providers/vault.ts

@@ -436,7 +436,7 @@ export class VaultProvider extends SecretsProvider {
 				await Promise.allSettled(
 					listResp.data.data.keys.map(async (key): Promise<[string, IDataObject] | null> => {
 						if (key.endsWith('/')) {
-							return this.getKVSecrets(mountPath, kvVersion, path + key);
+							return await this.getKVSecrets(mountPath, kvVersion, path + key);
 						}
 						let secretPath = mountPath;
 						if (kvVersion === '2') {