fix(core): Remove circular refs from Code and push msg (#5741)

* remove circular refs from code items (and lint fixes)

* cleanup

---------

* add some tests

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Auerswald
2023-03-21 15:34:30 +01:00
committed by GitHub
parent 199a91b398
commit b6d8a0f985
6 changed files with 64 additions and 12 deletions

View File

@@ -1,4 +1,4 @@
import { LoggerProxy as Logger } from 'n8n-workflow';
import { jsonStringify, LoggerProxy as Logger } from 'n8n-workflow';
import type { IPushDataType } from '@/Interfaces';
import { eventBus } from '../eventbus';
@@ -38,7 +38,7 @@ export abstract class AbstractPush<T> {
Logger.debug(`Send data of type "${type}" to editor-UI`, { dataType: type, sessionId });
const sendData = JSON.stringify({ type, data });
const sendData = jsonStringify({ type, data }, { replaceCircularRefs: true });
if (sessionId === undefined) {
// Send to all connected clients

View File

@@ -135,7 +135,6 @@ export class SamlController {
private async handleInitSSO(res: express.Response) {
const result = this.samlService.getLoginRequestUrl();
if (result?.binding === 'redirect') {
// Return the redirect URL directly
return res.send(result.context.context);
} else if (result?.binding === 'post') {
return res.send(getInitSSOFormView(result.context as PostBindingContext));