refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) (#7471)

This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.

packages/cli/src/services/communityPackages.service.ts

@@ -6,7 +6,7 @@ import axios from 'axios';
 
 import { LoggerProxy as Logger } from 'n8n-workflow';
 import type { PublicInstalledPackage } from 'n8n-workflow';
-import { UserSettings } from 'n8n-core';
+import { InstanceSettings } from 'n8n-core';
 import type { PackageDirectoryLoader } from 'n8n-core';
 
 import { toError } from '@/utils';
@@ -47,6 +47,7 @@ export class CommunityPackagesService {
 	missingPackages: string[] = [];
 
 	constructor(
+		private readonly instanceSettings: InstanceSettings,
 		private readonly installedPackageRepository: InstalledPackagesRepository,
 		private readonly loadNodesAndCredentials: LoadNodesAndCredentials,
 	) {}
@@ -114,7 +115,7 @@ export class CommunityPackagesService {
 	}
 
 	async executeNpmCommand(command: string, options?: { doNotHandleError?: boolean }) {
-		const downloadFolder = UserSettings.getUserN8nFolderDownloadedNodesPath();
+		const downloadFolder = this.instanceSettings.nodesDownloadDir;
 
 		const execOptions = {
 			cwd: downloadFolder,

packages/cli/src/services/frontend.service.ts

@@ -10,6 +10,7 @@ import type {
 	INodeTypeBaseDescription,
 	ITelemetrySettings,
 } from 'n8n-workflow';
+import { InstanceSettings } from 'n8n-core';
 
 import { GENERATED_STATIC_DIR, LICENSE_FEATURES } from '@/constants';
 import { CredentialsOverwrites } from '@/CredentialsOverwrites';
@@ -40,6 +41,7 @@ export class FrontendService {
 		private readonly credentialsOverwrites: CredentialsOverwrites,
 		private readonly license: License,
 		private readonly mailer: UserManagementMailer,
+		private readonly instanceSettings: InstanceSettings,
 	) {
 		this.initSettings();
 	}
@@ -87,7 +89,7 @@ export class FrontendService {
 				endpoint: config.getEnv('versionNotifications.endpoint'),
 				infoUrl: config.getEnv('versionNotifications.infoUrl'),
 			},
-			instanceId: '',
+			instanceId: this.instanceSettings.instanceId,
 			telemetry: telemetrySettings,
 			posthog: {
 				enabled: config.getEnv('diagnostics.enabled'),

packages/cli/src/services/orchestration/worker/types.ts

@@ -3,7 +3,6 @@ import type { RedisServicePubSubPublisher } from '../../redis/RedisServicePubSub
 
 export interface WorkerCommandReceivedHandlerOptions {
 	queueModeId: string;
-	instanceId: string;
 	redisPublisher: RedisServicePubSubPublisher;
 	getRunningJobIds: () => string[];
 	getRunningJobsSummary: () => WorkerJobStatusSummary[];