perf: Improve workflows list performance (#5021)
* spike: Improve workflow list performance * fix: Correcting override behavior * refactor: Remove unnecessary promise * remove duplicate code * remove the `async` that is breaking the listings page Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
@@ -89,7 +89,9 @@ export class EEWorkflowsService extends WorkflowsService {
|
||||
static addOwnerAndSharings(workflow: WorkflowWithSharingsAndCredentials): void {
|
||||
workflow.ownedBy = null;
|
||||
workflow.sharedWith = [];
|
||||
workflow.usedCredentials = [];
|
||||
if (!workflow.usedCredentials) {
|
||||
workflow.usedCredentials = [];
|
||||
}
|
||||
|
||||
workflow.shared?.forEach(({ user, role }) => {
|
||||
const { id, email, firstName, lastName } = user;
|
||||
@@ -154,6 +156,71 @@ export class EEWorkflowsService extends WorkflowsService {
|
||||
});
|
||||
}
|
||||
|
||||
static async addCredentialsToWorkflows(
|
||||
workflows: WorkflowWithSharingsAndCredentials[],
|
||||
currentUser: User,
|
||||
): Promise<void> {
|
||||
// Create 2 maps: one with all the credential ids used by all workflows
|
||||
// And another to match back workflow <> credentials
|
||||
const allUsedCredentialIds = new Set<string>();
|
||||
const mapsWorkflowsToUsedCredentials: string[][] = [];
|
||||
workflows.forEach((workflow, idx) => {
|
||||
workflow.nodes.forEach((node) => {
|
||||
if (!node.credentials) {
|
||||
return;
|
||||
}
|
||||
Object.keys(node.credentials).forEach((credentialType) => {
|
||||
const credential = node.credentials?.[credentialType];
|
||||
if (!credential?.id) {
|
||||
return;
|
||||
}
|
||||
if (!mapsWorkflowsToUsedCredentials[idx]) {
|
||||
mapsWorkflowsToUsedCredentials[idx] = [];
|
||||
}
|
||||
mapsWorkflowsToUsedCredentials[idx].push(credential.id);
|
||||
allUsedCredentialIds.add(credential.id);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
const usedWorkflowsCredentials = await EECredentials.getMany({
|
||||
where: {
|
||||
id: In(Array.from(allUsedCredentialIds)),
|
||||
},
|
||||
relations: ['shared', 'shared.user', 'shared.role'],
|
||||
});
|
||||
const userCredentials = await EECredentials.getAll(currentUser, { disableGlobalRole: true });
|
||||
const userCredentialIds = userCredentials.map((credential) => credential.id.toString());
|
||||
const credentialsMap: Record<string, CredentialUsedByWorkflow> = {};
|
||||
usedWorkflowsCredentials.forEach((credential) => {
|
||||
credentialsMap[credential.id.toString()] = {
|
||||
id: credential.id.toString(),
|
||||
name: credential.name,
|
||||
type: credential.type,
|
||||
currentUserHasAccess: userCredentialIds.includes(credential.id.toString()),
|
||||
sharedWith: [],
|
||||
ownedBy: null,
|
||||
};
|
||||
credential.shared?.forEach(({ user, role }) => {
|
||||
const { id, email, firstName, lastName } = user;
|
||||
if (role.name === 'owner') {
|
||||
credentialsMap[credential.id.toString()].ownedBy = { id, email, firstName, lastName };
|
||||
} else {
|
||||
credentialsMap[credential.id.toString()].sharedWith?.push({
|
||||
id,
|
||||
email,
|
||||
firstName,
|
||||
lastName,
|
||||
});
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
mapsWorkflowsToUsedCredentials.forEach((usedCredentialIds, idx) => {
|
||||
workflows[idx].usedCredentials = usedCredentialIds.map((id) => credentialsMap[id]);
|
||||
});
|
||||
}
|
||||
|
||||
static validateCredentialPermissionsToUser(
|
||||
workflow: WorkflowEntity,
|
||||
allowedCredentials: ICredentialsDb[],
|
||||
|
||||
Reference in New Issue
Block a user