From bc05faf0a6a0913013e4d46eefb1e45abc390883 Mon Sep 17 00:00:00 2001
From: Csaba Tuncsik <csaba@n8n.io>
Date: Fri, 17 May 2024 10:59:01 +0200
Subject: [PATCH] fix(editor): Fix workflow history TS errors (#9433)

---
 .../src/components/WorkflowHistory/WorkflowHistoryList.vue     | 2 +-
 .../src/components/WorkflowHistory/WorkflowHistoryListItem.vue | 2 +-
 .../WorkflowHistory/__tests__/WorkflowHistoryContent.test.ts   | 3 ++-
 .../WorkflowHistory/__tests__/WorkflowHistoryList.test.ts      | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryList.vue b/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryList.vue
index b1b92be32..2ebc2b6f4 100644
--- a/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryList.vue
+++ b/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryList.vue
@@ -138,7 +138,7 @@ const onItemMounted = ({
 			<span>
 				{{
 					i18n.baseText('workflowHistory.limit', {
-						interpolate: { evaluatedPruneTime: props.evaluatedPruneTime },
+						interpolate: { evaluatedPruneTime: String(props.evaluatedPruneTime) },
 					})
 				}}
 			</span>
diff --git a/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryListItem.vue b/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryListItem.vue
index b53c76da6..140f12b8d 100644
--- a/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryListItem.vue
+++ b/packages/editor-ui/src/components/WorkflowHistory/WorkflowHistoryListItem.vue
@@ -86,7 +86,7 @@ onMounted(() => {
 		isActive: props.isActive,
 	});
 	isAuthorElementTruncated.value =
-		authorElement.value?.scrollWidth > authorElement.value?.clientWidth;
+		(authorElement.value?.scrollWidth ?? 0) > (authorElement.value?.clientWidth ?? 0);
 });
 </script>
 <template>
diff --git a/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryContent.test.ts b/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryContent.test.ts
index 8f57126e1..078173f7b 100644
--- a/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryContent.test.ts
+++ b/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryContent.test.ts
@@ -1,4 +1,5 @@
 import { vi } from 'vitest';
+import type { MockInstance } from 'vitest';
 import { createPinia, setActivePinia } from 'pinia';
 import { waitFor } from '@testing-library/vue';
 import userEvent from '@testing-library/user-event';
@@ -19,7 +20,7 @@ const actions: UserAction[] = actionTypes.map((value) => ({
 const renderComponent = createComponentRenderer(WorkflowHistoryContent);
 
 let pinia: ReturnType<typeof createPinia>;
-let postMessageSpy: vi.SpyInstance;
+let postMessageSpy: MockInstance;
 
 describe('WorkflowHistoryContent', () => {
 	beforeEach(() => {
diff --git a/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryList.test.ts b/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryList.test.ts
index 696130401..24f618b55 100644
--- a/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryList.test.ts
+++ b/packages/editor-ui/src/components/WorkflowHistory/__tests__/WorkflowHistoryList.test.ts
@@ -31,7 +31,7 @@ let pinia: ReturnType<typeof createPinia>;
 
 describe('WorkflowHistoryList', () => {
 	beforeAll(() => {
-		Element.prototype.scrollTo = vi.fn();
+		Element.prototype.scrollTo = vi.fn(() => {});
 	});
 
 	beforeEach(() => {