From bf729aa2f01fb7afa42297580a4960002c9f482d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?=
 <netroy@users.noreply.github.com>
Date: Thu, 15 Feb 2024 11:35:50 +0100
Subject: [PATCH] refactor(editor): Do not use CodeNodeEditor anywhere except
 the Code node (no-changelog) (#8636)

---
 packages/@n8n/nodes-langchain/nodes/code/Code.node.ts     | 6 ++----
 .../nodes-langchain/nodes/tools/ToolCode/ToolCode.node.ts | 5 ++---
 packages/editor-ui/src/components/ChatEmbedModal.vue      | 8 ++++----
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/packages/@n8n/nodes-langchain/nodes/code/Code.node.ts b/packages/@n8n/nodes-langchain/nodes/code/Code.node.ts
index a54b982cd..145b6d1f7 100644
--- a/packages/@n8n/nodes-langchain/nodes/code/Code.node.ts
+++ b/packages/@n8n/nodes-langchain/nodes/code/Code.node.ts
@@ -158,8 +158,7 @@ export class Code implements INodeType {
 								name: 'code',
 								type: 'string',
 								typeOptions: {
-									editor: 'codeNodeEditor',
-									editorLanguage: 'javaScript',
+									editor: 'jsEditor',
 								},
 								default: defaultCodeExecute,
 								hint: 'This code will only run and return data if a "Main" input & output got created.',
@@ -176,8 +175,7 @@ export class Code implements INodeType {
 								name: 'code',
 								type: 'string',
 								typeOptions: {
-									editor: 'codeNodeEditor',
-									editorLanguage: 'javaScript',
+									editor: 'jsEditor',
 								},
 								default: defaultCodeSupplyData,
 								hint: 'This code will only run and return data if an output got created which is not "Main".',
diff --git a/packages/@n8n/nodes-langchain/nodes/tools/ToolCode/ToolCode.node.ts b/packages/@n8n/nodes-langchain/nodes/tools/ToolCode/ToolCode.node.ts
index cd983171d..78e70e9d5 100644
--- a/packages/@n8n/nodes-langchain/nodes/tools/ToolCode/ToolCode.node.ts
+++ b/packages/@n8n/nodes-langchain/nodes/tools/ToolCode/ToolCode.node.ts
@@ -99,8 +99,7 @@ export class ToolCode implements INodeType {
 					},
 				},
 				typeOptions: {
-					editor: 'codeNodeEditor',
-					editorLanguage: 'javaScript',
+					editor: 'jsEditor',
 				},
 				default:
 					'// Example: convert the incoming query to uppercase and return it\nreturn query.toUpperCase()',
@@ -120,7 +119,7 @@ export class ToolCode implements INodeType {
 					},
 				},
 				typeOptions: {
-					editor: 'codeNodeEditor',
+					editor: 'codeNodeEditor', // TODO: create a separate `pythonEditor` component
 					editorLanguage: 'python',
 				},
 				default:
diff --git a/packages/editor-ui/src/components/ChatEmbedModal.vue b/packages/editor-ui/src/components/ChatEmbedModal.vue
index 38d58e5df..26e0cbcbd 100644
--- a/packages/editor-ui/src/components/ChatEmbedModal.vue
+++ b/packages/editor-ui/src/components/ChatEmbedModal.vue
@@ -8,7 +8,7 @@ import { CHAT_EMBED_MODAL_KEY, CHAT_TRIGGER_NODE_TYPE, WEBHOOK_NODE_TYPE } from
 import { useRootStore } from '@/stores/n8nRoot.store';
 import { useWorkflowsStore } from '@/stores/workflows.store';
 import HtmlEditor from '@/components/HtmlEditor/HtmlEditor.vue';
-import CodeNodeEditor from '@/components/CodeNodeEditor/CodeNodeEditor.vue';
+import JsEditor from '@/components/JsEditor/JsEditor.vue';
 import { useI18n } from '@/composables/useI18n';
 
 const props = defineProps({
@@ -150,7 +150,7 @@ function closeDialog() {
 							{{ i18n.baseText('chatEmbed.install') }}
 						</n8n-text>
 					</div>
-					<CodeNodeEditor :model-value="commonCode.install" is-read-only />
+					<HtmlEditor :model-value="commonCode.install" is-read-only />
 				</div>
 
 				<div class="mb-s">
@@ -165,8 +165,8 @@ function closeDialog() {
 
 				<HtmlEditor v-if="currentTab === 'cdn'" :model-value="cdnCode" is-read-only />
 				<HtmlEditor v-if="currentTab === 'vue'" :model-value="vueCode" is-read-only />
-				<CodeNodeEditor v-if="currentTab === 'react'" :model-value="reactCode" is-read-only />
-				<CodeNodeEditor v-if="currentTab === 'other'" :model-value="otherCode" is-read-only />
+				<JsEditor v-if="currentTab === 'react'" :model-value="reactCode" is-read-only />
+				<JsEditor v-if="currentTab === 'other'" :model-value="otherCode" is-read-only />
 
 				<n8n-text>
 					{{ i18n.baseText('chatEmbed.packageInfo.description') }}