From c35f2b97b35445a4fe7ebf8bdc821cf306058457 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Thu, 13 Jul 2023 09:58:55 +0200 Subject: [PATCH] refactor: Remove outdated publicly accessible warning (no-changelog) (#6657) --- packages/cli/src/audit/constants.ts | 2 -- packages/cli/src/audit/risks/instance.risk.ts | 8 +------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/cli/src/audit/constants.ts b/packages/cli/src/audit/constants.ts index dae6fd44c..9c2658158 100644 --- a/packages/cli/src/audit/constants.ts +++ b/packages/cli/src/audit/constants.ts @@ -116,6 +116,4 @@ export const DB_QUERY_PARAMS_DOCS_URL = export const COMMUNITY_NODES_RISKS_URL = 'https://docs.n8n.io/integrations/community-nodes/risks'; -export const SELF_HOSTED_AUTH_DOCS_URL = 'https://docs.n8n.io/hosting/authentication'; - export const NPM_PACKAGE_URL = 'https://www.npmjs.com/package'; diff --git a/packages/cli/src/audit/risks/instance.risk.ts b/packages/cli/src/audit/risks/instance.risk.ts index d60859f38..7465e6228 100644 --- a/packages/cli/src/audit/risks/instance.risk.ts +++ b/packages/cli/src/audit/risks/instance.risk.ts @@ -4,7 +4,6 @@ import config from '@/config'; import { toFlaggedNode } from '@/audit/utils'; import { separate } from '@/utils'; import { - SELF_HOSTED_AUTH_DOCS_URL, ENV_VARS_DOCS_URL, INSTANCE_REPORT, WEBHOOK_NODE_TYPE, @@ -193,12 +192,7 @@ export async function reportInstanceRisk(workflows: WorkflowEntity[]) { report.sections.push({ title: INSTANCE_REPORT.SECTIONS.SECURITY_SETTINGS, description: 'This n8n instance has the following security settings.', - recommendation: securitySettings.publiclyAccessibleInstance - ? [ - 'Important! Your n8n instance is publicly accessible. Set up user management or basic/JWT auth to protect access to your n8n instance.'.toUpperCase(), - `See: ${SELF_HOSTED_AUTH_DOCS_URL}`, - ].join(' ') - : `Consider adjusting the security settings for your n8n instance based on your needs. See: ${ENV_VARS_DOCS_URL}`, + recommendation: `Consider adjusting the security settings for your n8n instance based on your needs. See: ${ENV_VARS_DOCS_URL}`, settings: securitySettings, }); }