feat: Migrate integer primary keys to nanoids (#6345)

* first commit for postgres migration

* (not working)

* sqlite migration

* quicksave

* fix tests

* fix pg test

* fix postgres

* fix variables import

* fix execution saving

* add user settings fix

* change migration to single lines

* patch preferences endpoint

* cleanup

* improve variable import

* cleanup unusued code

* Update packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts

Co-authored-by: Omar Ajoue <krynble@gmail.com>

* address review notes

* fix var update/import

* refactor: Separate execution data to its own table (#6323)

* wip: Temporary migration process

* refactor: Create boilerplate repository methods for executions

* fix: Lint issues

* refactor: Added search endpoint to repository

* refactor: Make the execution list work again

* wip: Updating how we create and update executions everywhere

* fix: Lint issues and remove most of the direct access to execution model

* refactor: Remove includeWorkflowData flag and fix more tests

* fix: Lint issues

* fix: Fixed ordering of executions for FE, removed transaction when saving execution and removed unnecessary update

* refactor: Add comment about missing feature

* refactor: Refactor counting executions

* refactor: Add migration for other dbms and fix issues found

* refactor: Fix lint issues

* refactor: Remove unnecessary comment and auto inject repo to internal hooks

* refactor: remove type assertion

* fix: Fix broken tests

* fix: Remove unnecessary import

* Remove unnecessary toString() call

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* fix: Address comments after review

* refactor: Remove unused import

* fix: Lint issues

* fix: Add correct migration files

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* remove null values from credential export

* fix: Fix an issue with queue mode where all running execution would be returned

* fix: Update n8n node to allow for workflow ids with letters

* set upstream on set branch

* remove typo

* add nodeAccess to credentials

* fix unsaved run check for undefined id

* fix(core): Rename version control feature to source control (#6480)

* rename versionControl to sourceControl

* fix source control tooltip wording

---------

Co-authored-by: Romain Minaud <romain.minaud@gmail.com>

* fix(editor): Pay 548 hide the set up version control button (#6485)

* feat(DebugHelper Node): Fix and include in main app (#6406)

* improve node a bit

* fixing continueOnFail() ton contain error in json

* improve pairedItem

* fix random data returning object results

* fix nanoId length typo

* update pnpm-lock file

---------

Co-authored-by: Marcus <marcus@n8n.io>

* fix(editor): Remove setup source control CTA button

* fix(editor): Remove setup source control CTA button

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>

* fix(editor): Update source control docs links (#6488)

* feat(DebugHelper Node): Fix and include in main app (#6406)

* improve node a bit

* fixing continueOnFail() ton contain error in json

* improve pairedItem

* fix random data returning object results

* fix nanoId length typo

* update pnpm-lock file

---------

Co-authored-by: Marcus <marcus@n8n.io>

* feat(editor): Replace root events with event bus events (no-changelog) (#6454)

* feat: replace root events with event bus events

* fix: prevent cypress from replacing global with globalThis in import path

* feat: remove emitter mixin

* fix: replace component events with event bus

* fix: fix linting issue

* fix: fix breaking expression switch

* chore: prettify ndv e2e suite code

* fix(editor): Update source control docs links

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>

* fix tag endpoint regex

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
This commit is contained in:
Michael Auerswald
2023-06-20 19:13:18 +02:00
committed by GitHub
parent da330f0648
commit c3ba0123ad
156 changed files with 3499 additions and 2594 deletions

View File

@@ -5,17 +5,17 @@ import { createPinia, setActivePinia, PiniaVuePlugin } from 'pinia';
import { merge } from 'lodash-es';
import { setupServer } from '@/__tests__/server';
import { i18nInstance } from '@/plugins/i18n';
import { useSettingsStore, useVersionControlStore } from '@/stores';
import SettingsVersionControl from '@/views/SettingsVersionControl.vue';
import { useSettingsStore, useSourceControlStore } from '@/stores';
import SettingsSourceControl from '@/views/SettingsSourceControl.vue';
let pinia: ReturnType<typeof createPinia>;
let server: ReturnType<typeof setupServer>;
let settingsStore: ReturnType<typeof useSettingsStore>;
let versionControlStore: ReturnType<typeof useVersionControlStore>;
let sourceControlStore: ReturnType<typeof useSourceControlStore>;
const renderComponent = (renderOptions: Parameters<typeof render>[1] = {}) =>
render(
SettingsVersionControl,
SettingsSourceControl,
merge(
{
pinia,
@@ -28,7 +28,7 @@ const renderComponent = (renderOptions: Parameters<typeof render>[1] = {}) =>
},
);
describe('SettingsVersionControl', () => {
describe('SettingsSourceControl', () => {
beforeAll(() => {
server = setupServer();
});
@@ -37,7 +37,7 @@ describe('SettingsVersionControl', () => {
pinia = createPinia();
setActivePinia(pinia);
settingsStore = useSettingsStore();
versionControlStore = useVersionControlStore();
sourceControlStore = useSourceControlStore();
});
afterEach(() => {
@@ -53,8 +53,8 @@ describe('SettingsVersionControl', () => {
const { getByTestId, queryByTestId } = renderComponent();
expect(queryByTestId('version-control-content-licensed')).not.toBeInTheDocument();
expect(getByTestId('version-control-content-unlicensed')).toBeInTheDocument();
expect(queryByTestId('source-control-content-licensed')).not.toBeInTheDocument();
expect(getByTestId('source-control-content-unlicensed')).toBeInTheDocument();
});
it('should render licensed content', () => {
@@ -62,18 +62,18 @@ describe('SettingsVersionControl', () => {
const { getByTestId, queryByTestId } = renderComponent();
expect(getByTestId('version-control-content-licensed')).toBeInTheDocument();
expect(queryByTestId('version-control-content-unlicensed')).not.toBeInTheDocument();
expect(queryByTestId('version-control-connected-content')).not.toBeInTheDocument();
expect(getByTestId('source-control-content-licensed')).toBeInTheDocument();
expect(queryByTestId('source-control-content-unlicensed')).not.toBeInTheDocument();
expect(queryByTestId('source-control-connected-content')).not.toBeInTheDocument();
});
it('should render user flow happy path', async () => {
vi.spyOn(settingsStore, 'isEnterpriseFeatureEnabled').mockReturnValue(true);
const updatePreferencesSpy = vi.spyOn(versionControlStore, 'updatePreferences');
const updatePreferencesSpy = vi.spyOn(sourceControlStore, 'updatePreferences');
const { container, getByTestId, queryByTestId, getByRole } = renderComponent();
const connectButton = getByTestId('version-control-connect-button');
const connectButton = getByTestId('source-control-connect-button');
expect(connectButton).toBeDisabled();
const repoUrlInput = container.querySelector('input[name="repoUrl"]')!;
@@ -105,16 +105,16 @@ describe('SettingsVersionControl', () => {
await userEvent.tab();
expect(connectButton).toBeEnabled();
expect(queryByTestId('version-control-save-settings-button')).not.toBeInTheDocument();
expect(queryByTestId('source-control-save-settings-button')).not.toBeInTheDocument();
await userEvent.click(connectButton);
await waitFor(() => expect(getByTestId('version-control-connected-content')).toBeVisible());
await waitFor(() => expect(getByTestId('source-control-connected-content')).toBeVisible());
const saveSettingsButton = getByTestId('version-control-save-settings-button');
const saveSettingsButton = getByTestId('source-control-save-settings-button');
expect(saveSettingsButton).toBeInTheDocument();
expect(saveSettingsButton).toBeDisabled();
const branchSelect = getByTestId('version-control-branch-select');
const branchSelect = getByTestId('source-control-branch-select');
await userEvent.click(within(branchSelect).getByRole('textbox'));
await waitFor(() => expect(within(branchSelect).getByText('main')).toBeVisible());
@@ -130,14 +130,14 @@ describe('SettingsVersionControl', () => {
});
await waitFor(() => expect(screen.getByText('Settings successfully saved')).toBeVisible());
await userEvent.click(getByTestId('version-control-disconnect-button'));
await userEvent.click(getByTestId('source-control-disconnect-button'));
const disconnectDialog = getByRole('dialog');
await waitFor(() => expect(disconnectDialog).toBeVisible());
await userEvent.click(within(disconnectDialog).getAllByRole('button')[1]);
await waitFor(() => expect(disconnectDialog).not.toBeVisible());
await waitFor(() =>
expect(queryByTestId('version-control-connected-content')).not.toBeInTheDocument(),
expect(queryByTestId('source-control-connected-content')).not.toBeInTheDocument(),
);
});
});