feat: Extend collection of usage metrics during license renewal (no-changelog) (#8369)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
This commit is contained in:
Cornelius Suermann
2024-01-22 12:29:28 +01:00
committed by GitHub
parent ebf2b0d55c
commit d597c2ab29
9 changed files with 212 additions and 16 deletions

View File

@@ -12,12 +12,12 @@ import {
UNLIMITED_LICENSE_QUOTA,
} from './constants';
import { SettingsRepository } from '@db/repositories/settings.repository';
import { WorkflowRepository } from '@db/repositories/workflow.repository';
import type { BooleanLicenseFeature, N8nInstanceType, NumericLicenseFeature } from './Interfaces';
import type { RedisServicePubSubPublisher } from './services/redis/RedisServicePubSubPublisher';
import { RedisService } from './services/redis.service';
import { OrchestrationService } from '@/services/orchestration.service';
import { OnShutdown } from '@/decorators/OnShutdown';
import { UsageMetricsService } from './services/usageMetrics.service';
type FeatureReturnType = Partial<
{
@@ -38,7 +38,7 @@ export class License {
private readonly instanceSettings: InstanceSettings,
private readonly orchestrationService: OrchestrationService,
private readonly settingsRepository: SettingsRepository,
private readonly workflowRepository: WorkflowRepository,
private readonly usageMetricsService: UsageMetricsService,
) {}
async init(instanceType: N8nInstanceType = 'main') {
@@ -63,7 +63,7 @@ export class License {
? async (features: TFeatures) => await this.onFeatureChange(features)
: async () => {};
const collectUsageMetrics = isMainInstance
? async () => await this.collectUsageMetrics()
? async () => await this.usageMetricsService.collectUsageMetrics()
: async () => [];
try {
@@ -91,15 +91,6 @@ export class License {
}
}
async collectUsageMetrics() {
return [
{
name: 'activeWorkflows',
value: await this.workflowRepository.count({ where: { active: true } }),
},
];
}
async loadCertStr(): Promise<TLicenseBlock> {
// if we have an ephemeral license, we don't want to load it from the database
const ephemeralLicense = config.get('license.cert');

View File

@@ -187,7 +187,7 @@ export class AuthController {
}
}
const users = await this.userRepository.findManybyIds([inviterId, inviteeId]);
const users = await this.userRepository.findManyByIds([inviterId, inviteeId]);
if (users.length !== 2) {
this.logger.debug(

View File

@@ -136,7 +136,7 @@ export class InvitationController {
const validPassword = this.passwordUtility.validate(password);
const users = await this.userRepository.findManybyIds([inviterId, inviteeId]);
const users = await this.userRepository.findManyByIds([inviterId, inviteeId]);
if (users.length !== 2) {
this.logger.debug(

View File

@@ -172,7 +172,7 @@ export class UsersController {
const userIds = transferId ? [transferId, idToDelete] : [idToDelete];
const users = await this.userRepository.findManybyIds(userIds);
const users = await this.userRepository.findManyByIds(userIds);
if (!users.length || (transferId && users.length !== 2)) {
throw new NotFoundError(

View File

@@ -0,0 +1,75 @@
import config from '@/config';
import { Service } from 'typedi';
import { DataSource, Repository, Entity } from 'typeorm';
@Entity()
export class UsageMetrics {}
@Service()
export class UsageMetricsRepository extends Repository<UsageMetrics> {
constructor(dataSource: DataSource) {
super(UsageMetrics, dataSource.manager);
}
toTableName(name: string) {
const tablePrefix = config.getEnv('database.tablePrefix');
let tableName =
config.getEnv('database.type') === 'mysqldb'
? `\`${tablePrefix}${name}\``
: `"${tablePrefix}${name}"`;
const pgSchema = config.getEnv('database.postgresdb.schema');
if (pgSchema !== 'public') tableName = [pgSchema, tablePrefix + name].join('.');
return tableName;
}
async getLicenseRenewalMetrics() {
type Row = {
enabled_user_count: string | number;
active_workflow_count: string | number;
total_workflow_count: string | number;
total_credentials_count: string | number;
production_executions_count: string | number;
manual_executions_count: string | number;
};
const userTable = this.toTableName('user');
const workflowTable = this.toTableName('workflow_entity');
const credentialTable = this.toTableName('credentials_entity');
const workflowStatsTable = this.toTableName('workflow_statistics');
const [
{
enabled_user_count: enabledUsers,
active_workflow_count: activeWorkflows,
total_workflow_count: totalWorkflows,
total_credentials_count: totalCredentials,
production_executions_count: productionExecutions,
manual_executions_count: manualExecutions,
},
] = (await this.query(`
SELECT
(SELECT COUNT(*) FROM ${userTable} WHERE disabled = false) AS enabled_user_count,
(SELECT COUNT(*) FROM ${workflowTable} WHERE active = true) AS active_workflow_count,
(SELECT COUNT(*) FROM ${workflowTable}) AS total_workflow_count,
(SELECT COUNT(*) FROM ${credentialTable}) AS total_credentials_count,
(SELECT SUM(count) FROM ${workflowStatsTable} WHERE name IN ('production_success', 'production_error')) AS production_executions_count,
(SELECT SUM(count) FROM ${workflowStatsTable} WHERE name IN ('manual_success', 'manual_error')) AS manual_executions_count;
`)) as Row[];
const toNumber = (value: string | number) =>
typeof value === 'number' ? value : parseInt(value, 10);
return {
enabledUsers: toNumber(enabledUsers),
activeWorkflows: toNumber(activeWorkflows),
totalWorkflows: toNumber(totalWorkflows),
totalCredentials: toNumber(totalCredentials),
productionExecutions: toNumber(productionExecutions),
manualExecutions: toNumber(manualExecutions),
};
}
}

View File

@@ -10,7 +10,7 @@ export class UserRepository extends Repository<User> {
super(User, dataSource.manager);
}
async findManybyIds(userIds: string[]) {
async findManyByIds(userIds: string[]) {
return await this.find({
where: { id: In(userIds) },
relations: ['globalRole'],

View File

@@ -0,0 +1,27 @@
import { UsageMetricsRepository } from '@/databases/repositories/usageMetrics.repository';
import { Service } from 'typedi';
@Service()
export class UsageMetricsService {
constructor(private readonly usageMetricsRepository: UsageMetricsRepository) {}
async collectUsageMetrics() {
const {
activeWorkflows,
totalWorkflows,
enabledUsers,
totalCredentials,
productionExecutions,
manualExecutions,
} = await this.usageMetricsRepository.getLicenseRenewalMetrics();
return [
{ name: 'activeWorkflows', value: activeWorkflows },
{ name: 'totalWorkflows', value: totalWorkflows },
{ name: 'enabledUsers', value: enabledUsers },
{ name: 'totalCredentials', value: totalCredentials },
{ name: 'productionExecutions', value: productionExecutions },
{ name: 'manualExecutions', value: manualExecutions },
];
}
}