mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Lint for no unneeded backticks (#5057) (no-changelog)

Browse Source 
* ✨ Create rule `no-unneeded-backticks`

* 👕 Enable rule

* ⚡ Run rule on `cli`

* ⚡ Run rule on `core`

* ⚡ Run rule on `workflow`

* ⚡ Rule rule on `design-system`

* ⚡ Run rule on `node-dev`

* ⚡ Run rule on `editor-ui`

* ⚡ Run rule on `nodes-base`
This commit is contained in:
Iván Ovejero
2022-12-29 12:20:43 +01:00
committed by GitHub
parent a7868ae77d
commit d9b98fc8be
239 changed files with 772 additions and 714 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/editor-ui/src/components/CodeEdit.vue
View File

@@ -122,11 +122,11 @@ export default mixins(genericHelpers, workflowHelpers).extend({
const proxy = dataProxy.getDataProxy();
const autoCompleteItems = [
`function $evaluateExpression(expression: string, itemIndex?: number): any {};`,
`function getNodeParameter(parameterName: string, itemIndex: number, fallbackValue?: any): any {};`,
`function getWorkflowStaticData(type: string): {};`,
`function $item(itemIndex: number, runIndex?: number): {};`,
`function $items(nodeName?: string, outputIndex?: number, runIndex?: number): {};`,
'function $evaluateExpression(expression: string, itemIndex?: number): any {};',
'function getNodeParameter(parameterName: string, itemIndex: number, fallbackValue?: any): any {};',
'function getWorkflowStaticData(type: string): {};',
'function $item(itemIndex: number, runIndex?: number): {};',
'function $items(nodeName?: string, outputIndex?: number, runIndex?: number): {};',
];
const baseKeys = [
@@ -194,7 +194,7 @@ export default mixins(genericHelpers, workflowHelpers).extend({
} catch (error) {}
}
autoCompleteItems.push(`const $node = ${JSON.stringify(nodes)}`);
autoCompleteItems.push(`function $jmespath(jsonDoc: object, query: string): {};`);
autoCompleteItems.push('function $jmespath(jsonDoc: object, query: string): {};');
if (this.codeAutocomplete === 'function') {
if (connectionInputData) {
@@ -204,13 +204,13 @@ export default mixins(genericHelpers, workflowHelpers).extend({
)}`,
);
} else {
autoCompleteItems.push(`const items: {json: {[key: string]: any}}[] = []`);
autoCompleteItems.push('const items: {json: {[key: string]: any}}[] = []');
}
} else if (this.codeAutocomplete === 'functionItem') {
if (connectionInputData) {
autoCompleteItems.push(`const item = $json`);
autoCompleteItems.push('const item = $json');
} else {
autoCompleteItems.push(`const item: {[key: string]: any} = {}`);
autoCompleteItems.push('const item: {[key: string]: any} = {}');
}
}

3
packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
View File

@@ -919,7 +919,8 @@ export default mixins(showMessage, nodeHelpers).extend({
return;
}
const params = `scrollbars=no,resizable=yes,status=no,titlebar=noe,location=no,toolbar=no,menubar=no,width=500,height=700`;
const params =
'scrollbars=no,resizable=yes,status=no,titlebar=noe,location=no,toolbar=no,menubar=no,width=500,height=700';
const oauthPopup = window.open(url, 'OAuth2 Authorization', params);
Vue.set(this.credentialData, 'oauthTokenData', null);

2
packages/editor-ui/src/components/Node.vue
View File

@@ -339,7 +339,7 @@ export default mixins(
nodeTitle(): string {
if (this.data.name === 'Start') {
return this.$locale.headerText({
key: `headers.start.displayName`,
key: 'headers.start.displayName',
fallback: 'Start',
});
}

2
packages/editor-ui/src/components/RunDataJsonActions.vue
View File

@@ -132,7 +132,7 @@ export default mixins(genericHelpers, nodeHelpers, pinData, copyPaste).extend({
let startPath = `$node["${this.node!.name}"].json`;
if (this.distanceFromActive === 1) {
startPath = `$json`;
startPath = '$json';
}
return { path, startPath };

11
packages/editor-ui/src/components/ValueSurvey.vue
View File

@@ -68,9 +68,11 @@ import { mapStores } from 'pinia';
import { useSettingsStore } from '@/stores/settings';
import { useRootStore } from '@/stores/n8nRootStore';
const DEFAULT_TITLE = `How likely are you to recommend n8n to a friend or colleague?`;
const GREAT_FEEDBACK_TITLE = `Great to hear! Can we reach out to see how we can make n8n even better for you?`;
const DEFAULT_FEEDBACK_TITLE = `Thanks for your feedback! We'd love to understand how we can improve. Can we reach out?`;
const DEFAULT_TITLE = 'How likely are you to recommend n8n to a friend or colleague?';
const GREAT_FEEDBACK_TITLE =
'Great to hear! Can we reach out to see how we can make n8n even better for you?';
const DEFAULT_FEEDBACK_TITLE =
"Thanks for your feedback! We'd love to understand how we can improve. Can we reach out?";
export default mixins(workflowHelpers).extend({
name: 'ValueSurvey',
@@ -164,7 +166,8 @@ export default mixins(workflowHelpers).extend({
});
this.$showMessage({
title: 'Thanks for your feedback',
message: `If you’d like to help even more, leave us a <a target="_blank" href="https://www.g2.com/products/n8n/reviews/start">review on G2</a>.`,
message:
'If you’d like to help even more, leave us a <a target="_blank" href="https://www.g2.com/products/n8n/reviews/start">review on G2</a>.',
type: 'success',
duration: 15000,
});

2
packages/editor-ui/src/components/WorkflowSettings.vue
View File

@@ -450,7 +450,7 @@ export default mixins(externalHooks, genericHelpers, restApi, showMessage).exten
if (!this.workflowId || this.workflowId === PLACEHOLDER_EMPTY_WORKFLOW_ID) {
this.$showMessage({
title: 'No workflow active',
message: `No workflow active to display settings of.`,
message: 'No workflow active to display settings of.',
type: 'error',
duration: 0,
});

2
packages/editor-ui/src/components/WorkflowShareModal.ee.vue
View File

@@ -370,7 +370,7 @@ export default mixins(showMessage).extend({
if (!isNewSharee && isLastUserWithAccessToCredentials) {
confirm = await this.confirmMessage(
this.$locale.baseText(
`workflows.shareModal.list.delete.confirm.lastUserWithAccessToCredentials.message`,
'workflows.shareModal.list.delete.confirm.lastUserWithAccessToCredentials.message',
{
interpolate: { name: user.fullName as string, workflow: this.workflow.name },
},