mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(core): Add filtering and pagination to GET /workflows (#6845)

Browse Source 
* Initial setup

* Specify max paginated items

* Simplify

* Add tests

* Add more tests

* Add migrations

* Add top-level property

* Add field selection

* Cleanup

* Rename `total` to `count`

* More cleanup

* Move query logic into `WorkflowRepository`

* Create `AbstractRepository`

* Cleanup

* Fix name

* Remove leftover comments

* Replace reference

* Add default for `rawSkip`

* Remove unneeded typing

* Switch to `class-validator`

* Simplify

* Simplify

* Type as optional

* Make typing more accurate

* Fix lint

* Use `getOwnPropertyNames`

* Use DSL

* Set schema at repo level

* Cleanup

* Remove comment

* Refactor repository methods to middleware

* Add middleware tests

* Remove old test files

* Remove generic experiment

* Reuse `reportError`

* Remove unused type

* Cleanup

* Improve wording

* Reduce diff

* Add missing mw

* Use `Container.get`

* Adjust lint rule

* Reorganize into subdir

* Remove unused directive

* Remove nodes

* Silly mistake

* Validate take

* refactor(core): Adjust index handling in new migrations DSL (no-changelog) (#6876)

* refactor(core): Adjust index handling in new migrations DSL (no-changelog)

* Account for custom index name

* Also for dropping

* Fix `select` issue with `relations`

* Tighten validation

* Ensure `ownerId` is not added when specifying `select`
This commit is contained in:
Iván Ovejero
2023-08-09 12:30:02 +02:00
committed by GitHub
parent f8ad543af5
commit dceff675ec
24 changed files with 481 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/cli/src/databases/dsl/Indices.ts
View File

@@ -4,11 +4,20 @@ import LazyPromise from 'p-lazy';
abstract class IndexOperation extends LazyPromise<void> {
abstract execute(queryRunner: QueryRunner): Promise<void>;
get fullTableName() {
return [this.tablePrefix, this.tableName].join('');
}
get fullIndexName() {
return ['IDX', `${this.tablePrefix}${this.tableName}`, ...this.columnNames].join('_');
}
constructor(
protected name: string,
protected tablePrefix: string,
protected tableName: string,
protected prefix: string,
protected columnNames: string[],
queryRunner: QueryRunner,
protected customIndexName?: string,
) {
super((resolve) => {
void this.execute(queryRunner).then(resolve);
@@ -18,28 +27,27 @@ abstract class IndexOperation extends LazyPromise<void> {
export class CreateIndex extends IndexOperation {
constructor(
name: string,
tablePrefix: string,
tableName: string,
protected columnNames: string[],
columnNames: string[],
protected isUnique: boolean,
prefix: string,
queryRunner: QueryRunner,
customIndexName?: string,
) {
super(name, tableName, prefix, queryRunner);
super(tablePrefix, tableName, columnNames, queryRunner, customIndexName);
}
async execute(queryRunner: QueryRunner) {
const { tableName, name, columnNames, prefix, isUnique } = this;
const { columnNames, isUnique } = this;
return queryRunner.createIndex(
`${prefix}${tableName}`,
new TableIndex({ name: `IDX_${prefix}${name}`, columnNames, isUnique }),
this.fullTableName,
new TableIndex({ name: this.customIndexName ?? this.fullIndexName, columnNames, isUnique }),
);
}
}
export class DropIndex extends IndexOperation {
async execute(queryRunner: QueryRunner) {
const { tableName, name, prefix } = this;
return queryRunner.dropIndex(`${prefix}${tableName}`, `IDX_${prefix}${name}`);
return queryRunner.dropIndex(this.fullTableName, this.customIndexName ?? this.fullIndexName);
}
}

20
packages/cli/src/databases/dsl/index.ts
View File

@@ -7,11 +7,19 @@ export const createSchemaBuilder = (tablePrefix: string, queryRunner: QueryRunne
column: (name: string) => new Column(name),
/* eslint-disable @typescript-eslint/promise-function-async */
// NOTE: Do not add `async` to these functions, as that messes up the lazy-evaluation of LazyPromise
createTable: (name: string) => new CreateTable(name, tablePrefix, queryRunner),
dropTable: (name: string) => new DropTable(name, tablePrefix, queryRunner),
createIndex: (name: string, tableName: string, columnNames: string[], isUnique = false) =>
new CreateIndex(name, tableName, columnNames, isUnique, tablePrefix, queryRunner),
dropIndex: (name: string, tableName: string) =>
new DropIndex(name, tableName, tablePrefix, queryRunner),
createTable: (tableName: string) => new CreateTable(tableName, tablePrefix, queryRunner),
dropTable: (tableName: string) => new DropTable(tableName, tablePrefix, queryRunner),
createIndex: (
tableName: string,
columnNames: string[],
isUnique = false,
customIndexName?: string,
) => new CreateIndex(tablePrefix, tableName, columnNames, isUnique, queryRunner, customIndexName),
dropIndex: (tableName: string, columnNames: string[], customIndexName?: string) =>
new DropIndex(tablePrefix, tableName, columnNames, queryRunner, customIndexName),
/* eslint-enable */
});