feat(editor): Migrate Design System and Editor UI to Vue 3 (#6476)
* feat: remove vue-fragment (no-changelog) * feat: partial design-system migration * feat: migrate info-accordion and info-tip components * feat: migrate several components to vue 3 * feat: migrated several components * feat: migrate several components * feat: migrate several components * feat: migrate several components * feat: re-exported all design system components * fix: fix design for popper components * fix: editor kind of working, lots of issues to fix * fix: fix several vue 3 migration issues * fix: replace @change with @update:modelValue in several places * fix: fix translation linking * fix: fix inline-edit input * fix: fix ndv and dialog design * fix: update parameter input event bindings * fix: rename deprecated lifecycle methods * fix: fix json view mapping * build: update lock file * fix(editor): revisit last conflict with master and fix issues * fix(editor): revisit last conflict with master and fix issues * fix: fix expression editor bug causing code mirror to no longer be reactive * fix: fix resource locator bug * fix: fix vue-agile integration * fix: remove global import for vue-agile * fix: replace element-plus buttons with n8n-buttons everywhere * fix(editor): Fix various element-plus styles (#6571) * fix(editor): Fix various element-plus styles Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Remove debugging code Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Address PR comments Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): Fix loading in production mode [Vue 3] (#6578) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): First round of e2e tests fixes with Vue 3 (#6579) * fix(editor): Fix broken smoke and workflow list e2e tests * ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests * feat: add vue 3 eslint rules and fix issues * fix: fix tags-dropdown * fix: fix white-space issues caused by i18n-t * fix: rename non-generic click events * fix: fix search in resources list layout * fix: fix datatable paginator * fix: fix popper select caret and dropdown size * fix: add width to action-dropdown * fix: fix workflow settings icon not being hidden * fix: refactor newly added code * fix: fix merge issue * fix: fix ndv credentials watcher * fix: fix workflow saving and grabber notch * fix: fix nodes list panel transition * fix: fix node title visibility * fix: fix data unpinning * fix: fix value access * fix: show input panel only if trigger panel enabled or not trigger node * fix: fix tags dropdown and executions status spcing * fix(editor): Prevent execution list to load back when leaving the route (#6697) fix(editor): prevent execution list to load back when leaving the route * fix: fix drawer visibility * fix: fix expression toggle padding * fix: fix expressions editor styling * chore: prepare for testing * fix: fix styling for el-button without patching * test: fix unit tests in design-system * test: fix most unit tests * fix: remove import cycle. * fix: fix personalization modal tests * fix further resource mapper test adjustments * fix: fix multiple tests and n8n-route attr duplication * fix: fix source control tets * fix: fixed remaining unit tests * fix: fix workflows and credentials e2e tests * fix: fix localizeNodeNames * fix: update ndv e2e tests * fix: fix popper left placement arrow * fix: fix 5-ndv e2e tests * fix: fix 6-code-node e2e tests * fix(editor): Drop click outside directive from NodeCreator (#6716) * fix(editor): Drop click outside directive from NodeCreator * fix(editor): make sure mouseup outside is unbound at least before the component is unmounted * fix: fix 10-settings-log-streaming e2e tests * fix: fix node redrawing * fix: fix tooltip buttons styling * fix: fix varous e2e suites * fix: fix 15-scheduler-node e2e suite * fix: fix route watcher * fix: fixed param name update and credential edit * feat: update event names * refactor: Remove deprecated `$data` (#6576) Co-authored-by: Alex Grozav <alex@grozav.com> * fix: fix 17-sharing e2e suite * fix: fix tags dropdown * fix: fix tags manager * fix(editor): move :deep selectors to a separate scoped style block * fix: fix sticky component and inline text edit * fix: update e2e tests * fix: remove button override references * fix(editor): Adjust spacing in templates for Vue 3 (#6744) * fix(editor): Adjust spacing in templates * fix: Undo unneeded change * fix: Undo unneeded change * fix(editor): Adjust NDV height for Vue 3 (#6742) fix(editor): Adjust NDV height * fix(editor): Restore collapsed sidebar items for Vue 3 (#6743) fix(editor): Restore collapsed sidebar items * fix: fix linting issues * fix: fix design-system deps * fix: post-merge fixes * fix: update tests * fix: increase timeout for executionslist tets * chore: fix linting issue * fix: fix 14-mapping e2e tests in ci * fix: re-enable tests * fix: fix workflow duplication e2e tests after tags update * fix(editor): Change component prop to be typed * fix: fix tags dropdown in duplicate wf modal * fix: fix focus behaviour in tags selector * fix: fix tag creation * fix: fix log streaming e2e race condition * fix(editor): Fix Vue 3 linting issues (#6748) * fix(editor): Fix Vue 3 linting issues Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix MainSidebar linter issues * revert pnpm lock * update pnpm lock file --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Some css fixes for vue3 branch (#6749) * ✨ Fixing filter button height * ✨ Update input modal button position * ✨ Updating tags styling * ✨ Fix event logging settings spacing * 👕 Fixing lint errors * fix: fix linting issues * Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix css issue * fix(editor): Lint fix * fix(editor): Fix settings initialisation (#6750) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix initial settings loading * fix: replace realClick with click force * fix: fix randomly failing mapping e2e tests * fix(editor): Fix menu item event handling * fix: fix resource filters dropdown events (#6752) * fix: fix resource filters dropdown events * fix: remove teleported:false * fix: fix event selection event naming (#6753) * fix: removed console.log (#6754) * fix: rever await nextTick changes * fix: redo linting changes * fix(editor): Redraw node connections if adding more than one node to canvas (#6755) * fix(editor): Redraw node connections if adding more than one node to canvas Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Update position before connection two nodes * Lint fix --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Fix `ResourceMapper` unit tests (#6758) * ✔️ Fix matching columns test * ✔️ Fix multiple matching columns test * ✔️ Removing `skip` from the last test * fix: Allow pasting a big workflow (#6760) * fix: pasting a big workflow * chore: update comment * refactor: move try/catch to function * refactor: move try/catch to function * fix(editor): Fix modal layer width * fix: fix position changes * fix: undo it.only * fix: make undo/redo multiple steps more verbose * fix: Fix value survey styles (#6764) * fix: fix value survey styles * fix: lint * Revert "fix: lint" 72869c431f1448861df021be041b61c62f1e3118 * fix: lint * fix(editor): Fix collapsed sub menu * fix: Fix drawer animation (#6767) fix: drawer animation * fix(editor): Fix source control buttons (#6769) * fix(editor): Fix App loading & auth (#6768) * fix(editor): Fix App loading & auth Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Await promises Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Fix eslint error Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Csaba Tuncsik <csaba@n8n.io> Co-authored-by: OlegIvaniv <me@olegivaniv.com> Co-authored-by: Milorad FIlipović <milorad@n8n.io> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
This commit is contained in:
Alex Grozav
GitHub
@@ -26,8 +26,8 @@
|
||||
<el-switch
|
||||
class="mr-s"
|
||||
:disabled="!isInstanceOwner"
|
||||
:value="nodeParameters.enabled"
|
||||
@change="onEnabledSwitched($event, destination.id)"
|
||||
:modelValue="nodeParameters.enabled"
|
||||
@update:modelValue="onEnabledSwitched($event, destination.id)"
|
||||
:title="
|
||||
nodeParameters.enabled
|
||||
? $locale.baseText('workflowActivator.deactivateWorkflow')
|
||||
@@ -96,7 +96,7 @@ export default defineComponent({
|
||||
);
|
||||
this.eventBus?.on('destinationWasSaved', this.onDestinationWasSaved);
|
||||
},
|
||||
destroyed() {
|
||||
beforeUnmount() {
|
||||
this.eventBus?.off('destinationWasSaved', this.onDestinationWasSaved);
|
||||
},
|
||||
computed: {
|
||||
|
||||
@@ -22,12 +22,12 @@
|
||||
<div :class="$style.header">
|
||||
<div :class="$style.destinationInfo">
|
||||
<InlineNameEdit
|
||||
:name="headerLabel"
|
||||
:modelValue="headerLabel"
|
||||
:subtitle="!isTypeAbstract ? $locale.baseText(typeLabelName) : 'Select type'"
|
||||
:readonly="isTypeAbstract"
|
||||
type="Credential"
|
||||
data-test-id="subtitle-showing-type"
|
||||
@input="onLabelChange"
|
||||
@update:modelValue="onLabelChange"
|
||||
/>
|
||||
</div>
|
||||
<div :class="$style.destinationActions">
|
||||
@@ -39,7 +39,6 @@
|
||||
? 'Event sent and returned OK'
|
||||
: 'Event returned with error'
|
||||
"
|
||||
size="medium"
|
||||
type="tertiary"
|
||||
label="Send Test-Event"
|
||||
:disabled="!hasOnceBeenSaved || !unchanged"
|
||||
@@ -51,7 +50,6 @@
|
||||
v-if="nodeParameters && hasOnceBeenSaved"
|
||||
:title="$locale.baseText('settings.log-streaming.delete')"
|
||||
icon="trash"
|
||||
size="medium"
|
||||
type="tertiary"
|
||||
:disabled="isSaving"
|
||||
:loading="isDeleting"
|
||||
@@ -83,9 +81,9 @@
|
||||
:underline="false"
|
||||
>
|
||||
<n8n-select
|
||||
:value="typeSelectValue"
|
||||
:modelValue="typeSelectValue"
|
||||
:placeholder="typeSelectPlaceholder"
|
||||
@change="onTypeSelectInput"
|
||||
@update:modelValue="onTypeSelectInput"
|
||||
data-test-id="select-destination-type"
|
||||
name="name"
|
||||
ref="typeSelectRef"
|
||||
@@ -146,24 +144,21 @@
|
||||
</template>
|
||||
</div>
|
||||
<div v-if="activeTab === 'events'" :class="$style.mainContent">
|
||||
<template>
|
||||
<div class="">
|
||||
<n8n-input-label
|
||||
class="mb-m mt-m"
|
||||
:label="$locale.baseText('settings.log-streaming.tab.events.title')"
|
||||
:bold="true"
|
||||
size="medium"
|
||||
:underline="false"
|
||||
/>
|
||||
<event-selection
|
||||
class=""
|
||||
:destinationId="destination.id"
|
||||
@input="onInput"
|
||||
@change="valueChanged"
|
||||
:readonly="!isInstanceOwner"
|
||||
/>
|
||||
</div>
|
||||
</template>
|
||||
<div class="">
|
||||
<n8n-input-label
|
||||
class="mb-m mt-m"
|
||||
:label="$locale.baseText('settings.log-streaming.tab.events.title')"
|
||||
:bold="true"
|
||||
size="medium"
|
||||
:underline="false"
|
||||
/>
|
||||
<event-selection
|
||||
:destinationId="destination.id"
|
||||
@input="onInput"
|
||||
@change="valueChanged"
|
||||
:readonly="!isInstanceOwner"
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
</template>
|
||||
</div>
|
||||
@@ -211,7 +206,7 @@ import InlineNameEdit from '@/components/InlineNameEdit.vue';
|
||||
import SaveButton from '@/components/SaveButton.vue';
|
||||
import EventSelection from '@/components/SettingsLogStreaming/EventSelection.ee.vue';
|
||||
import type { EventBus } from 'n8n-design-system';
|
||||
import { createEventBus } from 'n8n-design-system';
|
||||
import { createEventBus } from 'n8n-design-system/utils';
|
||||
|
||||
export default defineComponent({
|
||||
name: 'event-destination-settings-modal',
|
||||
@@ -360,7 +355,7 @@ export default defineComponent({
|
||||
onTypeSelectInput(destinationType: MessageEventBusDestinationTypeNames) {
|
||||
this.typeSelectValue = destinationType;
|
||||
},
|
||||
onContinueAddClicked() {
|
||||
async onContinueAddClicked() {
|
||||
let newDestination;
|
||||
switch (this.typeSelectValue) {
|
||||
case MessageEventBusDestinationTypeNames.syslog:
|
||||
@@ -380,6 +375,7 @@ export default defineComponent({
|
||||
);
|
||||
break;
|
||||
}
|
||||
|
||||
if (newDestination) {
|
||||
this.headerLabel = newDestination?.label ?? this.headerLabel;
|
||||
this.setupNode(newDestination);
|
||||
@@ -389,9 +385,9 @@ export default defineComponent({
|
||||
this.unchanged = false;
|
||||
this.testMessageSent = false;
|
||||
const newValue: NodeParameterValue = parameterData.value as string | number;
|
||||
const parameterPath = parameterData.name.startsWith('parameters.')
|
||||
const parameterPath = parameterData.name?.startsWith('parameters.')
|
||||
? parameterData.name.split('.').slice(1).join('.')
|
||||
: parameterData.name;
|
||||
: parameterData.name || '';
|
||||
|
||||
const nodeParameters = deepCopy(this.nodeParameters);
|
||||
|
||||
|
||||
@@ -7,9 +7,9 @@
|
||||
>
|
||||
<!-- <template #header> -->
|
||||
<checkbox
|
||||
:value="group.selected"
|
||||
:modelValue="group.selected"
|
||||
:indeterminate="!group.selected && group.indeterminate"
|
||||
@input="onInput"
|
||||
@update:modelValue="onInput"
|
||||
@change="onCheckboxChecked(group.name, $event)"
|
||||
:disabled="readonly"
|
||||
>
|
||||
@@ -20,7 +20,7 @@
|
||||
:popper-class="$style.tooltipPopper"
|
||||
class="ml-xs"
|
||||
>
|
||||
<n8n-icon icon="question-circle" size="small" />
|
||||
<n8n-icon icon="question-circle" size="small" class="ml-4xs" />
|
||||
<template #content>
|
||||
{{ groupLabelInfo(group.name) }}
|
||||
</template>
|
||||
@@ -28,14 +28,14 @@
|
||||
</checkbox>
|
||||
<checkbox
|
||||
v-if="group.name === 'n8n.audit'"
|
||||
:value="logStreamingStore.items[destinationId]?.destination.anonymizeAuditMessages"
|
||||
@input="onInput"
|
||||
:modelValue="logStreamingStore.items[destinationId]?.destination.anonymizeAuditMessages"
|
||||
@update:modelValue="onInput"
|
||||
@change="anonymizeAuditMessagesChanged"
|
||||
:disabled="readonly"
|
||||
>
|
||||
{{ $locale.baseText('settings.log-streaming.tab.events.anonymize') }}
|
||||
<n8n-tooltip placement="top" :popper-class="$style.tooltipPopper">
|
||||
<n8n-icon icon="question-circle" size="small" />
|
||||
<n8n-icon icon="question-circle" size="small" class="ml-4xs" />
|
||||
<template #content>
|
||||
{{ $locale.baseText('settings.log-streaming.tab.events.anonymize.info') }}
|
||||
</template>
|
||||
@@ -49,10 +49,10 @@
|
||||
:class="`${$style.eventListItem} ${group.selected ? $style.eventListItemDisabled : ''}`"
|
||||
>
|
||||
<checkbox
|
||||
:value="event.selected || group.selected"
|
||||
:modelValue="event.selected || group.selected"
|
||||
:indeterminate="event.indeterminate"
|
||||
:disabled="group.selected || readonly"
|
||||
@input="onInput"
|
||||
@update:modelValue="onInput"
|
||||
@change="onCheckboxChecked(event.name, $event)"
|
||||
>
|
||||
{{ event.label }}
|
||||
@@ -69,7 +69,7 @@
|
||||
</template>
|
||||
|
||||
<script lang="ts">
|
||||
import { Checkbox } from 'element-ui';
|
||||
import { ElCheckbox as Checkbox } from 'element-plus';
|
||||
import { mapStores } from 'pinia';
|
||||
import type { BaseTextKey } from '@/plugins/i18n';
|
||||
import { useLogStreamingStore } from '@/stores/logStreaming.store';
|
||||
|
||||
Reference in New Issue
Block a user