From 6f229f1f47dd0f6b86f5d0ced4da714830e4516e Mon Sep 17 00:00:00 2001 From: Rob Cunning Date: Thu, 8 Oct 2020 00:25:57 -0600 Subject: [PATCH 1/2] Add additional parameters to Pipedrive notes getAll --- .../nodes-base/nodes/Pipedrive/Pipedrive.node.ts | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts b/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts index dba5142e4..4d68980aa 100644 --- a/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts +++ b/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts @@ -1420,6 +1420,7 @@ export class Pipedrive implements INodeType { show: { operation: [ 'create', + 'getAll' ], resource: [ 'note', @@ -2516,13 +2517,25 @@ export class Pipedrive implements INodeType { // ---------------------------------- requestMethod = 'GET'; + endpoint = `/notes`; returnAll = this.getNodeParameter('returnAll', i) as boolean; if (returnAll === false) { qs.limit = this.getNodeParameter('limit', i) as number; } + const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject; - endpoint = `/notes`; + if (additionalFields.deal_id) { + qs.deal_id = parseInt(additionalFields.deal_id as string, 10); + } + + if (additionalFields.org_id) { + qs.org_id = parseInt(additionalFields.org_id as string, 10); + } + + if (additionalFields.person_id) { + qs.person_id = parseInt(additionalFields.person_id as string, 10); + } } else if (operation === 'update') { // ---------------------------------- From 62afc8a2fd0c9e425b80bdee730735a5a672bf8b Mon Sep 17 00:00:00 2001 From: Rob Cunning Date: Thu, 8 Oct 2020 14:55:51 -0600 Subject: [PATCH 2/2] use existing addAdditionalFields for merging additional fields into the query string --- .../nodes-base/nodes/Pipedrive/Pipedrive.node.ts | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts b/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts index 4d68980aa..c1236c46a 100644 --- a/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts +++ b/packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts @@ -2524,18 +2524,7 @@ export class Pipedrive implements INodeType { qs.limit = this.getNodeParameter('limit', i) as number; } const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject; - - if (additionalFields.deal_id) { - qs.deal_id = parseInt(additionalFields.deal_id as string, 10); - } - - if (additionalFields.org_id) { - qs.org_id = parseInt(additionalFields.org_id as string, 10); - } - - if (additionalFields.person_id) { - qs.person_id = parseInt(additionalFields.person_id as string, 10); - } + addAdditionalFields(qs, additionalFields); } else if (operation === 'update') { // ----------------------------------