mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Validate custom tool names for forbidden chars (#8878)

Browse Source
This commit is contained in:
Michael Kret
2024-03-14 10:03:33 +02:00
committed by GitHub
parent 4861556a1c
commit edce632ee6
5 changed files with 82 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
cypress/e2e/5-ndv.cy.ts
View File

@@ -1,6 +1,6 @@
import { v4 as uuid } from 'uuid';
import { getVisibleSelect } from '../utils';
import { MANUAL_TRIGGER_NODE_DISPLAY_NAME, AI_LANGUAGE_MODEL_OPENAI_CHAT_MODEL_NODE_NAME } from '../constants';
import { MANUAL_TRIGGER_NODE_DISPLAY_NAME } from '../constants';
import { NDV, WorkflowPage } from '../pages';
import { NodeCreator } from '../pages/features/node-creator';
@@ -485,13 +485,13 @@ describe('NDV', () => {
const connectionGroups = [
{
title: 'Language Models',
id: 'ai_languageModel'
id: 'ai_languageModel',
},
{
title: 'Tools',
id: 'ai_tool'
id: 'ai_tool',
},
]
];
workflowPage.actions.addInitialNodeToCanvas('AI Agent', { keepNdvOpen: true });
@@ -513,13 +513,16 @@ describe('NDV', () => {
cy.getByTestId(`add-subnode-${group.id}`).click();
nodeCreator.getters.getNthCreatorItem(1).click();
getFloatingNodeByPosition('outputSub').click({ force: true });
cy.getByTestId('subnode-connection-group-ai_tool').findChildByTestId('floating-subnode').should('have.length', 2);
cy.getByTestId('subnode-connection-group-ai_tool')
.findChildByTestId('floating-subnode')
.should('have.length', 2);
}
});
// Since language model has no credentials set, it should show an error
cy.get('[class*=hasIssues]').should('have.length', 1);
})
// Sinse code tool require alphanumeric tool name it would also show an error(2 errors, 1 for each tool node)
cy.get('[class*=hasIssues]').should('have.length', 3);
});
});
it('should show node name and version in settings', () => {
@@ -636,14 +639,17 @@ describe('NDV', () => {
it('Should open appropriate node creator after clicking on connection hint link', () => {
const nodeCreator = new NodeCreator();
const hintMapper = {
'Memory': 'AI Nodes',
Memory: 'AI Nodes',
'Output Parser': 'AI Nodes',
'Token Splitter': 'Document Loaders',
'Tool': 'AI Nodes',
'Embeddings': 'Vector Stores',
'Vector Store': 'Retrievers'
}
cy.createFixtureWorkflow('open_node_creator_for_connection.json', `open_node_creator_for_connection ${uuid()}`);
Tool: 'AI Nodes',
Embeddings: 'Vector Stores',
'Vector Store': 'Retrievers',
};
cy.createFixtureWorkflow(
'open_node_creator_for_connection.json',
`open_node_creator_for_connection ${uuid()}`,
);
Object.entries(hintMapper).forEach(([node, group]) => {
workflowPage.actions.openNode(node);
@@ -651,5 +657,5 @@ describe('NDV', () => {
nodeCreator.getters.activeSubcategory().should('contain', group);
cy.realPress('Escape');
});
})
});
});