refactor: Upgrade to ESLint 8 (#3722)

* ⬆️ Upgrade to ESLint 8

* 📦 Update package-lock.json

* 👕 Add lint exceptions

* 👕 Add more lint exceptions

* ➖ Remove `tslint` from some packages

* 👕 Except init file

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* 👕 Add exceptions to new lines coming from `master `

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

packages/cli/src/ActiveWorkflowRunner.ts

@@ -121,6 +121,7 @@ export class ActiveWorkflowRunner {
 						workflowName: workflowData.name,
 						workflowId: workflowData.id,
 					});
+					// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 					this.executeErrorWorkflow(error, workflowData, 'internal');
 				}
 			}

packages/cli/src/CredentialsHelper.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-non-null-assertion */
 /* eslint-disable no-restricted-syntax */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */

packages/cli/src/CredentialsOverwrites.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable no-underscore-dangle */
 import { ICredentialDataDecryptedObject } from 'n8n-workflow';
 

packages/cli/src/Logger.ts

@@ -40,6 +40,7 @@ export class Logger implements ILogger {
 					winston.format.printf(({ level, message, timestamp, metadata }) => {
 						// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
 						return `${timestamp} | ${level.padEnd(18)} | ${message}${
+							// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 							Object.keys(metadata).length ? ` ${JSON.stringify(inspect(metadata))}` : ''
 						}`;
 					}),

packages/cli/src/PublicApi/v1/handlers/credentials/credentials.handler.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 import express from 'express';
 
 import { CredentialsHelper } from '../../../../CredentialsHelper';

packages/cli/src/ResponseHelper.ts

@@ -158,6 +158,7 @@ export function send(processFunction: (req: Request, res: Response) => Promise<a
 				error.message = 'There is already an entry with this name';
 			}
 
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 			sendErrorResponse(res, error);
 		}
 	};

packages/cli/src/Server.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-unnecessary-boolean-literal-compare */
 /* eslint-disable @typescript-eslint/no-unnecessary-type-assertion */
 /* eslint-disable @typescript-eslint/no-use-before-define */

packages/cli/src/UserManagement/UserManagementHelper.ts

@@ -254,6 +254,7 @@ export async function compareHash(plaintext: string, hashed: string): Promise<bo
 				'. Comparison against unhashed string. Please check that the value compared against has been hashed.';
 		}
 
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 		throw new Error(error);
 	}
 }

packages/cli/src/WebhookHelpers.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable import/no-cycle */
 /* eslint-disable @typescript-eslint/no-unsafe-call */
 /* eslint-disable no-param-reassign */
@@ -125,6 +126,7 @@ export function encodeWebhookResponse(
 ): IExecuteResponsePromiseData {
 	if (typeof response === 'object' && Buffer.isBuffer(response.body)) {
 		response.body = {
+			// eslint-disable-next-line @typescript-eslint/naming-convention
 			'__@N8nEncodedBuffer@__': response.body.toString(BINARY_ENCODING),
 		};
 	}

packages/cli/src/WebhookServer.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable no-console */
 /* eslint-disable consistent-return */
 /* eslint-disable @typescript-eslint/restrict-plus-operands */

packages/cli/src/WorkflowExecuteAdditionalData.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable import/no-cycle */
 /* eslint-disable no-restricted-syntax */
 /* eslint-disable @typescript-eslint/restrict-plus-operands */

packages/cli/src/WorkflowRunner.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable no-restricted-syntax */
 /* eslint-disable no-console */
 /* eslint-disable @typescript-eslint/no-non-null-assertion */

packages/cli/src/WorkflowRunnerProcess.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable consistent-return */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */

packages/cli/src/api/credentials.api.ts

@@ -83,6 +83,7 @@ credentialsController.get(
 				});
 			}
 		} catch (error) {
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 			LoggerProxy.error('Request to list credentials failed', error);
 			throw error;
 		}

packages/cli/src/api/nodes.api.ts

@@ -61,7 +61,7 @@ nodesController.post(
 		try {
 			parsedPackageName = parsePackageName(name);
 		} catch (error) {
-			// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
 			throw new ResponseHelper.ResponseError(error.message, undefined, 400);
 		}
 
@@ -166,14 +166,14 @@ nodesController.get(
 			// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
 			if (error.code === 1) {
 				// Updates available
-				// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
+				// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument
 				pendingUpdates = JSON.parse(error.stdout);
 			}
 		}
 		let hydratedPackages = matchPackagesWithUpdates(packages, pendingUpdates);
 		try {
 			if (config.get('nodes.packagesMissing')) {
-				// eslint-disable-next-line prettier/prettier
+				// eslint-disable-next-line prettier/prettier, @typescript-eslint/no-unsafe-argument
 				hydratedPackages = matchMissingPackages(hydratedPackages, config.get('nodes.packagesMissing'));
 			}
 		} catch (error) {

packages/cli/src/api/oauth2Credential.api.ts

@@ -338,6 +338,7 @@ oauth2CredentialController.get(
 			return res.sendFile(pathResolve(__dirname, '../../../templates/oauth-callback.html'));
 		} catch (error) {
 			// Error response
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 			return ResponseHelper.sendErrorResponse(res, error);
 		}
 	},